Re: [Intel-gfx] [RFC][PATCH 3/3] drm/i915: Make RPS enable immediate

2016-05-24 Thread Chris Wilson
On Tue, May 24, 2016 at 01:14:53PM +0300, Ville Syrjälä wrote: > On Tue, May 24, 2016 at 10:27:19AM +0200, Daniel Vetter wrote: > > On Mon, May 23, 2016 at 05:09:43PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > On SNB (at least) it's dangeruopus to hang

Re: [Intel-gfx] [RFC][PATCH 3/3] drm/i915: Make RPS enable immediate

2016-05-24 Thread Ville Syrjälä
On Tue, May 24, 2016 at 10:27:19AM +0200, Daniel Vetter wrote: > On Mon, May 23, 2016 at 05:09:43PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > On SNB (at least) it's dangeruopus to hang the GPU with an infinite > > batch buffer loop while RPS is disabled. The only

Re: [Intel-gfx] [RFC][PATCH 3/3] drm/i915: Make RPS enable immediate

2016-05-24 Thread Daniel Vetter
On Mon, May 23, 2016 at 05:09:43PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > On SNB (at least) it's dangeruopus to hang the GPU with an infinite > batch buffer loop while RPS is disabled. The only thing that keeps > the system going in such circumstances are the intern

Re: [Intel-gfx] [RFC][PATCH 3/3] drm/i915: Make RPS enable immediate

2016-05-23 Thread Chris Wilson
On Mon, May 23, 2016 at 05:09:43PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > On SNB (at least) it's dangeruopus to hang the GPU with an infinite > batch buffer loop while RPS is disabled. The only thing that keeps > the system going in such circumstances are the intern

[Intel-gfx] [RFC][PATCH 3/3] drm/i915: Make RPS enable immediate

2016-05-23 Thread ville . syrjala
From: Ville Syrjälä On SNB (at least) it's dangeruopus to hang the GPU with an infinite batch buffer loop while RPS is disabled. The only thing that keeps the system going in such circumstances are the internal RPS timers, so we should never feed the GPU with RPS disabled unless we want to risk a