Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-12-05 Thread Dmitry Baryshkov
On Thu, 30 Nov 2023 at 11:18, Maxime Ripard wrote: > > Hi, > > On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > > Cc: Nathan Chancellor > > > > > > On 11/29/23 13:12, Jani Nikula wrote: > > >> At least the i915 and amd drivers enable

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-12-05 Thread Sui Jingfeng
Hi, I'm agree with you. On 2023/11/30 02:12, Jani Nikula wrote: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-12-01 Thread Nathan Chancellor
On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > Cc: Nathan Chancellor > > > > On 11/29/23 13:12, Jani Nikula wrote: > >> At least the i915 and amd drivers enable a bunch more compiler warnings > >> than the kernel defaults. > >> > >>

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Thu, Nov 30, 2023 at 11:46:00AM +0200, Jani Nikula wrote: [...] >> >> Then we'll have a ping pong of people not using W=1 or >> CONFIG_DRM_EXTRA_CHECKS introducing warnings, and people using them >> fixing the warnings... >> >> I really do think making it

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Thomas Zimmermann
Am 29.11.23 um 19:12 schrieb Jani Nikula: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Maxime Ripard
On Thu, Nov 30, 2023 at 11:46:00AM +0200, Jani Nikula wrote: > On Thu, 30 Nov 2023, Javier Martinez Canillas wrote: > > Maxime Ripard writes: > > > >> Hi, > >> > >> On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > >>> On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > >>> > Cc: Nathan

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Javier Martinez Canillas
Jani Nikula writes: [...] > > Then I'd go for enabling in drm level and disabling individual warnings > in the driver Makefile level if they won't get fixed. > >> Maybe add a Kconfig symbol for it instead of making unconditional? >> >> Something like: >> >> +# Unconditionally enable W=1

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Jani Nikula
On Thu, 30 Nov 2023, Javier Martinez Canillas wrote: > Maxime Ripard writes: > >> Hi, >> >> On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: >>> On Wed, 29 Nov 2023, Hamza Mahfooz wrote: >>> > Cc: Nathan Chancellor >>> > >>> > On 11/29/23 13:12, Jani Nikula wrote: >>> >> At least

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Javier Martinez Canillas
Maxime Ripard writes: > Hi, > > On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: >> On Wed, 29 Nov 2023, Hamza Mahfooz wrote: >> > Cc: Nathan Chancellor >> > >> > On 11/29/23 13:12, Jani Nikula wrote: >> >> At least the i915 and amd drivers enable a bunch more compiler warnings >>

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Maxime Ripard
Hi, On Thu, Nov 30, 2023 at 10:52:17AM +0200, Jani Nikula wrote: > On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > > Cc: Nathan Chancellor > > > > On 11/29/23 13:12, Jani Nikula wrote: > >> At least the i915 and amd drivers enable a bunch more compiler warnings > >> than the kernel defaults. > >>

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-30 Thread Jani Nikula
On Wed, 29 Nov 2023, Hamza Mahfooz wrote: > Cc: Nathan Chancellor > > On 11/29/23 13:12, Jani Nikula wrote: >> At least the i915 and amd drivers enable a bunch more compiler warnings >> than the kernel defaults. >> >> Extend the W=1 warnings to the entire drm subsystem by default. Use the >>

Re: [Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-29 Thread Hamza Mahfooz
Cc: Nathan Chancellor On 11/29/23 13:12, Jani Nikula wrote: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with

[Intel-gfx] [RFC] drm: enable W=1 warnings by default across the subsystem

2023-11-29 Thread Jani Nikula
At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare and