Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2022-10-28 Thread Brian Norris
Hi, On Thu, Aug 16, 2018 at 03:40:38PM +0800, Feng Tang wrote: > On Tue, Aug 14, 2018 at 11:39:48AM +0200, Takashi Iwai wrote: > > FYI, the upcoming 4.19 will have the completion in audio side binding, > > so this problem should be solved there. > > Really a great news! thanks for sharing For

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-16 Thread Feng Tang
On Tue, Aug 14, 2018 at 11:39:48AM +0200, Takashi Iwai wrote: > On Tue, 14 Aug 2018 11:34:07 +0200, > Daniel Vetter wrote: > > > > On Tue, Aug 14, 2018 at 02:54:31PM +0800, Feng Tang wrote: > > > Hi Jani, Daniel > > > > > > Could you help to comment? thanks, > > > > > > - Feng > > > > > > On

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-14 Thread Takashi Iwai
On Tue, 14 Aug 2018 11:34:07 +0200, Daniel Vetter wrote: > > On Tue, Aug 14, 2018 at 02:54:31PM +0800, Feng Tang wrote: > > Hi Jani, Daniel > > > > Could you help to comment? thanks, > > > > - Feng > > > > On Thu, Jul 12, 2018 at 03:51:34PM +0800, Feng Tang wrote: > > > Hi Daniel, > > > > > >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-14 Thread Daniel Vetter
On Tue, Aug 14, 2018 at 02:54:31PM +0800, Feng Tang wrote: > Hi Jani, Daniel > > Could you help to comment? thanks, > > - Feng > > On Thu, Jul 12, 2018 at 03:51:34PM +0800, Feng Tang wrote: > > Hi Daniel, > > > > On Thu, Jul 12, 2018 at 08:54:34AM +0200, Daniel Vetter wrote: > > > On Thu, Jul

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-08-14 Thread Feng Tang
Hi Jani, Daniel Could you help to comment? thanks, - Feng On Thu, Jul 12, 2018 at 03:51:34PM +0800, Feng Tang wrote: > Hi Daniel, > > On Thu, Jul 12, 2018 at 08:54:34AM +0200, Daniel Vetter wrote: > > On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > > > On Tue, Jun 26, 2018 at

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Feng Tang
On Thu, Jul 12, 2018 at 09:37:41AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 8:56 AM, Takashi Iwai wrote: > > On Thu, 12 Jul 2018 08:54:34 +0200, > > Daniel Vetter wrote: > >> > >> On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > >> > On Tue, Jun 26, 2018 at 10:29:16AM

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Feng Tang
Hi Daniel, On Thu, Jul 12, 2018 at 08:54:34AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > > > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > > > > > Hi

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 8:56 AM, Takashi Iwai wrote: > On Thu, 12 Jul 2018 08:54:34 +0200, > Daniel Vetter wrote: >> >> On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: >> > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: >> > > On Mon, Jun 25, 2018 at 05:36:32PM +0200,

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Takashi Iwai
On Thu, 12 Jul 2018 08:54:34 +0200, Daniel Vetter wrote: > > On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > > > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > > > > > Hi Daneil/Jani/Takashi, > > > >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-12 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 09:29:01AM +0800, Feng Tang wrote: > On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > > > Hi Daneil/Jani/Takashi, > > > > When I was testing this patch from Takashi, I further checked the

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-07-11 Thread Feng Tang
On Tue, Jun 26, 2018 at 10:29:16AM +0800, Feng Tang wrote: > On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > Hi Daneil/Jani/Takashi, > > When I was testing this patch from Takashi, I further checked the kernel > module code, and found that: we may need NOT to add any new codes

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-25 Thread Feng Tang
On Mon, Jun 25, 2018 at 05:36:32PM +0200, Daniel Vetter wrote: > > > The binding with i915 from HD-audio controller is done in an async > > work invoked from the probe callback. It makes harder to deal with > > EPROBEDEFER. > > > > IMO, a saner way would be to rather wait for the component

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-25 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 11:45:25AM +0200, Takashi Iwai wrote: > On Wed, 20 Jun 2018 10:02:42 +0200, > Daniel Vetter wrote: > > > > On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > > > On Wed, 20 Jun 2018, Feng Tang wrote: > > > > Hi Takashi, > > > > > > > > On Wed, Jun 20, 2018 at

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-21 Thread Feng Tang
Hi, On Wed, Jun 20, 2018 at 11:45:25AM +0200, Takashi Iwai wrote: > > > > > > > > Thanks for the info, I see your intension now. > > > > > > > > In previous discussion, Jani suggested to use a completion to indicate > > > > the probe done, I can't figure out another way :) > > > > > > I

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Jani Nikula
On Wed, 20 Jun 2018, Feng Tang wrote: > On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: >> I suggested you do that within hdac_i915.c. Wait in snd_hdac_i915_init() >> below request_module(), complete in hdac_component_master_bind(). > > Sorry, I'm not familiar with the i915 HDAC

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Takashi Iwai
On Wed, 20 Jun 2018 10:02:42 +0200, Daniel Vetter wrote: > > On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > > On Wed, 20 Jun 2018, Feng Tang wrote: > > > Hi Takashi, > > > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > > >> On Wed, 20 Jun 2018 08:25:23

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Jani, On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > On Wed, 20 Jun 2018, Feng Tang wrote: > > Hi Takashi, > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > >> On Wed, 20 Jun 2018 08:25:23 +0200, > >> Feng Tang wrote: > >> > > >> > Hi

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > On Wed, 20 Jun 2018, Feng Tang wrote: > > Hi Takashi, > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > >> On Wed, 20 Jun 2018 08:25:23 +0200, > >> Feng Tang wrote: > >> > > >> > Hi Jani/Chris/Takashi, > >> >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Jani Nikula
On Wed, 20 Jun 2018, Feng Tang wrote: > Hi Takashi, > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: >> On Wed, 20 Jun 2018 08:25:23 +0200, >> Feng Tang wrote: >> > >> > Hi Jani/Chris/Takashi, >> > >> > On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: >> > > >>

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Takashi, On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > On Wed, 20 Jun 2018 08:25:23 +0200, > Feng Tang wrote: > > > > Hi Jani/Chris/Takashi, > > > > On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: > > > >> > > > >>

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Takashi Iwai
On Wed, 20 Jun 2018 08:25:23 +0200, Feng Tang wrote: > > Hi Jani/Chris/Takashi, > > On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: > > >> > > >> http://patchwork.freedesktop.org/patch/msgid/20180323083048.13327-1-ch...@chris-wilson.co.uk > > > > > > IIUC, you are waiting for the

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Jani/Chris/Takashi, On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: > >> > >> http://patchwork.freedesktop.org/patch/msgid/20180323083048.13327-1-ch...@chris-wilson.co.uk > > > > IIUC, you are waiting for the HDA audio driver to first handle the > > i915 sync probel case? > > I

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-06 Thread Jani Nikula
On Wed, 06 Jun 2018, Feng Tang wrote: > Hi Jani, > > On Tue, Jun 05, 2018 at 11:18:46AM +0300, Jani Nikula wrote: >> On Tue, 05 Jun 2018, Feng Tang wrote: >> > Hi Jani, >> > >> > On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: >> >> On Mon, 04 Jun 2018, Feng Tang wrote: >> >> >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-06 Thread Feng Tang
Hi Jani, On Tue, Jun 05, 2018 at 11:18:46AM +0300, Jani Nikula wrote: > On Tue, 05 Jun 2018, Feng Tang wrote: > > Hi Jani, > > > > On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: > >> On Mon, 04 Jun 2018, Feng Tang wrote: > >> > i915 driver's probe is one of the longest of pci

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-05 Thread Jani Nikula
On Tue, 05 Jun 2018, Feng Tang wrote: > Hi Jani, > > On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: >> On Mon, 04 Jun 2018, Feng Tang wrote: >> > i915 driver's probe is one of the longest of pci devices, which takes >> > about hundreds of microseconds or more, make the probe async

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-05 Thread Feng Tang
Hi Jani, On Tue, Jun 05, 2018 at 10:41:04AM +0300, Jani Nikula wrote: > On Mon, 04 Jun 2018, Feng Tang wrote: > > i915 driver's probe is one of the longest of pci devices, which takes > > about hundreds of microseconds or more, make the probe async will help > > much on the kernel boot time, as

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-05 Thread Jani Nikula
On Mon, 04 Jun 2018, Feng Tang wrote: > i915 driver's probe is one of the longest of pci devices, which takes > about hundreds of microseconds or more, make the probe async will help > much on the kernel boot time, as different driver's probe can go async. > > This have been limited verified on

[Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-03 Thread Feng Tang
i915 driver's probe is one of the longest of pci devices, which takes about hundreds of microseconds or more, make the probe async will help much on the kernel boot time, as different driver's probe can go async. This have been limited verified on several platforms of mine, don't know if it will