Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2018-01-02 Thread Sagar Arun Kamble
On 12/28/2017 10:43 PM, Lionel Landwerlin wrote: On 26/12/17 05:32, Sagar Arun Kamble wrote: On 12/22/2017 3:46 PM, Lionel Landwerlin wrote: On 22/12/17 09:30, Sagar Arun Kamble wrote: On 12/21/2017 6:29 PM, Lionel Landwerlin wrote: Some more findings I made while playing with this se

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-28 Thread Lionel Landwerlin
On 26/12/17 05:32, Sagar Arun Kamble wrote: On 12/22/2017 3:46 PM, Lionel Landwerlin wrote: On 22/12/17 09:30, Sagar Arun Kamble wrote: On 12/21/2017 6:29 PM, Lionel Landwerlin wrote: Some more findings I made while playing with this series & GPUTop. Turns out the 2ms drift per second is

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-25 Thread Sagar Arun Kamble
On 12/22/2017 3:46 PM, Lionel Landwerlin wrote: On 22/12/17 09:30, Sagar Arun Kamble wrote: On 12/21/2017 6:29 PM, Lionel Landwerlin wrote: Some more findings I made while playing with this series & GPUTop. Turns out the 2ms drift per second is due to timecounter. Adding the delta this wa

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-22 Thread Lionel Landwerlin
On 22/12/17 09:30, Sagar Arun Kamble wrote: On 12/21/2017 6:29 PM, Lionel Landwerlin wrote: Some more findings I made while playing with this series & GPUTop. Turns out the 2ms drift per second is due to timecounter. Adding the delta this way : https://github.com/djdeath/linux/commit/7b002

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-22 Thread Sagar Arun Kamble
On 12/21/2017 6:29 PM, Lionel Landwerlin wrote: Some more findings I made while playing with this series & GPUTop. Turns out the 2ms drift per second is due to timecounter. Adding the delta this way : https://github.com/djdeath/linux/commit/7b002cb360483e331053aec0f98433a5bd5c5c3f#diff-9b74b

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-21 Thread Sagar Arun Kamble
On 12/7/2017 6:18 AM, Robert Bragg wrote: On Wed, Nov 15, 2017 at 12:13 PM, Sagar Arun Kamble mailto:sagar.a.kam...@intel.com>> wrote: We can compute system time corresponding to GPU timestamp by taking a reference point (CPU monotonic time, GPU timestamp) and then adding delta

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-21 Thread Sagar Arun Kamble
On 12/22/2017 10:45 AM, Sagar Arun Kamble wrote: On 12/7/2017 1:32 AM, Lionel Landwerlin wrote: I've put together some trival IGT tests : https://github.com/djdeath/intel-gpu-tools/commits/wip/djdeath/cpu-timestamps With a few changes which I pointed in the review : https://github.com/djde

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-21 Thread Sagar Arun Kamble
On 12/7/2017 1:32 AM, Lionel Landwerlin wrote: I've put together some trival IGT tests : https://github.com/djdeath/intel-gpu-tools/commits/wip/djdeath/cpu-timestamps With a few changes which I pointed in the review : https://github.com/djdeath/linux/commit/d0e4cf4d3f464491b4ffe97d112284d1ce73

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-21 Thread Lionel Landwerlin
Some more findings I made while playing with this series & GPUTop. Turns out the 2ms drift per second is due to timecounter. Adding the delta this way : https://github.com/djdeath/linux/commit/7b002cb360483e331053aec0f98433a5bd5c5c3f#diff-9b74bd0cfaa90b601d80713c7bd56be4R607 Eliminates the dri

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-06 Thread Robert Bragg
On Thu, Dec 7, 2017 at 12:48 AM, Robert Bragg wrote: > > at least from what I wrote back then it looks like I was seeing a drift of > a few milliseconds per second on SKL. I vaguely recall it being much worse > given the frequency constants we had for Haswell. > Sorry I didn't actually re-read m

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-06 Thread Robert Bragg
On Wed, Nov 15, 2017 at 12:13 PM, Sagar Arun Kamble < sagar.a.kam...@intel.com> wrote: > We can compute system time corresponding to GPU timestamp by taking a > reference point (CPU monotonic time, GPU timestamp) and then adding > delta time computed using timecounter/cyclecounter support in kerne

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-06 Thread Lionel Landwerlin
I've put together some trival IGT tests : https://github.com/djdeath/intel-gpu-tools/commits/wip/djdeath/cpu-timestamps With a few changes which I pointed in the review : https://github.com/djdeath/linux/commit/d0e4cf4d3f464491b4ffe97d112284d1ce73656d Put together it seems to work relatively we

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-06 Thread Sagar Arun Kamble
On 12/5/2017 8:07 PM, Lionel Landwerlin wrote: On 05/12/17 14:28, Robert Bragg wrote: On Tue, Dec 5, 2017 at 2:16 PM, Lionel Landwerlin > wrote: Hey Sagar, Sorry for the delay looking into this series. I've done some userspace/UI work in

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Lionel Landwerlin
On 05/12/17 14:28, Robert Bragg wrote: On Tue, Dec 5, 2017 at 2:16 PM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Hey Sagar, Sorry for the delay looking into this series. I've done some userspace/UI work in GPUTop to try to correlate perf samples/tracep

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Robert Bragg
On Tue, Dec 5, 2017 at 2:16 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Hey Sagar, > > Sorry for the delay looking into this series. > I've done some userspace/UI work in GPUTop to try to correlate perf > samples/tracepoints with i915 perf reports. > > I wanted to avoid having

Re: [Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-12-05 Thread Lionel Landwerlin
Hey Sagar, Sorry for the delay looking into this series. I've done some userspace/UI work in GPUTop to try to correlate perf samples/tracepoints with i915 perf reports. I wanted to avoid having to add too much logic into the kernel and tried to sample both cpu clocks & gpu timestamps from use

[Intel-gfx] [RFC 0/4] GPU/CPU timestamps correlation for relating OA samples with system events

2017-11-15 Thread Sagar Arun Kamble
We can compute system time corresponding to GPU timestamp by taking a reference point (CPU monotonic time, GPU timestamp) and then adding delta time computed using timecounter/cyclecounter support in kernel. We have to configure cyclecounter with the GPU timestamp frequency. Earlier approach that w