Re: [Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-27 Thread Daniel Vetter
On Mon, Oct 27, 2014 at 02:55:40PM +0530, Kannan, Vandana wrote: > I went through the LVDS and DSI parts. If software delays are used for both, > would it really add more value to have the delays in a function in > intel_panel.c and call whenever required ? > I'm thinking directly calling a msleep

Re: [Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-27 Thread Kannan, Vandana
On 20-Oct-14 9:38 PM, Daniel Vetter wrote: On Mon, Oct 20, 2014 at 06:20:06PM +0530, Vandana Kannan wrote: Actually set values into PPS related registers. This implementation is equivalent to intel_dp_panel_power_sequencer_registers where the values saved intially are written into registers.

Re: [Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-20 Thread Ville Syrjälä
On Mon, Oct 20, 2014 at 06:08:48PM +0200, Daniel Vetter wrote: > On Mon, Oct 20, 2014 at 06:20:06PM +0530, Vandana Kannan wrote: > > Actually set values into PPS related registers. This implementation is > > equivalent to intel_dp_panel_power_sequencer_registers where the values > > saved intially

Re: [Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-20 Thread Daniel Vetter
On Mon, Oct 20, 2014 at 06:08:48PM +0200, Daniel Vetter wrote: > On Mon, Oct 20, 2014 at 06:20:06PM +0530, Vandana Kannan wrote: > > Actually set values into PPS related registers. This implementation is > > equivalent to intel_dp_panel_power_sequencer_registers where the values > > saved intially

Re: [Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-20 Thread Daniel Vetter
On Mon, Oct 20, 2014 at 06:20:06PM +0530, Vandana Kannan wrote: > Actually set values into PPS related registers. This implementation is > equivalent to intel_dp_panel_power_sequencer_registers where the values > saved intially are written into registers. > > Signed-off-by: Vandana Kannan > --- >

[Intel-gfx] [RFC 4/7] drm/i915: Program PPS registers

2014-10-20 Thread Vandana Kannan
Actually set values into PPS related registers. This implementation is equivalent to intel_dp_panel_power_sequencer_registers where the values saved intially are written into registers. Signed-off-by: Vandana Kannan --- drivers/gpu/drm/i915/intel_dp.c| 80 ++--