Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-21 Thread Jani Nikula
On Mon, 21 Oct 2019, Jani Nikula wrote: > On Mon, 21 Oct 2019, Jani Nikula wrote: >> On Fri, 18 Oct 2019, Janusz Krzysztofik >> wrote: >>> Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") >> >> Please look at that commit and explain to me how it impacts anything >> about

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-21 Thread Jani Nikula
On Mon, 21 Oct 2019, Jani Nikula wrote: > On Fri, 18 Oct 2019, Janusz Krzysztofik > wrote: >> Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") > > Please look at that commit and explain to me how it impacts anything > about intel_irq_uninstall(). Seriously, why was this

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-21 Thread Jani Nikula
On Fri, 18 Oct 2019, Janusz Krzysztofik wrote: > Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") Please look at that commit and explain to me how it impacts anything about intel_irq_uninstall(). BR, Jani. > claimed removal of asymmetry in probe() and remove() calls,

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-10-18 16:52:26) > On Fri, 18 Oct 2019 12:07:10 +0200, Janusz Krzysztofik > wrote: > > > Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") > > claimed removal of asymmetry in probe() and remove() calls, however, it > > didn't take care of calling

Re: [Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Michal Wajdeczko
On Fri, 18 Oct 2019 12:07:10 +0200, Janusz Krzysztofik wrote: Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") claimed removal of asymmetry in probe() and remove() calls, however, it didn't take care of calling intel_irq_uninstall() on driver remove. That doesn't hurt as

[Intel-gfx] [RFC PATCH] drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

2019-10-18 Thread Janusz Krzysztofik
Commit 2d6f6f359fd8 ("drm/i915: add i915_driver_modeset_remove()") claimed removal of asymmetry in probe() and remove() calls, however, it didn't take care of calling intel_irq_uninstall() on driver remove. That doesn't hurt as long as we still call it from intel_modeset_driver_remove() but in