Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-12 Thread Jesse Barnes
On Jan 12, 2017 8:04 AM, "Chris Wilson" wrote: On Thu, Jan 12, 2017 at 05:48:49PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: > >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) > >> +{ > >> + int

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 05:48:49PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: > >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) > >> +{ > >> + int ret; > >> + > >> + if (!HAS_SVM(ctx->i915)) >

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-12 Thread Mika Kuoppala
Chris Wilson writes: > On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: >> +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) >> +{ >> +int ret; >> + >> +if (!HAS_SVM(ctx->i915)) >> +return -ENODEV; > > How does legacy execbuf work with an svm

Re: [Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-09 Thread Chris Wilson
On Mon, Jan 09, 2017 at 06:52:53PM +0200, Mika Kuoppala wrote: > +static int i915_gem_context_enable_svm(struct i915_gem_context *ctx) > +{ > + int ret; > + > + if (!HAS_SVM(ctx->i915)) > + return -ENODEV; How does legacy execbuf work with an svm context? It will write the ppgt

[Intel-gfx] [RFC PATCH 2/3] drm/i915: IOMMU based SVM implementation v16

2017-01-09 Thread Mika Kuoppala
From: Jesse Barnes Use David's new IOMMU layer functions for supporting SVM in i915. TODO: error record collection for failing SVM contexts callback handling for fatal faults scheduling v2: integrate David's core IOMMU support make sure we don't clobber the PASID in the context reg st