Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-11-04 Thread Janusz Krzysztofik
Hi Vanshi, On Thursday, October 31, 2019 5:58:31 PM CET Vanshidhar Konda wrote: > On Thu, Oct 31, 2019 at 04:28:55PM +0100, Janusz Krzysztofik wrote: > >Some tests assume 4kB offset alignment while using softpin. That > >assumption may be wrong on future GEM backends with possibly larger >

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-11-04 Thread Janusz Krzysztofik
On Monday, November 4, 2019 10:28:37 AM CET Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-11-04 09:23:12) > > Hi Chris, > > > > On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote: > > > Quoting Janusz Krzysztofik (2019-10-31 15:28:55) > > > > Some tests assume 4kB offset

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-11-04 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-11-04 09:23:12) > Hi Chris, > > On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote: > > Quoting Janusz Krzysztofik (2019-10-31 15:28:55) > > > Some tests assume 4kB offset alignment while using softpin. That > > > assumption may be wrong on future GEM

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-11-04 Thread Janusz Krzysztofik
Hi Chris, On Friday, November 1, 2019 11:08:45 AM CET Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-10-31 15:28:55) > > Some tests assume 4kB offset alignment while using softpin. That > > assumption may be wrong on future GEM backends with possibly larger > > minimum page sizes. As a

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-11-01 Thread Chris Wilson
Quoting Janusz Krzysztofik (2019-10-31 15:28:55) > Some tests assume 4kB offset alignment while using softpin. That > assumption may be wrong on future GEM backends with possibly larger > minimum page sizes. As a result, those tests may either fail on > softpin at offsets which are incorrectly

Re: [Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-10-31 Thread Vanshidhar Konda
On Thu, Oct 31, 2019 at 04:28:55PM +0100, Janusz Krzysztofik wrote: Some tests assume 4kB offset alignment while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are

[Intel-gfx] [RFC PATCH i-g-t v4 2/4] lib: Add minimum GTT alignment helper

2019-10-31 Thread Janusz Krzysztofik
Some tests assume 4kB offset alignment while using softpin. That assumption may be wrong on future GEM backends with possibly larger minimum page sizes. As a result, those tests may either fail on softpin at offsets which are incorrectly aligned, may silently skip such incorrectly aligned