Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-06-15 Thread Tvrtko Ursulin
On 25/05/2017 15:14, Chris Wilson wrote: On Wed, May 24, 2017 at 12:28:07PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 18:00, Chris Wilson wrote: On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 14:37, Chris Wilson wrote: On Thu, May 18, 2017 at 02:06:35PM +010

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-25 Thread Chris Wilson
On Wed, May 24, 2017 at 12:28:07PM +0100, Tvrtko Ursulin wrote: > > On 18/05/2017 18:00, Chris Wilson wrote: > >On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: > >> > >>On 18/05/2017 14:37, Chris Wilson wrote: > >>>On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: > >

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-24 Thread Tvrtko Ursulin
On 18/05/2017 18:00, Chris Wilson wrote: On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 14:37, Chris Wilson wrote: On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: But this problem in general can also be solved separately from class-instance add

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Chris Wilson
On Thu, May 18, 2017 at 05:20:38PM +0100, Tvrtko Ursulin wrote: > > On 18/05/2017 14:37, Chris Wilson wrote: > >On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: > >> > >>But this problem in general can also be solved separately from > >>class-instance addressing via engine feature m

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Tvrtko Ursulin
On 18/05/2017 14:37, Chris Wilson wrote: On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 13:24, Chris Wilson wrote: Yes, I would argue to defer it until later. One problem I have at the moment is that not all members of a class are equal, HEVC-capable engines and

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Tvrtko Ursulin
On 18/05/2017 15:10, Emil Velikov wrote: Hi Tvrtko, On 18 May 2017 at 14:06, Tvrtko Ursulin wrote: struct drm_i915_engine_info { /** Engine instance number. */ __u32 instance; __u32 rsvd; /** Engine specific features and info. */ #define DRM_I915_ENGINE_H

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Emil Velikov
Hi Tvrtko, On 18 May 2017 at 14:06, Tvrtko Ursulin wrote: > struct drm_i915_engine_info { > /** Engine instance number. */ > __u32 instance; > __u32 rsvd; > > /** Engine specific features and info. */ > #define DRM_I915_ENGINE_HAS_HEVCBIT(0) >

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Chris Wilson
On Thu, May 18, 2017 at 02:30:56PM +0100, Tvrtko Ursulin wrote: > > On 17/05/2017 17:44, Chris Wilson wrote: > >On Wed, May 17, 2017 at 04:40:57PM +0100, Tvrtko Ursulin wrote: > >>+static struct intel_engine_cs *get_engine_class(struct drm_i915_private > >>*i915, > >>+

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Chris Wilson
On Thu, May 18, 2017 at 02:06:35PM +0100, Tvrtko Ursulin wrote: > > On 18/05/2017 13:24, Chris Wilson wrote: > >Yes, I would argue to defer it until later. One problem I have at the > >moment is that not all members of a class are equal, HEVC-capable > >engines and the reset do not belong to the s

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Tvrtko Ursulin
On 17/05/2017 17:44, Chris Wilson wrote: On Wed, May 17, 2017 at 04:40:57PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Building on top of the previous patch which exported the concept of engine classes and instances, we can also use this instead of the current awkward engine selection

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Tvrtko Ursulin
On 18/05/2017 13:24, Chris Wilson wrote: On Thu, May 18, 2017 at 01:13:20PM +0100, Tvrtko Ursulin wrote: On 18/05/2017 12:10, Chris Wilson wrote: On Thu, May 18, 2017 at 01:55:59PM +0300, Joonas Lahtinen wrote: On ke, 2017-05-17 at 16:40 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin B

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Chris Wilson
On Thu, May 18, 2017 at 01:13:20PM +0100, Tvrtko Ursulin wrote: > > On 18/05/2017 12:10, Chris Wilson wrote: > >On Thu, May 18, 2017 at 01:55:59PM +0300, Joonas Lahtinen wrote: > >>On ke, 2017-05-17 at 16:40 +0100, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>Building on top of the

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Tvrtko Ursulin
On 18/05/2017 12:10, Chris Wilson wrote: On Thu, May 18, 2017 at 01:55:59PM +0300, Joonas Lahtinen wrote: On ke, 2017-05-17 at 16:40 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Building on top of the previous patch which exported the concept of engine classes and instances, we can also

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Chris Wilson
On Thu, May 18, 2017 at 01:55:59PM +0300, Joonas Lahtinen wrote: > On ke, 2017-05-17 at 16:40 +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Building on top of the previous patch which exported the concept > > of engine classes and instances, we can also use this instead of > > the

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-18 Thread Joonas Lahtinen
On ke, 2017-05-17 at 16:40 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Building on top of the previous patch which exported the concept > of engine classes and instances, we can also use this instead of > the current awkward engine selection uAPI. > > This is primarily interesting fo

Re: [Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-17 Thread Chris Wilson
On Wed, May 17, 2017 at 04:40:57PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Building on top of the previous patch which exported the concept > of engine classes and instances, we can also use this instead of > the current awkward engine selection uAPI. > > This is primarily intere

[Intel-gfx] [RFC v3] drm/i915: Select engines via class and instance in execbuffer2

2017-05-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Building on top of the previous patch which exported the concept of engine classes and instances, we can also use this instead of the current awkward engine selection uAPI. This is primarily interesting for the VCS engine selection which is a) currently done via disjoint set