Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

On 07/12, Ser, Simon wrote: > On Thu, 2019-07-11 at 23:49 -0300, Rodrigo Siqueira wrote: > > On 07/10, Ser, Simon wrote: > > > On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > > > > Mostly LGTM, here are a few nits. > > > > > > > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > >

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

On Thu, 2019-07-11 at 23:49 -0300, Rodrigo Siqueira wrote: > On 07/10, Ser, Simon wrote: > > On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > > > Mostly LGTM, here are a few nits. > > > > > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > > > > To use writeback buffers as a CRC so

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

On 07/10, Ser, Simon wrote: > On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > > Mostly LGTM, here are a few nits. > > > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > > > To use writeback buffers as a CRC source, we need to be able to hash > > > them. Implement a simple FVA-1a

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

On Wed, 2019-07-10 at 15:30 +, Ser, Simon wrote: > Mostly LGTM, here are a few nits. > > On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > > To use writeback buffers as a CRC source, we need to be able to hash > > them. Implement a simple FVA-1a hashing routine for this purpose. > > >

Re: [Intel-gfx] [igt-dev] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

Mostly LGTM, here are a few nits. On Wed, 2019-06-12 at 23:17 -0300, Brian Starkey wrote: > To use writeback buffers as a CRC source, we need to be able to hash > them. Implement a simple FVA-1a hashing routine for this purpose. > > Doing a bytewise hash on the framebuffer directly can be very sl