[Intel-gfx] [patch] drm/i915: memory leak in __i915_gem_vma_create()

2015-03-18 Thread Dan Carpenter
In the original code then if WARN_ON(i915_is_ggtt(vm) != !!ggtt_view) was true then we leak vma. Presumably that doesn't happen often but static checkers complain and this bug is easy to fix. Fixes: c3bbb6f2825d ('drm/i915: Do not use ggtt_view with (aliasing) PPGTT') Signed-off-by: Dan

Re: [Intel-gfx] [patch] drm/i915: memory leak in __i915_gem_vma_create()

2015-03-18 Thread Jani Nikula
On Wed, 18 Mar 2015, Dan Carpenter dan.carpen...@oracle.com wrote: In the original code then if WARN_ON(i915_is_ggtt(vm) != !!ggtt_view) was true then we leak vma. Presumably that doesn't happen often but static checkers complain and this bug is easy to fix. Fixes: c3bbb6f2825d ('drm/i915:

Re: [Intel-gfx] [patch] drm/i915: memory leak in __i915_gem_vma_create()

2015-03-18 Thread Daniel Vetter
On Wed, Mar 18, 2015 at 10:36:45AM +0200, Jani Nikula wrote: On Wed, 18 Mar 2015, Dan Carpenter dan.carpen...@oracle.com wrote: In the original code then if WARN_ON(i915_is_ggtt(vm) != !!ggtt_view) was true then we leak vma. Presumably that doesn't happen often but static checkers complain

Re: [Intel-gfx] [patch] drm/i915: memory leak in __i915_gem_vma_create()

2015-03-18 Thread Joonas Lahtinen
On ke, 2015-03-18 at 09:41 +0100, Daniel Vetter wrote: On Wed, Mar 18, 2015 at 10:36:45AM +0200, Jani Nikula wrote: On Wed, 18 Mar 2015, Dan Carpenter dan.carpen...@oracle.com wrote: In the original code then if WARN_ON(i915_is_ggtt(vm) != !!ggtt_view) was true then we leak vma.