Re: [Intel-gfx] [v4 3/4] drm/i915/icl: Enable ICL Pipe CSC block

2018-12-27 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Friday, December 21, 2018 11:02 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst, Maarten >Subject: Re: [Intel-gfx] [v4 3/4] drm/i915/icl

Re: [Intel-gfx] [v4 3/4] drm/i915/icl: Enable ICL Pipe CSC block

2018-12-21 Thread Ville Syrjälä
On Fri, Dec 21, 2018 at 01:29:40AM +0530, Uma Shankar wrote: > Enable ICL pipe csc hardware. CSC block is enabled > in CSC_MODE register instead of PLANE_COLOR_CTL. > > ToDO: Extend the ABI to accept 32 bit coefficient values > instead of 16bit for future platforms. > > v2: Addressed Maarten's re

[Intel-gfx] [v4 3/4] drm/i915/icl: Enable ICL Pipe CSC block

2018-12-20 Thread Uma Shankar
Enable ICL pipe csc hardware. CSC block is enabled in CSC_MODE register instead of PLANE_COLOR_CTL. ToDO: Extend the ABI to accept 32 bit coefficient values instead of 16bit for future platforms. v2: Addressed Maarten's review comments. v3: Addressed Matt's review comments. Removed rmw patterns