Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-06-12 Thread Sharma, Swati2
On 05-Jun-19 3:37 PM, Jani Nikula wrote: On Wed, 29 May 2019, Swati Sharma wrote: v3: -Rebase v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] -Added the default label above the correct label [Jani] -Corrected smatch warn "variable dereferenced before check"

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-06-10 Thread Ville Syrjälä
On Mon, Jun 10, 2019 at 04:24:54PM +0530, Sharma, Swati2 wrote: > On 31-May-19 8:58 PM, Ville Syrjälä wrote: > > > On Wed, May 29, 2019 at 03:20:53PM +0530, Swati Sharma wrote: > >> v3: -Rebase > >> v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > >> -Added the defau

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-06-10 Thread Sharma, Swati2
On 31-May-19 8:58 PM, Ville Syrjälä wrote: On Wed, May 29, 2019 at 03:20:53PM +0530, Swati Sharma wrote: v3: -Rebase v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] -Added the default label above the correct label [Jani] -Corrected smatch warn "variable derefe

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-06-05 Thread Jani Nikula
On Wed, 29 May 2019, Swati Sharma wrote: > v3: -Rebase > v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > -Added the default label above the correct label [Jani] > -Corrected smatch warn "variable dereferenced before check" > [Dan Carpenter] > v5: -Added cond

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-05-31 Thread Ville Syrjälä
On Wed, May 29, 2019 at 03:20:53PM +0530, Swati Sharma wrote: > v3: -Rebase > v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > -Added the default label above the correct label [Jani] > -Corrected smatch warn "variable dereferenced before check" > [Dan Carpente

[Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-05-29 Thread Swati Sharma
v3: -Rebase v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] -Added the default label above the correct label [Jani] -Corrected smatch warn "variable dereferenced before check" [Dan Carpenter] v5: -Added condition (!blob1 && !blob2) return true [Jani] -Calle