Re: [Intel-gfx] Polymorphic to_i915()

2016-04-20 Thread Mika Kuoppala
Daniel Vetter writes: > [ text/plain ] > On Mon, Apr 18, 2016 at 12:18:23PM +0300, Jani Nikula wrote: >> On Fri, 15 Apr 2016, Chris Wilson wrote: >> > Final canvas for opinions for using a magic macro to reduce typing in >> > the common operation of getting our drm_i915_private from the object.

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-20 Thread Dave Gordon
On 20/04/16 13:57, Daniel Vetter wrote: On Mon, Apr 18, 2016 at 12:18:23PM +0300, Jani Nikula wrote: On Fri, 15 Apr 2016, Chris Wilson wrote: Final canvas for opinions for using a magic macro to reduce typing in the common operation of getting our drm_i915_private from the object. 21

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-20 Thread Daniel Vetter
On Mon, Apr 18, 2016 at 12:18:23PM +0300, Jani Nikula wrote: > On Fri, 15 Apr 2016, Chris Wilson wrote: > > Final canvas for opinions for using a magic macro to reduce typing in > > the common operation of getting our drm_i915_private from the object. > > > > 21 files changed, 333 insertions(+

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-18 Thread Chris Wilson
On Mon, Apr 18, 2016 at 02:49:26PM +0300, Jani Nikula wrote: > On Mon, 18 Apr 2016, Dave Gordon wrote: > > The GuC changes are OK, and we might as well convert "dev_priv" to > > "i915" at the same time, if that's now the preferred name. > > Hmph, I see that "struct drm_i915_private *i915" is alr

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-18 Thread Jani Nikula
On Mon, 18 Apr 2016, Dave Gordon wrote: > The GuC changes are OK, and we might as well convert "dev_priv" to > "i915" at the same time, if that's now the preferred name. Hmph, I see that "struct drm_i915_private *i915" is already being used in a few places. This is more than a little confusing s

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-18 Thread Dave Gordon
On 18/04/16 10:18, Jani Nikula wrote: On Fri, 15 Apr 2016, Chris Wilson wrote: Final canvas for opinions for using a magic macro to reduce typing in the common operation of getting our drm_i915_private from the object. 21 files changed, 333 insertions(+), 392 deletions(-) Not to menti

Re: [Intel-gfx] Polymorphic to_i915()

2016-04-18 Thread Jani Nikula
On Fri, 15 Apr 2016, Chris Wilson wrote: > Final canvas for opinions for using a magic macro to reduce typing in > the common operation of getting our drm_i915_private from the object. > > 21 files changed, 333 insertions(+), 392 deletions(-) > > Not to mention the ease it makes for later pa

[Intel-gfx] Polymorphic to_i915()

2016-04-15 Thread Chris Wilson
Final canvas for opinions for using a magic macro to reduce typing in the common operation of getting our drm_i915_private from the object. 21 files changed, 333 insertions(+), 392 deletions(-) Not to mention the ease it makes for later patches to reduce the pointer dance. -Chris __