Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-10 Thread Carlos Santa
On Mon, 2019-01-07 at 12:50 +, Tvrtko Ursulin wrote: > On 05/01/2019 02:40, Carlos Santa wrote: > > From: Michel Thierry > > > > On command streams that could potentially hang the GPU after a last > > flush command, it's best not to cancel the watchdog > > until after all commands have

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:54, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 12:50:24) On 05/01/2019 02:40, Carlos Santa wrote: +static void gen8_emit_breadcrumb_vcs(struct i915_request *request, u32 *cs) +{ + /* w/a: bit 5 needs to be zero for MI_FLUSH_DW address. */ +

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:50:24) > > On 05/01/2019 02:40, Carlos Santa wrote: > > +static void gen8_emit_breadcrumb_vcs(struct i915_request *request, u32 *cs) > > +{ > > + /* w/a: bit 5 needs to be zero for MI_FLUSH_DW address. */ > > + BUILD_BUG_ON(I915_GEM_HWS_INDEX_ADDR &

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Tvrtko Ursulin
On 05/01/2019 02:40, Carlos Santa wrote: From: Michel Thierry On command streams that could potentially hang the GPU after a last flush command, it's best not to cancel the watchdog until after all commands have executed. Patch shared by Michel Thierry through IIRC after reproduction on

[Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-04 Thread Carlos Santa
From: Michel Thierry On command streams that could potentially hang the GPU after a last flush command, it's best not to cancel the watchdog until after all commands have executed. Patch shared by Michel Thierry through IIRC after reproduction on my local setup. Tested-by: Carlos Santa CC: