Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-23 Thread Carlos Santa
On Mon, 2019-01-07 at 11:58 +, Tvrtko Ursulin wrote: [snip] > > > > > > static void gen8_gt_irq_ack(struct drm_i915_private *i915, > > @@ -3329,7 +3332,7 @@ void i915_handle_error(struct > > drm_i915_private *dev_priv, > > if (intel_has_reset_engine(dev_priv) && > > !i915_te

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-16 Thread Antonio Argenziano
On 16/01/19 09:42, Antonio Argenziano wrote: On 16/01/19 08:15, Tvrtko Ursulin wrote: On 11/01/2019 21:28, John Harrison wrote: On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvr

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-16 Thread Antonio Argenziano
On 16/01/19 08:15, Tvrtko Ursulin wrote: On 11/01/2019 21:28, John Harrison wrote: On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris W

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-16 Thread Tvrtko Ursulin
On 11/01/2019 21:28, John Harrison wrote: On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-0

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-11 Thread John Harrison
On 1/11/2019 09:31, Antonio Argenziano wrote: On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-11 Thread Antonio Argenziano
On 11/01/19 00:22, Tvrtko Ursulin wrote: On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future inte

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-11 Thread Tvrtko Ursulin
On 11/01/2019 00:47, Antonio Argenziano wrote: On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could h

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-10 Thread Carlos Santa
On Mon, 2019-01-07 at 16:58 +, Tvrtko Ursulin wrote: > On 07/01/2019 13:57, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-01-07 13:43:29) > > > > > > On 07/01/2019 11:58, Tvrtko Ursulin wrote: > > > > > > [snip] > > > > > > > > Note about future interaction with preemption: Preemption

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-10 Thread Antonio Argenziano
On 07/01/19 08:58, Tvrtko Ursulin wrote: On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 16:58:24) > And finally there is one programming restriction which says: > > * SW must not preempt the workload which has watchdog enabled. Either > it must: > > a) disable preemption for that workload completely, or > b) disable the watchdog via mmio write b

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog counter getting disabled, resulting in watch

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 13:43:29) > > On 07/01/2019 11:58, Tvrtko Ursulin wrote: > > [snip] > > >> Note about future interaction with preemption: Preemption could happen > >> in a command sequence prior to watchdog counter getting disabled, > >> resulting in watchdog being triggered f

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog counter getting disabled, resulting in watchdog being triggered following preemption (e.g. when watchdog had been enabled in the low

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 13:02, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 12:58:39) On 07/01/2019 12:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 11:58:13) On 05/01/2019 02:39, Carlos Santa wrote: +static void gen8_watchdog_irq_handler(unsigned long data) +{ + struct int

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:58:39) > > On 07/01/2019 12:16, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-01-07 11:58:13) > >> On 05/01/2019 02:39, Carlos Santa wrote: > >>> +static void gen8_watchdog_irq_handler(unsigned long data) > >>> +{ > >>> + struct intel_engine_cs *eng

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 11:58:13) Hi, This series has not been recognized by Patchwork as such, nor are the patches numbered. Have you used git format-patch - --cover-letter and git send-email to send it out? Rest inline. On 05/01/2019 02:

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 11:58:13) > > Hi, > > This series has not been recognized by Patchwork as such, nor are the > patches numbered. Have you used git format-patch - --cover-letter and > git send-email to send it out? > > Rest inline. > > On 05/01/2019 02:39, Carlos Santa wrote:

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
Hi, This series has not been recognized by Patchwork as such, nor are the patches numbered. Have you used git format-patch - --cover-letter and git send-email to send it out? Rest inline. On 05/01/2019 02:39, Carlos Santa wrote: From: Michel Thierry *** General *** Watchdog timeout (or

[Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-04 Thread Carlos Santa
From: Michel Thierry *** General *** Watchdog timeout (or "media engine reset") is a feature that allows userland applications to enable hang detection on individual batch buffers. The detection mechanism itself is mostly bound to the hardware and the only thing that the driver needs to do to su