Re: [Intel-gfx] mmu_notifier and i915_gem_userptr.c

2014-06-25 Thread Joerg Roedel
On Fri, Jun 20, 2014 at 01:43:50PM +0200, Joerg Roedel wrote: > Change_pte is also called when the underlying page of an address > changes in the kernel which would matter for DMA. But that can only > happen in KSM and uprobes code which is probably not of interest for the > i915 driver. > > The o

Re: [Intel-gfx] mmu_notifier and i915_gem_userptr.c

2014-06-20 Thread Joerg Roedel
On Thu, Jun 19, 2014 at 05:02:57PM +0100, Chris Wilson wrote: > Maybe it should hook the invalidate_page notifier. I picked > invalidate_range() as it seemed to be called first and seemed to cover > all operations that affected an mm's addr range. The invalidate_page > seemed to be only called dur

[Intel-gfx] mmu_notifier and i915_gem_userptr.c

2014-06-19 Thread Joerg Roedel
Hey Chris, recently I had a look at i915_gem_userptr.c in order to extend the mmu_notifier call-backs implemented there. My goal is to implement the change_pte call-back where it is necessary to get rid of it being wrapped mn_invalidate_range_start/end() calls (for the reason see commit 6bdb913f).

Re: [Intel-gfx] mmu_notifier and i915_gem_userptr.c

2014-06-19 Thread Chris Wilson
On Thu, Jun 19, 2014 at 05:36:55PM +0200, Joerg Roedel wrote: > Hey Chris, > > recently I had a look at i915_gem_userptr.c in order to extend the > mmu_notifier call-backs implemented there. My goal is to implement the > change_pte call-back where it is necessary to get rid of it being > wrapped m