Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-08 Thread Ville Syrjälä
On Wed, Feb 07, 2024 at 11:02:27PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:48:53PM +0200, Imre Deak wrote: > > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > > > [...] > > > > +static int > > > > +drm_dp_tunnel_atomic_check_group_bw(struct drm_dp_tunnel_group_state

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-07 Thread Imre Deak
On Wed, Feb 07, 2024 at 10:48:43PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > > + [...] > > > +static int group_allocated_bw(struct drm_dp_tunnel_group *group) > > > +{ > > > + struct dr

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-07 Thread Imre Deak
On Wed, Feb 07, 2024 at 10:48:53PM +0200, Imre Deak wrote: > On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > > > [...] > > > +static int > > > +drm_dp_tunnel_atomic_check_group_bw(struct drm_dp_tunnel_group_state > > > *new_group_state, > > > + u32 *fai

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-07 Thread Imre Deak
On Wed, Feb 07, 2024 at 10:02:18PM +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > +static char yes_no_chr(int val) > > +{ > > + return val ? 'Y' : 'N'; > > +} > > We have str_yes_no() already. Ok, will use this. > v> + > > +#define SKIP_DPRX_CAPS_C

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-07 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > +static char yes_no_chr(int val) > +{ > + return val ? 'Y' : 'N'; > +} We have str_yes_no() already. v> + > +#define SKIP_DPRX_CAPS_CHECK BIT(0) > +#define ALLOW_ALLOCATED_BW_CHANGEBIT(1) > + > +static bool tunnel_regs_a

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-05 Thread Ville Syrjälä
On Mon, Feb 05, 2024 at 07:15:17PM +0200, Imre Deak wrote: > On Mon, Feb 05, 2024 at 06:13:30PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 31, 2024 at 08:49:16PM +0200, Imre Deak wrote: > > > On Wed, Jan 31, 2024 at 06:09:04PM +0200, Ville Syrjälä wrote: > > > > On Tue, Jan 23, 2024 at 12:28:33PM

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-05 Thread Imre Deak
On Mon, Feb 05, 2024 at 06:13:30PM +0200, Ville Syrjälä wrote: > On Wed, Jan 31, 2024 at 08:49:16PM +0200, Imre Deak wrote: > > On Wed, Jan 31, 2024 at 06:09:04PM +0200, Ville Syrjälä wrote: > > > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > > > +static void untrack_tunnel_ref(str

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-02-05 Thread Ville Syrjälä
On Wed, Jan 31, 2024 at 08:49:16PM +0200, Imre Deak wrote: > On Wed, Jan 31, 2024 at 06:09:04PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > > +static void untrack_tunnel_ref(struct drm_dp_tunnel *tunnel, > > > +struct ref_tr

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 06:09:04PM +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > Add support for Display Port DP tunneling. For now this includes the > > support for Bandwidth Allocation Mode, leaving adding Panel Replay > > support for later. > > > >

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > th

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 02:50:16PM +0200, Hogander, Jouni wrote: > [...] > > + > > +struct drm_dp_tunnel_group; > > + > > +struct drm_dp_tunnel { > > + struct drm_dp_tunnel_group *group; > > + > > + struct list_head node; > > + > > + struct kref kref; > > +#ifdef CONFIG_DRM_DISPLA

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > their max

[PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-23 Thread Imre Deak
Add support for Display Port DP tunneling. For now this includes the support for Bandwidth Allocation Mode, leaving adding Panel Replay support for later. BWA allows using displays that share the same (Thunderbolt) link with their maximum resolution. Atm, this may not be possible due to the coarse