Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-27 Thread Andi Shyti
Hi Jani, thanks, there has been a v2 after this and your comments have been addressed somehow. There will be a v3, as well. Thanks, Andi On Tue, Feb 27, 2024 at 02:18:01PM +0200, Jani Nikula wrote: > On Tue, 20 Feb 2024, Andi Shyti wrote: > > Since CCS automatic load balancing is disabled, we

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-27 Thread Jani Nikula
On Tue, 20 Feb 2024, Andi Shyti wrote: > Since CCS automatic load balancing is disabled, we will impose a > fixed balancing policy that involves setting all the CCS engines > to work together on the same load. > > Simultaneously, the user will see only 1 CCS rather than the > actual number. As of

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Andi Shyti
On Tue, Feb 20, 2024 at 02:27:07PM +, Tvrtko Ursulin wrote: > > On 20/02/2024 14:20, Andi Shyti wrote: > > Since CCS automatic load balancing is disabled, we will impose a > > fixed balancing policy that involves setting all the CCS engines > > to work together on the same load. > > Erm *all*

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Tvrtko Ursulin
On 20/02/2024 14:20, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Erm *all* CSS engines work together.. Simultaneously, the user will see only 1 CCS rath

[PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Andi Shyti
Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, this change affects only DG2. Fixes: d2eae8e9

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Andi Shyti
On Tue, Feb 20, 2024 at 11:15:05AM +, Tvrtko Ursulin wrote: > On 20/02/2024 10:11, Andi Shyti wrote: > > On Mon, Feb 19, 2024 at 12:51:44PM +, Tvrtko Ursulin wrote: > > > On 19/02/2024 11:16, Tvrtko Ursulin wrote: > > > > On 15/02/2024 13:59, Andi Shyti wrote: > > > > ... > > > > > > > +/

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Tvrtko Ursulin
On 20/02/2024 10:11, Andi Shyti wrote: Hi Tvrtko, On Mon, Feb 19, 2024 at 12:51:44PM +, Tvrtko Ursulin wrote: On 19/02/2024 11:16, Tvrtko Ursulin wrote: On 15/02/2024 13:59, Andi Shyti wrote: ... +/* + * Exclude unavailable engines. + * + * Only the first CCS engine is utilized due t

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-20 Thread Andi Shyti
Hi Tvrtko, On Mon, Feb 19, 2024 at 12:51:44PM +, Tvrtko Ursulin wrote: > On 19/02/2024 11:16, Tvrtko Ursulin wrote: > > On 15/02/2024 13:59, Andi Shyti wrote: ... > > > +/* > > > + * Exclude unavailable engines. > > > + * > > > + * Only the first CCS engine is utilized due to the disabling o

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-19 Thread Tvrtko Ursulin
On 19/02/2024 11:16, Tvrtko Ursulin wrote: On 15/02/2024 13:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-19 Thread Tvrtko Ursulin
On 15/02/2024 13:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, thi

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread John Harrison
On 2/15/2024 14:34, Andi Shyti wrote: Hi John, On Thu, Feb 15, 2024 at 01:23:24PM -0800, John Harrison wrote: On 2/15/2024 05:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread Andi Shyti
Hi John, On Thu, Feb 15, 2024 at 01:23:24PM -0800, John Harrison wrote: > On 2/15/2024 05:59, Andi Shyti wrote: > > Since CCS automatic load balancing is disabled, we will impose a > > fixed balancing policy that involves setting all the CCS engines > > to work together on the same load. > > > >

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread John Harrison
On 2/15/2024 05:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, this c

[PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

2024-02-15 Thread Andi Shyti
Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now, this change affects only DG2. Fixes: d2eae8e9