Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-04 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 06:47:54PM +0200, Ville Syrjälä wrote: > On Fri, Mar 01, 2024 at 06:22:19PM +0200, Lisovskiy, Stanislav wrote: > > On Fri, Mar 01, 2024 at 06:10:25PM +0200, Ville Syrjälä wrote: > > > On Fri, Mar 01, 2024 at 06:04:27PM +0200, Lisovskiy, Stanislav wrote: > > > > On Fri, Mar 0

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Ville Syrjälä
On Fri, Mar 01, 2024 at 06:22:19PM +0200, Lisovskiy, Stanislav wrote: > On Fri, Mar 01, 2024 at 06:10:25PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 01, 2024 at 06:04:27PM +0200, Lisovskiy, Stanislav wrote: > > > On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > > > > From: Ville S

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 06:10:25PM +0200, Ville Syrjälä wrote: > On Fri, Mar 01, 2024 at 06:04:27PM +0200, Lisovskiy, Stanislav wrote: > > On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Reorganize the crtc disable path to only deal with the >

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Ville Syrjälä
On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > /* >* We need to disable pipe CRC before disabling the pipe, >* or we race against vblank off. >*/ > - intel_crtc_disable_pipe_crc(crtc); > + for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc,

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Ville Syrjälä
On Fri, Mar 01, 2024 at 06:04:27PM +0200, Lisovskiy, Stanislav wrote: > On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Reorganize the crtc disable path to only deal with the > > master pipes/transcoders in intel_old_crtc_state_disables() > > and off

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Reorganize the crtc disable path to only deal with the > master pipes/transcoders in intel_old_crtc_state_disables() > and offload the handling of joined pipes to hsw_crtc_disable(). > This makes the whole th

Re: [PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Lisovskiy, Stanislav
On Fri, Mar 01, 2024 at 04:36:00PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Reorganize the crtc disable path to only deal with the > master pipes/transcoders in intel_old_crtc_state_disables() > and offload the handling of joined pipes to hsw_crtc_disable(). > This makes the whole th

[PATCH 8/8] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-01 Thread Ville Syrjala
From: Ville Syrjälä Reorganize the crtc disable path to only deal with the master pipes/transcoders in intel_old_crtc_state_disables() and offload the handling of joined pipes to hsw_crtc_disable(). This makes the whole thing much more sensible since we can actually control the order in which we