RE: [PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64

2024-06-24 Thread Kandpal, Suraj
> -Original Message- > From: Golani, Mitulkumar Ajitkumar > > Sent: Friday, June 21, 2024 1:05 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Vivi, Rodrigo ; > jani.nik...@linux.intel.com; Kandpal, Suraj ; > Nautiyal, Ankit K ; nat...@kernel.org >

Re: [PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64

2024-06-24 Thread Jani Nikula
On Fri, 21 Jun 2024, Mitul Golani wrote: > Consider adjusted_pixel_rate to be a u64 to match the return > type of mul_u32_u32() and avoid any compiler dependency for > do_div. You should mention this fixes 32-bit builds. Might also want to give a link to the actual build failure, and give credit

Re: [PATCH] drm/i915/display: Consider adjusted_pixel_rate to be u64

2024-06-21 Thread Rodrigo Vivi
On Fri, Jun 21, 2024 at 01:04:54PM +0530, Mitul Golani wrote: > Consider adjusted_pixel_rate to be a u64 to match the return > type of mul_u32_u32() and avoid any compiler dependency for > do_div. Reviewed-by: Rodrigo Vivi > > Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal")