Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-12-01 Thread Ville Syrjälä
On Mon, Nov 30, 2020 at 09:46:18PM -0800, Lucas De Marchi wrote: > On Mon, Nov 30, 2020 at 07:46:39PM +0200, Ville Syrjälä wrote: > >On Mon, Nov 30, 2020 at 09:31:04AM -0800, Lucas De Marchi wrote: > >> On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: > >> >On Fri, Nov 27, 2020 at 08:

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Lucas De Marchi
On Mon, Nov 30, 2020 at 07:46:39PM +0200, Ville Syrjälä wrote: On Mon, Nov 30, 2020 at 09:31:04AM -0800, Lucas De Marchi wrote: On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: >On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: >> On Fri, Nov 27, 2020 at 02:57:48PM +

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Ville Syrjälä
On Mon, Nov 30, 2020 at 09:31:04AM -0800, Lucas De Marchi wrote: > On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: > >On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: > >> On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: > >> >We now use ilk_hpd_irq_setup

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Lucas De Marchi
On Mon, Nov 30, 2020 at 04:19:54PM +0200, Ville Syrjälä wrote: On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: >We now use ilk_hpd_irq_setup for all GMCH platforms that do not have >hotplug. These are early gen3 and g

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-30 Thread Ville Syrjälä
On Fri, Nov 27, 2020 at 08:52:29PM -0800, Lucas De Marchi wrote: > On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: > >We now use ilk_hpd_irq_setup for all GMCH platforms that do not have > >hotplug. These are early gen3 and gen2 devices that now explode on boot > >as they try to acces

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Lucas De Marchi
On Fri, Nov 27, 2020 at 02:57:48PM +, Chris Wilson wrote: We now use ilk_hpd_irq_setup for all GMCH platforms that do not have hotplug. These are early gen3 and gen2 devices that now explode on boot as they try to access non-existent registers. humn... true, my bad. But I don't think a reve

Re: [Intel-gfx] [PATCH] Revert "drm/i915: re-order if/else ladder for hpd_irq_setup"

2020-11-27 Thread Jani Nikula
On Fri, 27 Nov 2020, Chris Wilson wrote: > We now use ilk_hpd_irq_setup for all GMCH platforms that do not have > hotplug. These are early gen3 and gen2 devices that now explode on boot > as they try to access non-existent registers. > > Fixes: 794d61a19090 ("drm/i915: re-order if/else ladder for