Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-11-27 Thread Jani Nikula
On Tue, 26 Nov 2019, Lyude Paul wrote: > I'm about to post some more review comments for the v2 version of this, but > some comments down below... > > On Tue, 2019-10-08 at 12:19 +0300, Jani Nikula wrote: >> On Mon, 07 Oct 2019, Adam Jackson wrote: >> > On Mon, 2019-10-07 at 12:08 +0300, Jani

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-11-26 Thread Lyude Paul
I'm about to post some more review comments for the v2 version of this, but some comments down below... On Tue, 2019-10-08 at 12:19 +0300, Jani Nikula wrote: > On Mon, 07 Oct 2019, Adam Jackson wrote: > > On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: > > > > > The problem with the EDID

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-09 Thread Lee, Shawn C
On Tue, 08 Oct 2019, Jani Nikula wrote: >On Mon, 07 Oct 2019, Adam Jackson wrote: >> On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: >> >>> The problem with the EDID quirks is that exposing the quirks sticks out >>> like a sore thumb. Thus far all of it has been contained in drm_edid.c >>>

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-08 Thread Jani Nikula
On Mon, 07 Oct 2019, Adam Jackson wrote: > On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: > >> The problem with the EDID quirks is that exposing the quirks sticks out >> like a sore thumb. Thus far all of it has been contained in drm_edid.c >> and they affect how the EDID gets parsed, for

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Adam Jackson
On Mon, 2019-10-07 at 12:08 +0300, Jani Nikula wrote: > The problem with the EDID quirks is that exposing the quirks sticks out > like a sore thumb. Thus far all of it has been contained in drm_edid.c > and they affect how the EDID gets parsed, for all drivers. Obviously > this could be changed,

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Lee, Shawn C
On Mon, 07 Oct 2019, "Jani Nikula" mailto:jani.nik...@intel.com>> wrote: >On Mon, 07 Oct 2019, "Lee, Shawn C" >mailto:shawn.c@intel.com>> wrote: >> On Fri, 04 Oct 2019, Jani Nikula >> mailto:jani.nik...@intel.com>> wrote: >>>On Fri, 04 Oct 2019, Adam Jackson mailto:a...@redhat.com>>

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Lee, Shawn C
On Mon, 07 Oct 2019, "Jani Nikula" wrote: >On Mon, 07 Oct 2019, "Lee, Shawn C" wrote: >> On Fri, 04 Oct 2019, Jani Nikula wrote: >>>On Fri, 04 Oct 2019, Adam Jackson wrote: On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: > This panel (manufacturer is SDC, product ID is 0x4141)

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-07 Thread Jani Nikula
On Mon, 07 Oct 2019, "Lee, Shawn C" wrote: > On Fri, 04 Oct 2019, Jani Nikula wrote: >>On Fri, 04 Oct 2019, Adam Jackson wrote: >>> On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: This panel (manufacturer is SDC, product ID is 0x4141) used manufacturer defined DPCD register to

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-06 Thread Lee, Shawn C
On Fri, 04 Oct 2019, Jani Nikula wrote: >On Fri, 04 Oct 2019, Adam Jackson wrote: >> On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: >>> This panel (manufacturer is SDC, product ID is 0x4141) used >>> manufacturer defined DPCD register to control brightness that not >>> defined in eDP

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-04 Thread Jani Nikula
On Fri, 04 Oct 2019, Adam Jackson wrote: > On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: >> This panel (manufacturer is SDC, product ID is 0x4141) >> used manufacturer defined DPCD register to control brightness >> that not defined in eDP spec so far. This change follow panel >> vendor's

Re: [Intel-gfx] [PATCH] drm/i915: customize DPCD brightness control for specific panel

2019-10-04 Thread Adam Jackson
On Sat, 2019-10-05 at 05:58 +0800, Lee Shawn C wrote: > This panel (manufacturer is SDC, product ID is 0x4141) > used manufacturer defined DPCD register to control brightness > that not defined in eDP spec so far. This change follow panel > vendor's instruction to support brightness adjustment.