Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-05 Thread Jani Nikula
On Thu, 04 May 2023, Rodrigo Vivi wrote: > But let's not block the progress of the much needed fixes. It's your call: > > Reviewed-by: Rodrigo Vivi Thanks, pushed to drm-intel-gt-next as-is. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Jani Nikula
On Thu, 04 May 2023, Rodrigo Vivi wrote: > On Thu, May 04, 2023 at 12:43:05PM +0300, Jani Nikula wrote: >> On Wed, 03 May 2023, Rodrigo Vivi wrote: >> > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: >> >> You can't document both a sub-struct type and a struct member at the >> >> sa

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Rodrigo Vivi
On Thu, May 04, 2023 at 12:43:05PM +0300, Jani Nikula wrote: > On Wed, 03 May 2023, Rodrigo Vivi wrote: > > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: > >> You can't document both a sub-struct type and a struct member at the > >> same time. Separate them. > > > > another way woul

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-04 Thread Jani Nikula
On Wed, 03 May 2023, Rodrigo Vivi wrote: > On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: >> You can't document both a sub-struct type and a struct member at the >> same time. Separate them. > > another way would be to kill the 'i915_vma_bindinfo' name entirely and > document only as

Re: [Intel-gfx] [PATCH 05/24] drm/i915/vma: fix struct i915_vma_bindinfo kernel-doc

2023-05-03 Thread Rodrigo Vivi
On Tue, May 02, 2023 at 06:37:22PM +0300, Jani Nikula wrote: > You can't document both a sub-struct type and a struct member at the > same time. Separate them. another way would be to kill the 'i915_vma_bindinfo' name entirely and document only as '@bi:' and then move the individual documentations