Re: [Intel-gfx] [PATCH 06/12] drm/i915: remove rps local variables

2014-03-20 Thread Chris Wilson
On Wed, Mar 19, 2014 at 06:31:13PM -0700, Ben Widawsky wrote: With the renamed RPS struct members, it's easier to skip the local variables which no longer clarify anything, and if anything just make the code harder to read. The real motivation for this patch is actually the next patch, which

Re: [Intel-gfx] [PATCH 06/12] drm/i915: remove rps local variables

2014-03-20 Thread Daniel Vetter
On Thu, Mar 20, 2014 at 07:30:52AM +, Chris Wilson wrote: On Wed, Mar 19, 2014 at 06:31:13PM -0700, Ben Widawsky wrote: With the renamed RPS struct members, it's easier to skip the local variables which no longer clarify anything, and if anything just make the code harder to read.