Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Daniel Vetter
On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: Hi Chris, could

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 5:24 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Jul 17,

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Chris Wilson
On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: Hi Chris, could you please review this specific one or give you ack here? Didn't see anything wrong with it. The only caveat I have is that the GETPARAM must be accurate immediately following a setcrtc. If you can guarrantee that

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Rodrigo Vivi
On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: Hi Chris, could you please review this specific one or give you ack here? Didn't see anything wrong with it. The only caveat I have is that the

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-17 Thread Chris Wilson
On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: Hi Chris, could you please review this specific one or give you ack here? Didn't