Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-10 Thread Ville Syrjälä
On Tue, Jun 10, 2014 at 01:46:54PM +0100, Chris Wilson wrote: > Long ago, back in the racy haydays of 915gm interrupt handling, page > flips would occasionally go astray and leave the hardware stuck, and the > display not updating. This annoyed people who relied on their systems > being able to dis

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-10 Thread Daniel Vetter
On Tue, Jun 10, 2014 at 02:47:29PM +0300, Ville Syrjälä wrote: > On Tue, Jun 10, 2014 at 12:33:48PM +0100, Chris Wilson wrote: > > On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrjälä wrote: > > > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote: > > > > +static inline int crtc_sbc(s

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-10 Thread Ville Syrjälä
On Tue, Jun 10, 2014 at 12:33:48PM +0100, Chris Wilson wrote: > On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote: > > > +static inline int crtc_sbc(struct intel_crtc *crtc) > > > +{ > > > + return atomic_read(&crtc->base

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-10 Thread Chris Wilson
On Tue, Jun 10, 2014 at 02:25:50PM +0300, Ville Syrjälä wrote: > On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote: > > +static inline int crtc_sbc(struct intel_crtc *crtc) > > +{ > > + return atomic_read(&crtc->base.dev->vblank[crtc->pipe].count); > > +} > > Still says 'sbc' which do

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-10 Thread Ville Syrjälä
On Tue, Jun 10, 2014 at 11:04:00AM +0100, Chris Wilson wrote: > Long ago, back in the racy haydays of 915gm interrupt handling, page > flips would occasionally go astray and leave the hardware stuck, and the > display not updating. This annoyed people who relied on their systems > being able to dis

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Check for a stalled page flip after each vblank

2014-06-09 Thread Ville Syrjälä
On Fri, May 30, 2014 at 05:16:34PM +0100, Chris Wilson wrote: > Long ago, back in the racy haydays of 915gm interrupt handling, page > flips would occasionally go astray and leave the hardware stuck, and the > display not updating. This annoyed people who relied on their systems > being able to dis