Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix placement of ICP_PP_CONTROL

2019-03-06 Thread Ville Syrjälä
On Tue, Mar 05, 2019 at 01:07:34PM -0800, Lucas De Marchi wrote: > On Tue, Mar 05, 2019 at 03:23:48PM +0200, Jani Nikula wrote: > >On Mon, 04 Mar 2019, Jani Nikula wrote: > >> On Mon, 04 Mar 2019, Ville Syrjälä wrote: > >>> On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote: > T

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix placement of ICP_PP_CONTROL

2019-03-05 Thread Lucas De Marchi
On Tue, Mar 05, 2019 at 03:23:48PM +0200, Jani Nikula wrote: On Mon, 04 Mar 2019, Jani Nikula wrote: On Mon, 04 Mar 2019, Ville Syrjälä wrote: On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote: This register was placed in the middle of the PP_STATUS definition. Move it down tog

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix placement of ICP_PP_CONTROL

2019-03-05 Thread Jani Nikula
On Mon, 04 Mar 2019, Jani Nikula wrote: > On Mon, 04 Mar 2019, Ville Syrjälä wrote: >> On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote: >>> This register was placed in the middle of the PP_STATUS definition. Move >>> it down together with PP_CONTROL and fix the aligment of the bit

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix placement of ICP_PP_CONTROL

2019-03-04 Thread Jani Nikula
On Mon, 04 Mar 2019, Ville Syrjälä wrote: > On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote: >> This register was placed in the middle of the PP_STATUS definition. Move >> it down together with PP_CONTROL and fix the aligment of the bit >> definition (as per documentation it should

Re: [Intel-gfx] [PATCH 2/2] drm/i915: fix placement of ICP_PP_CONTROL

2019-03-04 Thread Ville Syrjälä
On Fri, Mar 01, 2019 at 05:14:05PM -0800, Lucas De Marchi wrote: > This register was placed in the middle of the PP_STATUS definition. Move > it down together with PP_CONTROL and fix the aligment of the bit > definition (as per documentation it should be 2 spaces instead of 1). > > Signed-off-by: