Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-08 Thread Pandiyan, Dhinakaran
On Mon, 2018-01-08 at 15:43 +0100, Maarten Lankhorst wrote: > Op 06-01-18 om 10:51 schreef Dhinakaran Pandiyan: > > On Thursday, January 4, 2018 12:35:48 PM PST Maarten Lankhorst wrote: > >> Op 03-01-18 om 21:39 schreef Dhinakaran Pandiyan: > >>> Since we want to allow for a non-blocking power doma

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-08 Thread Maarten Lankhorst
Op 06-01-18 om 10:51 schreef Dhinakaran Pandiyan: > On Thursday, January 4, 2018 12:35:48 PM PST Maarten Lankhorst wrote: >> Op 03-01-18 om 21:39 schreef Dhinakaran Pandiyan: >>> Since we want to allow for a non-blocking power domain for vblanks, >>> the power domain use count and power well use co

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-06 Thread Dhinakaran Pandiyan
On Thursday, January 4, 2018 12:35:48 PM PST Maarten Lankhorst wrote: > Op 03-01-18 om 21:39 schreef Dhinakaran Pandiyan: > > Since we want to allow for a non-blocking power domain for vblanks, > > the power domain use count and power well use count will not be updated > > atomically inside the pow

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-05 Thread Pandiyan, Dhinakaran
On Fri, 2018-01-05 at 10:09 -0800, Rodrigo Vivi wrote: > On Fri, Jan 05, 2018 at 11:23:54AM +, Maarten Lankhorst wrote: > > Op 04-01-18 om 22:51 schreef Pandiyan, Dhinakaran: > > > On Thu, 2018-01-04 at 12:35 +0100, Maarten Lankhorst wrote: > > >> Wouldn't it be better to make intel_power_do

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-05 Thread Rodrigo Vivi
On Fri, Jan 05, 2018 at 11:23:54AM +, Maarten Lankhorst wrote: > Op 04-01-18 om 22:51 schreef Pandiyan, Dhinakaran: > > On Thu, 2018-01-04 at 12:35 +0100, Maarten Lankhorst wrote: > >> Wouldn't it be better to make intel_power_domains_verify_state work > >> correctly with the vblank irq? > > I

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-05 Thread Maarten Lankhorst
Op 04-01-18 om 22:51 schreef Pandiyan, Dhinakaran: > On Thu, 2018-01-04 at 12:35 +0100, Maarten Lankhorst wrote: >> Wouldn't it be better to make intel_power_domains_verify_state work >> correctly with the vblank irq? > I tried to :) Since I changed the domain_use_count to atomic_t and moved > it o

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-04 Thread Pandiyan, Dhinakaran
On Thu, 2018-01-04 at 12:35 +0100, Maarten Lankhorst wrote: > Wouldn't it be better to make intel_power_domains_verify_state work > correctly with the vblank irq? I tried to :) Since I changed the domain_use_count to atomic_t and moved it outside of the locks, verify_state became racy. Let me tak

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-04 Thread Pandiyan, Dhinakaran
On Wed, 2018-01-03 at 20:57 +, Chris Wilson wrote: > Quoting Dhinakaran Pandiyan (2018-01-03 20:39:59) > > Since we want to allow for a non-blocking power domain for vblanks, > > the power domain use count and power well use count will not be updated > > atomically inside the power domain mut

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-04 Thread Maarten Lankhorst
Op 03-01-18 om 21:39 schreef Dhinakaran Pandiyan: > Since we want to allow for a non-blocking power domain for vblanks, > the power domain use count and power well use count will not be updated > atomically inside the power domain mutex (see next patch). This affects > verifying if sum(power_domain

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Enable vblanks after verifying power domain states.

2018-01-03 Thread Chris Wilson
Quoting Dhinakaran Pandiyan (2018-01-03 20:39:59) > Since we want to allow for a non-blocking power domain for vblanks, > the power domain use count and power well use count will not be updated > atomically inside the power domain mutex (see next patch). This affects > verifying if sum(power_domain