Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-21 Thread Summers, Stuart
On Thu, 2019-05-16 at 15:40 -0700, Daniele Ceraolo Spurio wrote: > > > > --- a/drivers/gpu/drm/i915/gt/intel_sseu.h > > +++ b/drivers/gpu/drm/i915/gt/intel_sseu.h > > @@ -9,16 +9,18 @@ > > > > #include > > #include > > +#include > > AFAICS this header is not needed anymore. With it rem

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-16 Thread Daniele Ceraolo Spurio
--- a/drivers/gpu/drm/i915/gt/intel_sseu.h +++ b/drivers/gpu/drm/i915/gt/intel_sseu.h @@ -9,16 +9,18 @@ #include #include +#include AFAICS this header is not needed anymore. With it removed: Reviewed-by: Daniele Ceraolo Spurio Daniele struct drm_i915_private; #define

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Daniele Ceraolo Spurio
--- a/drivers/gpu/drm/i915/intel_device_info.c +++ b/drivers/gpu/drm/i915/intel_device_info.c @@ -84,17 +84,46 @@ void intel_device_info_dump_flags(const struct intel_device_info *info, #undef PRINT_FLAG } +#define SS_STR_MAX_SIZE (GEN_MAX_SUBSLICE_STRIDE * 2 + 1) + +static char *

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Summers, Stuart
On Tue, 2019-05-07 at 14:16 -0700, Daniele Ceraolo Spurio wrote: > > > > > > > > > --- a/drivers/gpu/drm/i915/intel_device_info.c > > > > +++ b/drivers/gpu/drm/i915/intel_device_info.c > > > > @@ -84,17 +84,46 @@ void intel_device_info_dump_flags(const > > > > struct > > > > intel_device_info *i

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Summers, Stuart
On Tue, 2019-05-07 at 12:00 -0700, Daniele Ceraolo Spurio wrote: > > On 5/3/19 2:30 PM, Stuart Summers wrote: > > Currently, the subslice_mask runtime parameter is stored as an > > array of subslices per slice. Expand the subslice mask array to > > better match what is presented to userspace throu

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Daniele Ceraolo Spurio
On 5/3/19 2:30 PM, Stuart Summers wrote: Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calcu

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-04-30 Thread Summers, Stuart
On Tue, 2019-04-30 at 12:03 +0300, Jani Nikula wrote: > On Mon, 29 Apr 2019, Stuart Summers wrote: > > Currently, the subslice_mask runtime parameter is stored as an > > array of subslices per slice. Expand the subslice mask array to > > better match what is presented to userspace through the > >

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-04-30 Thread Jani Nikula
On Mon, 29 Apr 2019, Stuart Summers wrote: > Currently, the subslice_mask runtime parameter is stored as an > array of subslices per slice. Expand the subslice mask array to > better match what is presented to userspace through the > I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is > t