Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Paulo Zanoni
Em Qua, 2018-06-13 às 11:07 +0300, Jani Nikula escreveu: > On Tue, 12 Jun 2018, Rodrigo Vivi wrote: > > Do we really want BIT everywhere?! > > I think I'd go for everywhere except part of a register field value: > While I completely agree with your reasoning, this means we'll kinda always want

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-13 Thread Jani Nikula
On Tue, 12 Jun 2018, Rodrigo Vivi wrote: > Do we really want BIT everywhere?! I think I'd go for everywhere except part of a register field value: #define SINGLE_BIT_OKAY BIT(25) #define FIELD_SHIFT 20 #define FIELD_MASK (0xf << 20) #define FIELD_FOO_PLEASE_NO

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-12 Thread Rodrigo Vivi
On Tue, Jun 12, 2018 at 11:46:08AM +0300, Jani Nikula wrote: > On Mon, 11 Jun 2018, Paulo Zanoni wrote: > > Em Seg, 2018-06-11 às 22:35 +, Patchwork escreveu: > >> == Series Details == > >> > >> Series: series starting with [CI,1/2] drm/i915/icl: Add allowed DP > >> rates for Icelake > >> URL

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-12 Thread Jani Nikula
On Mon, 11 Jun 2018, Paulo Zanoni wrote: > Em Seg, 2018-06-11 às 22:35 +, Patchwork escreveu: >> == Series Details == >> >> Series: series starting with [CI,1/2] drm/i915/icl: Add allowed DP >> rates for Icelake >> URL : https://patchwork.freedesktop.org/series/44595/ >> State : warning >>

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/2] drm/i915/icl: Add allowed DP rates for Icelake

2018-06-11 Thread Paulo Zanoni
Em Seg, 2018-06-11 às 22:35 +, Patchwork escreveu: > == Series Details == > > Series: series starting with [CI,1/2] drm/i915/icl: Add allowed DP > rates for Icelake > URL : https://patchwork.freedesktop.org/series/44595/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-t