[Intel-gfx] [PATCH 08/28] drm/noveau: Ditch NULL save/restore hook assignments

gcc does this for us, and these hooks will be gone soon. Cc: Ben Skeggs Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_connector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c

[Intel-gfx] [PATCH 17/28] drm: Document drm_connector_funcs

The special case here is that both ->detect and ->force are actually functions only called by the probe helpers and hence really shouldn't be here. But since they've used by pretty much every driver I figured it's better to just document this for now instead of holding this doc patch hostage until

[Intel-gfx] [PATCH 10/28] drm/virtio: Drop dummy save/restore functions

These hooks will be gone soon. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_display.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c

[Intel-gfx] [PATCH 05/28] drm: Merge helper docbook into kerneldoc comments

Duplication is bad, luckily both help texts highlighted different issues so the kerneldoc gained quite a bit! While at it also sprinkle more references to the vtable structs around and make it clear that legacy CRTC helpers are deprecated and which functions to use instead. Signed-off-by: Daniel

[Intel-gfx] [PATCH 01/28] drm: Polish fbdev helper struct docs

Mostly this is just adding extensive docs for the callbacks, but also a few other additions. v2: Use FIXME comments to annotate helper hooks that should be replaced. Signed-off-by: Daniel Vetter --- include/drm/drm_fb_helper.h | 92

[Intel-gfx] [PATCH 04/28] drm: Make helper vtable pointers type-safe

Originally the idea behind void* was to allow different sets of helpers. But now we have that (with probe, plane, crtc and atomic helpers) and we still just use the same set of vtables. That's the only way to make the individual helpers modular and allow drivers to pick and transition between

[Intel-gfx] [PATCH 03/28] drm: Reorganize helper vtables and their docs

Currently we have 4 helper libraries (probe, crtc, plane & atomic) that all use the same helper vtables. And that's by necessity since we don't want to litter the core structs with one ops pointer per helper library. Also often the reuse the same hooks (like atomic does, to facilite conversion

[Intel-gfx] [PATCH 02/28] drm: Move LEAVE/ENTER_ATOMIC_MODESET to fbdev helpers

This is only used for kgdb (and previously panic) handlers in the fbdev emulation, so belongs there. Note that this means we'll leave behind a forward declaration, but once all the helper vtables are consolidated (in the next patch) that will make more sense. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 00/28] kerneldoc for display vtables

Hi all, So here's finally my promised doc update for atomic, with massive amounts of kerneldoc in the new in-line style for all the vfunc hooks we have in the KMS code (so yeah also all the legacy hooks are documented). This also merges in anything from Laurent's original docbook docs, where it

[Intel-gfx] [PATCH 07/28] drm: Update drm_plane_funcs kerneldoc

- Merge the docbook into the kerneldoc comments. - Spec in detail the precise semantics of the callbacks. - For consistency in wording and easier review roll out kerneldoc also for crtc, encoder and connector for the standard hooks they share with planes. Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 06/28] drm/bridge: Improve kerneldoc

Especially document the assumptions and semantics of the callbacks carefully. Just a warm-up excercise really. v2: Spelling fixes (Eric). v3: Consolidate more with existing docs: - Remove the overview section explaining the bridge funcs, that's now all in the drm_bridge_funcs kerneldoc in

[Intel-gfx] [PATCH 09/28] drm/qxl: Drop dummy save/restore hooks

These hooks will be gone soon. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_display.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c

[Intel-gfx] [PATCH 18/28] drm: connector->dpms is not optional

We always register the DPMS property, it's really a fundamental part of a display driver. So don't check whether the vfunc is there, it's non-optional Yes I've audited all the almost 100 drm_connector_funcs we have, no one botched this ;-) Signed-off-by: Daniel Vetter

[Intel-gfx] [PATCH 12/28] drm/gma500: Move to private save/restore hooks

I want to remove the core ones since with atomic drivers system suspend/resume is solved much differently. And there's only 2 drivers (nouveau besides gma500) really using them. Cc: Patrik Jakobsson Signed-off-by: Daniel Vetter ---

[Intel-gfx] [PATCH 13/28] drm/nouveau: Use private save/restore hooks

I want to remove the core ones since with atomic drivers system suspend/resume is solved much differently. And there's only 2 drivers (gma500 besides nouveau) really using them. Cc: Ben Skeggs Signed-off-by: Daniel Vetter ---

[Intel-gfx] [PATCH 11/28] drm/vmwgfx: Drop dummy save/restore hooks

These hooks will be gone soon. Cc: Thomas Hellstrom Signed-off-by: Daniel Vetter --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 16 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 4

Re: [Intel-gfx] [PATCH v9 1/3] drm/kms_helper: Add a common place to call init and exit functions.

On Thu, Dec 03, 2015 at 02:54:00PM -0800, Rafael Antognolli wrote: > The module_init and module_exit functions will start here, and call the > subsequent init's and exit's. > > Signed-off-by: Rafael Antognolli > --- > drivers/gpu/drm/Makefile| 4 ++-

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Thu, 03 Dec 2015, Chris Wilson wrote: > On Thu, Dec 03, 2015 at 11:25:48PM +0200, Ville Syrjälä wrote: >> I think we had some bug with not properly pinning the fbdev buffer which >> could explain things getting corrupted. Chris had a fix I think, but I'm >> not sure

Re: [Intel-gfx] [PATCH 9/9] drm/atomic: Add encoder_mask to crtc_state.

On Thu, Dec 03, 2015 at 12:01:02PM +0100, Maarten Lankhorst wrote: > Op 03-12-15 om 10:53 schreef Daniel Vetter: > > On Tue, Nov 24, 2015 at 10:34:36AM +0100, Maarten Lankhorst wrote: > >> This allows iteration over encoders without requiring connection_mutex. > >> > >> Signed-off-by: Maarten

[Intel-gfx] [PATCH 26/28] drm: Move drm_display_mode an related docs into kerneldoc

This was in the documentation for modeset helper hooks, where it is a bit misplaced. v2: Reindent the drm_mode_status enum, inspired by Ville. Cc: ville.syrj...@linux.intel.com Signed-off-by: Daniel Vetter --- Documentation/DocBook/gpu.tmpl | 192

[Intel-gfx] [PATCH 23/28] drm: Document drm_plane_helper_funcs

Plus related hooks used to do atomic plane updates since they only really make sense as a package. Signed-off-by: Daniel Vetter --- include/drm/drm_modeset_helper_vtables.h | 209 +-- 1 file changed, 198 insertions(+), 11 deletions(-) diff

[Intel-gfx] [PATCH 24/28] drm: Document drm_connector_helper_funcs

Nothing special, except the somewhat awkard split in probe helper callbacks between here and drm_crtc_funcs. Signed-off-by: Daniel Vetter --- include/drm/drm_modeset_helper_vtables.h | 106 +-- 1 file changed, 101 insertions(+), 5 deletions(-)

[Intel-gfx] [PATCH 25/28] drm/atomic-helper: Mention the new system/resume helpers the docs

They have pretty kerneldoc already, but better to link to that in one of the overview sections. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c

[Intel-gfx] [PATCH 28/28] drm/atomic-helper: Reject legacy flips on a disabled pipe

We want this for consistency with existing page_flip semantics. Since this spurred quite a discussion on IRC also document why we reject even generation when the pipe is off: It's not that it's hard to implement, but userspace has a track recording proofing that it's way too easy to accidentally

[Intel-gfx] [PATCH 20/28] drm: Add kerneldoc for drm_framebuffer_funcs

While typing these I noticed that ->dirty is a bit a can of worms and even supports blt/fill semantics ... shocked me a bit. Oh well it's defined in a way that nothing bad (just a bit of inefficiency) will happen for drivers which supports this. So I didn't bother copying the detailed spec into

[Intel-gfx] [PATCH 27/28] drm: Document drm_encoder/crtc_helper_funcs

Mostly this is about all the callbacks used to modesets by both legacy CRTC helpers and atomic helpers and I figured it doesn't make all that much sense to split this up. Signed-off-by: Daniel Vetter --- include/drm/drm_modeset_helper_vtables.h | 447

[Intel-gfx] [PATCH 22/28] drm/atomic-helper: Reject attempts at re-stealing encoders

This can happen when we run out of encoders for a multi-crtc modeset, or also when userspace is silly and tries to clone multiple connectors that need the same encoder on the same crtc. Reported-and-Tested-and-Reviewed-by: Maarten Lankhorst Cc: Maarten

[Intel-gfx] [PATCH 19/28] drm: document drm_crtc_funcs

And merge any docbook we have into the kerneldoc comments. Since it's a legacy entry point with only two implementation (one each in atomic and legacy crtc helpers) I've made the documentation for set_config fairly sparse - no one should ever need to look at this again, all the ABI we have is

[Intel-gfx] [PATCH 14/28] drm: Remove crtc/connector->save/restore hooks

They're not how system suspend/resume should be done with atomic (there's new helpers for that developed by Thierry Redding), and for legacy drivers this really should be a helper hook and not a core one. But there's not even helper code to use them, and only 2 drivers (which now have their own

[Intel-gfx] [PATCH 16/28] drm: Document drm_atomic_*_get_property

Yes these are internal functions and not exported and we generally don't document them. But for symmetry with the _set_property functions (which are exported for the atomic helpers) I'd like to document them. Upcoming vtable kerneldoc will reference both the set and get_property functions.

[Intel-gfx] [PATCH 15/28] drm: Move encoder->save/restore into nouveau

Nouveau is the only user, and atomic drivers should do state save/restoring differently. So move it into noveau. Saves me typing some kerneldoc, too ;-) Cc: Ben Skeggs Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/dispnv04/dac.c| 7

[Intel-gfx] [PATCH 21/28] drm: Kerneldoc for drm_mode_config_funcs

The meat here is definitely the detailed specs for what atomic_check and atomic_commit are supposed to do. And another candidate for a core vfunc that should be in a helper really (output_poll_changed this time around). v2: Feedback from Eric on irc: - spelling fixes. - spec what async should do

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: add a QUICKSTART section to dim.rst

On Thu, 03 Dec 2015, Paulo Zanoni wrote: > Because just running dim help doesn't give you the greater picture of > the workflow. All the text here is based on an email written by Daniel > Vetter, so the credits go to him. Any mistakes were introduced by me. We could

[Intel-gfx] [PATCH 3/3] drm/i915: Use the ceil value for the additional clk divider

Additional clock value divider should use the ceil value of the calulation to get the correct divider value. Signed-off-by: Deepak M --- drivers/gpu/drm/i915/intel_dsi_pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 1/3] drm/i915: Add DPI FIFO empty status check

From: Gaurav K Singh After sending SHUTDOWN or TURN ON packet,check the DPI FIFO empty status. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_dsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Intel-gfx] [PATCH 2/3] drm/i915: Correct the Ref clock value for BXT

The reference clock for BXT is 19.2 MHz not 19.5 MHz, updating the correct value here. Signed-off-by: Deepak M --- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Thu, 03 Dec 2015, Ville Syrjälä wrote: > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: >> Hi, >> >> I've experienced a few graphics issues recently, and I tend to believe >> that it has happened since 4.4-rc. Namely, after some long time usage

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

Hi, > btw some questions here: > > for non-gl and gl rendering in Qemu, are they based on dma-buf already? > once we can export guest framebuffer in dma-buf, is there additional work > required or just straightforward to integrate with SPICE? Right now we are busy integrating dma-buf support

[Intel-gfx] [PULL] topic/drm-misc

Hi Dave, New -misc pull. Big thing is Thierry's atomic helpers for system suspend resume, which I'd like to use in i915 too. Hence the pull. Aside: There's a conflict between your -next and -fixes in imx, pinged you about it on irc. Would be good if you can backmerge the next -rc after pulling

Re: [Intel-gfx] [PATCH] drm/i915: Avoid writing relocs with addresses in non-canonical form

On Fri, Dec 04, 2015 at 12:33:44PM +0100, Michał Winiarski wrote: > According to bspec, some parts of HW expect the addresses to be in > a canonical form, where bits [63:48] == [47]. Let's convert addresses to > canonical form prior to relocating and return converted offsets to > userspace. > >

[Intel-gfx] [PATCH] drm/i915: Add DPI FIFO empty status check

From: Gaurav K Singh Before sending TURN ON packet,check the DPI FIFO empty status. v2: Change in commit message Checking for FIFO empty only during TURN ON packet. Signed-off-by: Gaurav K Singh Signed-off-by: Deepak M

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 11:21:02 +0100, Daniel Vetter wrote: > > On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi Iwai wrote: > > Implement a new i915_audio_component_ops, get_eld(). It's called by > > the audio driver to fetch the current audio status and ELD of the > > given HDMI/DP port. It

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On 03/12/15 21:35, Chris Wilson wrote: On Thu, Dec 03, 2015 at 11:25:48PM +0200, Ville Syrjälä wrote: On Thu, Dec 03, 2015 at 10:08:05PM +0100, Takashi Iwai wrote: On Thu, 03 Dec 2015 21:33:29 +0100, Ville Syrjälä wrote: On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: Hi,

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Leave FDI running after failed link training on LPT-H

On Fri, Dec 04, 2015 at 11:09:11AM +0100, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 03:08:41PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Currently we disable some parts of FDI setup after a failed link > > training. But

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Dump in-flight plane state while dumping in-flight CRTC state

On Thu, Dec 03, 2015 at 01:27:52PM +0100, Maarten Lankhorst wrote: > Op 25-11-15 om 17:48 schreef Matt Roper: > > The intel_dump_pipe_config() always dumps the currently active plane > > state for each plane on a CRTC. If we're calling this function to dump > > CRTC state that is in-flight (not

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add DPI FIFO empty status check

> -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Friday, December 4, 2015 3:20 PM > To: Deepak, M > Cc: intel-gfx@lists.freedesktop.org; Gaurav K Singh > > Subject: Re: [Intel-gfx] [PATCH 1/3]

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Correct the Ref clock value for BXT

On Fri, Dec 04, 2015 at 07:47:38PM +0530, Deepak M wrote: > The reference clock for BXT is 19.2 MHz not 19.5 MHz, updating the > correct value here. > > Signed-off-by: Deepak M > --- > drivers/gpu/drm/i915/i915_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Stop setting wraparound seqno on initialisation

On Tue, Dec 01, 2015 at 04:57:11PM +, Dave Gordon wrote: > On 29/11/15 08:48, Chris Wilson wrote: > >We have testcases to ensure that seqno wraparound works fine, so we can > >forgo forcing everyone to encounter seqno wraparound during early > >uptime. seqno wraparound incurs a full GPU stall

Re: [Intel-gfx] [PATCH 02/11] drm/i915: Fix vbt PWM max setup for CTG

On Tue, Dec 01, 2015 at 02:30:46PM +0200, Jani Nikula wrote: > On Tue, 01 Dec 2015, Jani Nikula wrote: > > On Mon, 30 Nov 2015, ville.syrj...@linux.intel.com wrote: > >> From: Ville Syrjälä > >> > >> CTG uses hrawclk for backlight, so

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add DPI FIFO empty status check

On Fri, Dec 04, 2015 at 07:47:37PM +0530, Deepak M wrote: > From: Gaurav K Singh > > After sending SHUTDOWN or TURN ON packet,check the DPI > FIFO empty status. > > Signed-off-by: Gaurav K Singh > --- > drivers/gpu/drm/i915/intel_dsi.c | 6

Re: [Intel-gfx] [PATCH 4/4] igt/gem_stolen: Verify contents of stolen-backed objects across hibernation

Hi, One more thing below: On 02/12/15 09:24, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch verifies if the contents of the stolen backed object were preserved across hibernation. This is to validate kernel changes related to moving

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi Iwai wrote: > Implement a new i915_audio_component_ops, get_eld(). It's called by > the audio driver to fetch the current audio status and ELD of the > given HDMI/DP port. It returns the size of expected ELD bytes if it's > valid, zero if no

[Intel-gfx] [PATCH igt] igt/gem_exec_nop: Remove nop latency measurements

Since commit c8beadb811bdc2b9c21f95144852f3e55867b546 Author: Derek Morton Date: Wed Nov 11 14:46:58 2015 + tests/gem_exec_nop: Improved test run time the stablity of the measurement regressed and it is once again no longer a reliable metric for detecting

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > to_intel_crtc() always returns a non-NULL pointer. > > Signed-off-by: Takashi Iwai Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_audio.c | 4 > 1 file changed, 4

Re: [Intel-gfx] [PATCH] drm/i915: Enable GSE interrupt on BDW+

On Wed, Dec 02, 2015 at 12:17:10AM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We've never actually enabled or unmasked the GSE interrupt on BDW+, > even though the interrupt handler was always prepared for it. > Let's enable it and see

Re: [Intel-gfx] [PATCH] drm/i915: Add DPI FIFO empty status check

On Fri, Dec 04, 2015 at 09:41:17PM +0530, Deepak M wrote: > From: Gaurav K Singh > > Before sending TURN ON packet,check the DPI > FIFO empty status. > > v2: Change in commit message > Checking for FIFO empty only during TURN ON packet. > > Signed-off-by: Gaurav

[Intel-gfx] [PATCH] drm/i915: Avoid writing relocs with addresses in non-canonical form

According to bspec, some parts of HW expect the addresses to be in a canonical form, where bits [63:48] == [47]. Let's convert addresses to canonical form prior to relocating and return converted offsets to userspace. Cc: Chris Wilson Cc: Michel Thierry

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/kms_force_connector: Fixes

On Wed, Dec 02, 2015 at 01:50:36PM +0200, Jani Nikula wrote: > On Tue, 01 Dec 2015, Daniel Vetter wrote: > > On Tue, Dec 01, 2015 at 01:12:43PM +0200, Jani Nikula wrote: > >> On Tue, 01 Dec 2015, Daniel Vetter wrote: > >> > Somehow the kernel's mode list

Re: [Intel-gfx] [PATCH 13/15] drm/i915: Stop setting wraparound seqno on initialisation

On Fri, Dec 04, 2015 at 10:36:45AM +0100, Daniel Vetter wrote: > On Tue, Dec 01, 2015 at 04:57:11PM +, Dave Gordon wrote: > > On 29/11/15 08:48, Chris Wilson wrote: > > >We have testcases to ensure that seqno wraparound works fine, so we can > > >forgo forcing everyone to encounter seqno

Re: [Intel-gfx] [PATCH 06/28] drm/bridge: Improve kerneldoc

On 12/04/2015 02:15 PM, Daniel Vetter wrote: Especially document the assumptions and semantics of the callbacks carefully. Just a warm-up excercise really. v2: Spelling fixes (Eric). v3: Consolidate more with existing docs: - Remove the overview section explaining the bridge funcs, that's

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Fri, Dec 04, 2015 at 12:00:08PM +, Dave Gordon wrote: > On 03/12/15 21:35, Chris Wilson wrote: > >On Thu, Dec 03, 2015 at 11:25:48PM +0200, Ville Syrjälä wrote: > >>On Thu, Dec 03, 2015 at 10:08:05PM +0100, Takashi Iwai wrote: > >>>On Thu, 03 Dec 2015 21:33:29 +0100, > >>>Ville Syrjälä

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Fri, Dec 04, 2015 at 12:06:59PM +, Chris Wilson wrote: > > Could also be down to certain objects getting their contents > > discarded when evicted (due to not being marked dirty), for which I > > posted a fix "Always mark GEM objects as dirty when written by the > > CPU" a few days ago? >

Re: [Intel-gfx] [PATCH v2 1/9] drm/i915: Remove superfluous NULL check

On Tue, Dec 01, 2015 at 05:09:50PM +0100, Takashi Iwai wrote: > to_intel_crtc() always returns a non-NULL pointer. Eh? to_intel_crtc(NULL) should return NULL or we might have tons of breakage on our hands. Or maybe the atomic work has gotten rid of that assumption, but at least we used to depend

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Fri, Dec 04, 2015 at 10:49:48AM +0200, Jani Nikula wrote: > On Thu, 03 Dec 2015, Ville Syrjälä wrote: > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: > >> Hi, > >> > >> I've experienced a few graphics issues recently, and I tend to believe > >>

Re: [Intel-gfx] [PATCH] Always mark GEM objects as dirty when written by the CPU

On Tue, Dec 01, 2015 at 01:21:07PM +, Dave Gordon wrote: > On 01/12/15 13:04, Chris Wilson wrote: > >On Tue, Dec 01, 2015 at 12:42:02PM +, Dave Gordon wrote: > >>In various places, one or more pages of a GEM object are mapped into CPU > >>address space and updated. In each such case, the

Re: [Intel-gfx] [PATCH] drm/i915: Clean up device info structure definitions

On Wed, Dec 02, 2015 at 01:28:14PM -0800, Wayne Boyer wrote: > Beginning with gen7, newer devices repetitively redefine values > for the device info structure members. This patch simplifies the > structure definitions by grouping member value definitions into the > existing GEN7_FEATURES #define

Re: [Intel-gfx] [PATCH] drm/i915: Avoid writing relocs with addresses in non-canonical form

On Fri, Dec 04, 2015 at 12:33:44PM +0100, Michał Winiarski wrote: > According to bspec, some parts of HW expect the addresses to be in > a canonical form, where bits [63:48] == [47]. Let's convert addresses to > canonical form prior to relocating and return converted offsets to > userspace. > >

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature

On Tue, Dec 01, 2015 at 10:35:59AM +, Tvrtko Ursulin wrote: > > Hi, > > Just one comment deep down. > > On 30/11/15 18:22, Vinay Belgaumkar wrote: > >These tests exercise the userptr ioctl to create shared buffers > >between CPU and GPU. They contain error and normal usage scenarios. >

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Leave FDI running after failed link training on LPT-H

On Tue, Dec 01, 2015 at 03:08:41PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently we disable some parts of FDI setup after a failed link > training. But despite that we continue with the modeset as if everything > is fine. This

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: use quotes when testing for empty string

On Thu, 03 Dec 2015, Paulo Zanoni wrote: > Today I applied/pushed patches for the first time, and noticed that > all my commits had exactly this: > Link: http://patchwork.freedesktop.org/patch/msgid/ > without the actual ID there. I assumed the ID would be set by

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 16:00:46 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrote: > > On Fri, 04 Dec 2015 11:21:02 +0100, > > Daniel Vetter wrote: > > > > > > On Tue, Dec 01, 2015 at 05:09:51PM +0100, Takashi Iwai wrote: > > > > Implement a new

[Intel-gfx] [PATCH v2] drm/i915: Avoid writing relocs with addresses in non-canonical form

According to bspec, some parts of HW expect the addresses to be in a canonical form, where bits [63:48] == [47]. Let's convert addresses to canonical form prior to relocating and return converted offsets to userspace. v2: Whitespace fixup, gen8_canonical_addr description (Chris, Ville) Cc: Chris

Re: [Intel-gfx] [PATCH igt 2/2] kms_frontbuffer_tracking: standardize the used FB sizes

On Wed, Dec 02, 2015 at 10:47:01AM -0200, Paulo Zanoni wrote: > We want to make sure that both tiled and untiled buffers have the same > size for the same width/height/format. This will allow better control > over the failure paths exercised by our tests: when we try to flip > from tiled to

Re: [Intel-gfx] [PATCH i-g-t] tests: add exit value constants for shell script tests

On Thu, Dec 03, 2015 at 11:30:53AM +, Thomas Wood wrote: > Signed-off-by: Thomas Wood Yeah that's nicer. I fixed up patch 2 to use the correct exit code and push the entire series. Thanks for the feedback! Cheers, Daniel > --- > tests/check_drm_clients | 2 +-

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote: > On Fri, 04 Dec 2015 16:00:46 +0100, > Daniel Vetter wrote: > > > > On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrote: > > > On Fri, 04 Dec 2015 11:21:02 +0100, > > > Daniel Vetter wrote: > > > > > > > > On Tue, Dec 01,

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Fri, Dec 04, 2015 at 10:44:17AM +0200, Jani Nikula wrote: > On Thu, 03 Dec 2015, Chris Wilson wrote: > > On Thu, Dec 03, 2015 at 11:25:48PM +0200, Ville Syrjälä wrote: > >> I think we had some bug with not properly pinning the fbdev buffer which > >> could explain

Re: [Intel-gfx] [PATCH] drm/i915: Restore skl_gt3 device info

On Fri, Dec 04, 2015 at 04:19:49PM +0100, Daniel Vetter wrote: > This was broken in > > commit 6a8beeffed3b2d33151150e3a03696e697f16d46 > Author: Wayne Boyer > Date: Wed Dec 2 13:28:14 2015 -0800 > > drm/i915: Clean up device info structure definitions > > and I

Re: [Intel-gfx] [PATCH 13/28] drm/nouveau: Use private save/restore hooks

On Fri, Dec 04, 2015 at 09:31:01AM -0500, Ilia Mirkin wrote: > On Fri, Dec 4, 2015 at 3:45 AM, Daniel Vetter wrote: > > I want to remove the core ones since with atomic drivers system > > suspend/resume is solved much differently. And there's only 2 drivers > > (gma500

Re: [Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

On Fri, Dec 04, 2015 at 03:58:53PM +, Chris Wilson wrote: > Some modules, like i915.ko, use swappable objects and may try to swap > them out under memory pressure (via the shrinker). Before doing so, they > want to check using get_nr_swap_pages() to see if any swap space is > available as

Re: [Intel-gfx] [PATCH] drm/i915: Separate cherryview from valleyview

On Wed, Dec 02, 2015 at 02:30:28PM +0200, Jani Nikula wrote: > On Wed, 02 Dec 2015, Ville Syrjälä wrote: > > On Tue, Dec 01, 2015 at 05:11:40PM -0800, Wayne Boyer wrote: > >> The cherryview device shares many characteristics with the valleyview > >> device. When

Re: [Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

On Wed, Dec 02, 2015 at 11:09:34AM +0200, Ville Syrjälä wrote: > On Wed, Dec 02, 2015 at 12:13:27PM +0530, Vandana Kannan wrote: > > Making changes in intel_crtc_mode_get() to get correct values for crtc > > clock, > > vdisplay, hdisplay, vtotal. > > Why? It's not used except potentially during

Re: [Intel-gfx] [PATCH] drm/i915: Fix RPS pointer passed from wait_ioctl to i915_wait_request

On Thu, Dec 03, 2015 at 09:25:37PM +, Chris Wilson wrote: > On Wed, Dec 02, 2015 at 09:13:46AM +, Chris Wilson wrote: > > In commit 2e1b873072dfe3bbcc158a9c21acde1ab0d36c55 [v4.2] > > Author: Chris Wilson > > Date: Mon Apr 27 13:41:22 2015 +0100 > > > >

[Intel-gfx] [PATCH] drm/i915: Restore skl_gt3 device info

This was broken in commit 6a8beeffed3b2d33151150e3a03696e697f16d46 Author: Wayne Boyer Date: Wed Dec 2 13:28:14 2015 -0800 drm/i915: Clean up device info structure definitions and I didn't spot this while reviewing. We really need that CI farm up asap!

Re: [Intel-gfx] [PATCH 2/2] igt/pm_rps: Add checks for freq = idle (RPn) in specific cases.

On to, 2015-12-03 at 16:43 -0800, Bob Paauwe wrote: > On Tue, 1 Dec 2015 19:43:05 +0200 > Imre Deak wrote: > > > On ti, 2015-12-01 at 09:22 -0800, Bob Paauwe wrote: > > > On Tue, 1 Dec 2015 15:56:55 +0200 > > > Imre Deak wrote: > > > > > > > On ma,

Re: [Intel-gfx] [PATCH igt 2/2] kms_frontbuffer_tracking: standardize the used FB sizes

On Wed, Dec 02, 2015 at 10:47:01AM -0200, Paulo Zanoni wrote: > We want to make sure that both tiled and untiled buffers have the same > size for the same width/height/format. This will allow better control > over the failure paths exercised by our tests: when we try to flip > from tiled to

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 16:53:02 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote: > > On Fri, 04 Dec 2015 16:00:46 +0100, > > Daniel Vetter wrote: > > > > > > On Fri, Dec 04, 2015 at 11:49:46AM +0100, Takashi Iwai wrote: > > > > On Fri, 04 Dec 2015

Re: [Intel-gfx] Possible i915 regression with 4.4-rc

On Fri, Dec 04, 2015 at 11:40:59AM +0200, Ville Syrjälä wrote: > On Fri, Dec 04, 2015 at 10:49:48AM +0200, Jani Nikula wrote: > > On Thu, 03 Dec 2015, Ville Syrjälä wrote: > > > On Thu, Dec 03, 2015 at 09:00:55PM +0100, Takashi Iwai wrote: > > >> Hi, > > >> > > >>

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Add reverse mapping between port and intel_encoder

On Fri, Dec 04, 2015 at 03:40:03PM +0100, Takashi Iwai wrote: > On Tue, 01 Dec 2015 17:09:53 +0100, > Takashi Iwai wrote: > > > > This patch adds a reverse mapping from a digital port number to > > intel_encoder object containing the corresponding intel_digital_port. > > It simplifies the query

Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Add reverse mapping between port and intel_encoder

On Fri, 04 Dec 2015 16:02:29 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 03:40:03PM +0100, Takashi Iwai wrote: > > On Tue, 01 Dec 2015 17:09:53 +0100, > > Takashi Iwai wrote: > > > > > > This patch adds a reverse mapping from a digital port number to > > > intel_encoder object

Re: [Intel-gfx] [PATCH] drm/i915: Enable PSR by default.

On Wed, Dec 02, 2015 at 08:08:30AM -0800, Rodrigo Vivi wrote: > With a reliable frontbuffer tracking and all instability corner cases > solved let's re-enabled PSR by default on all supported platforms. > > Signed-off-by: Rodrigo Vivi Hm, one thing we're missing here

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote: > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h > index 30d89e0da2c6..058d39e8d57f 100644 > --- a/include/drm/i915_component.h > +++ b/include/drm/i915_component.h > @@ -38,6 +38,7 @@ > *

[Intel-gfx] [PATCH v2 1/2] mm: Export nr_swap_pages

Some modules, like i915.ko, use swappable objects and may try to swap them out under memory pressure (via the shrinker). Before doing so, they want to check using get_nr_swap_pages() to see if any swap space is available as otherwise they will waste time purging the object from the device without

Re: [Intel-gfx] [PATCH] drm/i915: Clean up device info structure definitions

On Fri, Dec 04, 2015 at 11:24:39AM +0100, Daniel Vetter wrote: > On Wed, Dec 02, 2015 at 01:28:14PM -0800, Wayne Boyer wrote: > > Beginning with gen7, newer devices repetitively redefine values > > for the device info structure members. This patch simplifies the > > structure definitions by

Re: [Intel-gfx] [PATCH] drm/i915: Separate cherryview from valleyview

On Fri, Dec 04, 2015 at 04:05:54PM +0100, Daniel Vetter wrote: > On Wed, Dec 02, 2015 at 02:30:28PM +0200, Jani Nikula wrote: > > On Wed, 02 Dec 2015, Ville Syrjälä wrote: > > > On Tue, Dec 01, 2015 at 05:11:40PM -0800, Wayne Boyer wrote: > > >> The cherryview

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid writing relocs with addresses in non-canonical form

On Fri, Dec 04, 2015 at 04:20:43PM +0100, Michał Winiarski wrote: > According to bspec, some parts of HW expect the addresses to be in > a canonical form, where bits [63:48] == [47]. Let's convert addresses to > canonical form prior to relocating and return converted offsets to > userspace. > >

[Intel-gfx] [PATCH] drm/i915: Take care of ring->last_context on ctx destroy

If the context being destroyed have been last in the ring, the ring->last_context will be left dangling. Later, the unpinning will happen for last_context, and as it was already freed, we corrupt memory by doing so. This regression introduced in commit 6d65ba943a2d1e4292a07ca7ddb6c5138b9efa5d

[Intel-gfx] [PATCH v2 2/2] drm/i915: Disable shrinker for non-swapped backed objects

If the system has no available swap pages, we cannot make forward progress in the shrinker by releasing active pages, only by releasing purgeable pages which are immediately reaped. Take total_swap_pages into account when counting up available objects to be shrunk and subsequently shrinking them.

Re: [Intel-gfx] [PATCH v2 2/9] drm/i915: Add get_eld audio component

On Fri, 04 Dec 2015 16:54:32 +0100, Daniel Vetter wrote: > > On Fri, Dec 04, 2015 at 04:15:24PM +0100, Takashi Iwai wrote: > > diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h > > index 30d89e0da2c6..058d39e8d57f 100644 > > --- a/include/drm/i915_component.h > > +++

[Intel-gfx] [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping

A long time ago (before 3.14) we relied on a permanent pinning of the ifbdev to lock the fb in place inside the GGTT. However, the introduction of stealing the BIOS framebuffer and reusing its address in the GGTT for the fbdev has muddied waters and we use an inherited fb. However, the inherited

Re: [Intel-gfx] [PATCH] drm/i915: Enable GSE interrupt on BDW+

On Fri, 04 Dec 2015, Daniel Vetter wrote: > On Wed, Dec 02, 2015 at 12:17:10AM +0200, ville.syrj...@linux.intel.com wrote: >> From: Ville Syrjälä >> >> We've never actually enabled or unmasked the GSE interrupt on BDW+, >> even though the

  1   2   >