Hi Michał,
On Thu, 2020-06-25 at 21:23 +0200, Michał Winiarski wrote:
> Quoting Janusz Krzysztofik (2020-06-22 18:44:09)
> > Future subtests may want to access PCI attributes of the device after
> > driver unbind. Refactor prepare() helper.
> >
> > v2: rebase on u
Future subtests may want to access PCI attributes of the device after
driver unbind. Refactor prepare() helper.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 68 +-
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/tests
Check if this 3-step procedure exhibits any issues with device recover
after unplug. Such issues may indicate insufficient device hardware
re-initialization performed by the device driver, or other kernel bugs
outside the driver code.
Signed-off-by: Janusz Krzysztofik
---
tests
Verify if an additional address space associated with an open device
file descriptor is cleaned up correctly on device hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 32
1 file changed, 32 insertions(+)
diff --git a/tests
Even if all device file descriptors are closed on device hotunplug,
PRIME exported objects may still exists, referenced by still open
dma-buf file handles. Add a subtest that keeps such handle open on
device hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 36
on exercising the lateclose phase regardless of
potential rebind/re-plug issues under old names.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 57 +++---
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git a/tests/core_hotunplug.c b
The purpose of debug messages displayed by the test is to make
identification of a subtest phase that fails more easy. Since issues
exhibited by the test are mostly reported to dmesg, print those debug
messages to /dev/kmsg as well.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c
Verify if a device with a GEM batch job still running on a GPU can be
hot-unplugged cleanly and released, then recovered.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/core_hotunplug.c b
GEM objects belonging to user file descriptors still open on device
hotunplug may exhibit still more driver issues. Add a subtest that
implements this scenario.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 30 ++
1 file changed, 30 insertions
Add a bunch of new test variants, enhance debugging of hotunplug driver
issues.
Janusz Krzysztofik (8):
tests/core_hotunplug: Duplicate debug messages in dmesg
tests/core_hotunplug: Use PCI device sysfs entry, not DRM
tests/core_hotunplug: Add unbind-unplug-rescan variant
tests
on exercising the lateclose phase regardless of
potential rebind/re-plug issues under old names.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 57 +++---
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git
Even if all device file descriptors are closed on device hotunplug,
PRIME exported objects may still exists, referenced by still open
dma-buf file handles. Add a subtest that keeps such handle open on
device hotunplug.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
---
tests
GEM objects belonging to user file descriptors still open on device
hotunplug may exhibit still more driver issues. Add a subtest that
implements this scenario.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 30 ++
1 file
Verify if a device with a GEM batch job still running on a GPU can be
hot-unplugged cleanly and released, then recovered.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 34 ++
1 file changed, 34 insertions(+)
diff --git
The purpose of debug messages displayed by the test is to make
identification of a subtest phase that fails more easy. Since issues
exhibited by the test are mostly reported to dmesg, print those debug
messages to /dev/kmsg as well.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
Check if this 3-step procedure exhibits any issues with device recover
after unplug. Such issues may indicate insufficient device hardware
re-initialization performed by the device driver, or other kernel bugs
outside the driver code.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
Verify if an additional address space associated with an open device
file descriptor is cleaned up correctly on device hotunplug.
v2: rebase on upstream, update includes order
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 31 +++
1 file changed, 31
Future subtests may want to access PCI attributes of the device after
driver unbind. Refactor prepare() helper.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 68 +-
1 file changed, 40 insertions(+), 28 deletions
Add a bunch of new test variants, enhance debugging of hotunplug driver
issues.
v2: rebase on upstream
Janusz Krzysztofik (8):
tests/core_hotunplug: Duplicate debug messages in dmesg
tests/core_hotunplug: Use PCI device sysfs entry, not DRM
tests/core_hotunplug: Add unbind-unplug-rescan
Return values of driver bind/unbind / device remove/recover sysfs
operations are now ignored. Assert their correctness.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/tests/core_hotunplug.c b
been exited with the marker set.
Also, precede health check operations with a driver rebind or bus
rescan attempt as needed.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 107 +
1 file changed, 75 insertions(+), 32 deletions(-)
diff --git
Since we no longer open a device DRM sysfs node, only a PCI one, driver
unbind operations are no longer affected by missed or unsuccessful
sysfs file close attempts. Skip only affected subtests if that
happens.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 9 +
1 file
bodies.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index a4071f51e..557f9e3fa 100644
--- a/tests/core_hotunplug.c
+++ b/tests
' function accordingly.
A side benefit of using the PCI device sysfs node, not the DRM one,
while removing the device is that a future subtest may now easily
perform both driver unbind and device remove operations in a row.
Suggested-by: Michał Winiarski
Signed-off-by: Janusz Krzysztofik
---
tests
Since health checks are now run from follow-up fixture sections, it is
safe to fail subtests without the need to abort the test execution. Do
that on device close errors instead of emitting warnings.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 8
1 file changed, 4
Device bus address structure field is always initialized with a pointer
to a substring of the device sysfs path and never used for its
modification. Declare it as a constant string.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
and not test issues, I
believe.
Thanks,
Janusz
Janusz Krzysztofik (15):
tests/core_hotunplug: Use igt_assert_fd()
tests/core_hotunplug: Constify dev_bus_addr string
tests/core_hotunplug: Consolidate duplicated debug messages
tests/core_hotunplug: Assert successful device filter application
A trailing newline is missing from one of fatal error messages, fix it.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 6ceb325ad..cac88c2f3 100644
--- a/tests
.
For that to be possible, maintain a single instance of hotunplug
structure at igt_main level and pass it down to subtests.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 56 --
1 file changed, 26 insertions(+), 30 deletions(-)
diff --git a/tests
unplug operation
and a successful device health check, fail current test section right
after a device close error occurs, warn otherwise. If still running,
examine device file descriptor fields in subsequent igt_fixture
sections and skip on errors.
Signed-off-by: Janusz Krzysztofik
---
tests
There is a new library helper that asserts validity of open file
descriptors. Use it instead of open coding.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests
Some return values are not useful and can be ignored. Wrap those cases
inside igt_ignore_warn(), not only to make sure compilers are happy but
also to clearly document our decisions.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 6 +++---
1 file changed, 3 insertions(+), 3
A pointer to fatal error messages can be passed around via hotunplug
structure, no need to declare it as global.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 92 +-
1 file changed, 45 insertions(+), 47 deletions(-)
diff --git a/tests
Don't rely on successful write to sysfs control files, assert existence
/ non-existence of a respective device sysfs node as well.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/core_hotunplug.c b/tests
Return value of igt_device_filter_add() representing a number of
successfully installed device filters is now ignored. Fail if not 1.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/core_hotunplug.c b/tests
On Mon, 2020-12-07 at 15:09 +0200, Petri Latvala wrote:
> On Fri, Dec 04, 2020 at 08:50:07PM +0100, Janusz Krzysztofik wrote:
> > We may still be interested in results of a test even if it has tainted
> > the kernel. On the other hand, we need to kill the test on taint if no
the taint is detected instead of
aborting immediately. However, report the taint as the reason of the
abort if a timeout decreased by the taint expires.
v2: Fix missing show_kernel_task_state() lost on rebase conflict
resolution (Chris - thanks!)
Signed-off-by: Janusz Krzysztofik
On Fri, 2020-12-04 at 12:06 +, Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2020-12-04 11:51:38)
> > We may still be interested in results of a test even if it has tainted
> > the kernel. On the other hand, we need to kill the test on taint if no
> > other means o
Submitted with incorrect address of i915 list out of top of my head in
Cc:, sorry.
Janusz
On Fri, 2020-12-04 at 12:51 +0100, Janusz Krzysztofik wrote:
> We may still be interested in results of a test even if it has tainted
> the kernel. On the other hand, we need to kill the test on
On Tue, 2021-01-19 at 12:08 +0100, Marcin Bernatowicz wrote:
> On Tue, 2021-01-19 at 09:42 +0100, Janusz Krzysztofik wrote:
> > Since igt_fixture sections are processed unconditionally regardless
> > of
> > which subtest has been requested, they can now emit a lot of
&g
is started. In order to let that subtest skip on
unsuccessful initial health check, not fail, move the decision whether
to fail or skip on error from the health check helper to its users.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 86 +++---
1
assert that
the flush was called and nothing added more in between (suggested by
Chris).
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 --
2 files changed, 2 insertions(+), 2
Hi Tvrtko,
On poniedziałek, 10 maja 2021 11:14:46 CEST Tvrtko Ursulin wrote:
>
> On 07/05/2021 15:42, Janusz Krzysztofik wrote:
> > Commit fb5970da1b42 ("drm/i915/gt: Use the kernel_context to measure the
> > breadcrumb size") reordered some operations inside engine
or
was put, but the context, pinned when created, was not unpinned first.
Fix it by replacing intel_context_put() with destroy_pinned_context()
introduced later by commit b436a5f8b6c8 ("drm/i915/gt: Track all timelines
created using the HWSP").
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wils
, consequently spell out error paths,
add a comment on convertion of renderD* to cardX (Lionel).
v4: Limit primary lookup to minors <64 (Chris)
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Lionel Landwerlin # v3
Cc: Chris Wilson
---
lib/i915/perf.c |
Hi Jani,
On Mon, 3 May 2021 19:38:17 CEST Jani Nikula wrote:
> On Thu, 29 Apr 2021, Janusz Krzysztofik
wrote:
> > Commit 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info")
> > effectively changed our FB driver name from "inteldrmfb" to
> > "i9
Hi,
On poniedziałek, 3 maja 2021 19:38:17 CEST Jani Nikula wrote:
> On Thu, 29 Apr 2021, Janusz Krzysztofik
wrote:
> > Commit 7a0f9ef9703d ("drm/i915: Use drm_fb_helper_fill_info")
> > effectively changed our FB driver name from "inteldrmfb" to
> >
to its associated fbdev driver name.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 785dcf20c77b..46082490dc9a 100644
--- a/drivers
On piątek, 30 kwietnia 2021 01:01:38 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Fix wrong name announced on FB driver switching
> URL : https://patchwork.freedesktop.org/series/89663/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_10027_full
.
Instead of forcibly using DRM device minor number 0 when opening a
device sysfs area, convert device minor number of a user passed device
fd to the minor number of respective primary (cardX) device node.
Signed-off-by: Janusz Krzysztofik
---
lib/i915/perf.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi Lionel,
On poniedziałek, 3 maja 2021 09:07:09 CEST Lionel Landwerlin wrote:
> On 30/04/2021 19:18, Janusz Krzysztofik wrote:
> > IGT i915/perf library functions now always operate on sysfs perf
> > attributes of card0 device node, no matter which DRM device fd a user
> > p
.
If a user passed a render device node fd, find a primary device node of
the same device and use it instead of forcibly using the primary device
with minor number 0 when opening the device sysfs area.
v2: Don't assume primary minor matches render minor with masked type.
Signed-off-by: Janusz Krzysztofik
, consequently spell out error paths,
add a comment on convertion of renderD* to cardX (Lionel).
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Lionel Landwerlin
---
lib/i915/perf.c | 35 ---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/lib
Verify if an additional context associated with an open device file
descriptor is cleaned up correctly on device hotunbind / hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 79 ++
1 file changed, 79 insertions(+)
diff --git
Verify if an additional address space associated with an open device
file descriptor is cleaned up correctly on device hotunbind / hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 79 ++
1 file changed, 79 insertions(+)
diff
GEM objects belonging to user file descriptors still open on device
hotunbind / hotunplug may exhibit still more driver issues. Add
subtests that implements these scenarios.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 85 ++
1 file
Even if all device file descriptors are closed on device hotunbind /
hotunplug, PRIME exported objects may still exists, referenced by still
open dma-buf file descriptors. Add subtests that keep such descriptor
open on device hotunbind / hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests
Verify if userptr GM objects are cleaned up equally well as regular
GEM objects on device hotunbind / hotunplug.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/tests/core_hotunplug.c b
Verify if a device with a GEM spin batch job still running on a GPU can
be hot-unbound/unplugged cleanly and released.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 124 +
1 file changed, 124 insertions(+)
diff --git a/tests
On czwartek, 8 kwietnia 2021 16:50:45 CEST Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [RFC,1/2] tests/core_hotunplug: Add perf health
> check
> URL : https://patchwork.freedesktop.org/series/88848/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes
ith a negative "mmap-offset-banned" that fails if a
mmap-offset attempt to a userptr object doesn't return ENODEV. Also,
remove mmap-offset to userptr dependent processing paths from other
subtest bodies and drop obsolete subtest variants.
Signed-off-by: Janusz Krzysztofik
---
tests/
Sorry for double submission, I had to resend due to a typo in igt-dev list
address.
Janusz
On czwartek, 8 kwietnia 2021 10:30:08 CEST Janusz Krzysztofik wrote:
> Sometimes CI reports skips of perf subtests when run subsequently after
> core_hotunplug. That may be an indication of
-subtest device recovery
step restores the device perf support so no subsequently executed tests
are affected.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 22 ++
tests/meson.build | 8 +++-
2 files changed, 29 insertions(+), 1 deletion(-)
diff
*hot*bind* subtests from CI
blocklist.
[*] https://gitlab.freedesktop.org/drm/intel/-/issues/2644.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist
-subtest device recovery
step restores the device perf support so no subsequently executed tests
are affected.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 22 ++
tests/meson.build | 8 +++-
2 files changed, 29 insertions(+), 1 deletion(-)
diff
*hot*bind* subtests from CI
blocklist.
[*] https://gitlab.freedesktop.org/drm/intel/-/issues/2644.
Signed-off-by: Janusz Krzysztofik
---
tests/intel-ci/blacklist.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist
On środa, 14 kwietnia 2021 11:50:10 CEST Marcin Bernatowicz wrote:
> On Thu, 2021-04-08 at 10:31 +0200, Janusz Krzysztofik wrote:
> > Sometimes CI reports skips of perf subtests when run subsequently
> > after
> > core_hotunplug. That may be an indication of issues with rest
On czwartek, 15 kwietnia 2021 11:47:29 CEST Marcin Bernatowicz wrote:
> On Fri, 2021-04-09 at 10:57 +0200, Janusz Krzysztofik wrote:
> > Support for mmap-offset to userptr has been obsoleted, then related
> > lockdep splat reported issues are not going to be resolved other than
&g
__intel_gt_disable() proved to break some driver probe error unwind
paths as well as mock selftest exit path.
Signed-off-by: Janusz Krzysztofik
Cc: Michał Winiarski
---
drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt
that the flush was called and nothing added
more in between.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
that the flush was called and
nothing added more in between.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
Resending with Cc: dri-de...@lists.freedesktop.org as requested, and a
typo in commit description fixed.
Thanks,
Janusz
drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++
drivers
__intel_gt_disable() proved to break some driver probe error unwind
paths as well as mock selftest exit path.
Signed-off-by: Janusz Krzysztofik
Cc: Michał Winiarski
---
Resending with Cc: dri-de...@lists.freedesktop.org as requested.
Thanks,
Janusz
drivers/gpu/drm/i915/gt/intel_gt.c | 2 +-
1
On piątek, 3 września 2021 21:07:00 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Mark GPU wedging on driver unregister unrecoverable (rev2)
> URL : https://patchwork.freedesktop.org/series/94247/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from
Hi Matt,
Thanks for review.
On czwartek, 23 września 2021 00:24:29 CEST Matt Roper wrote:
> On Fri, Sep 03, 2021 at 04:23:20PM +0200, Janusz Krzysztofik wrote:
> > In preparation for clean driver release, attempts to drain work queues
> > and release freed objects are taken at dri
objects so they are released before
_any_ code in drm_driver.release() that check completness of those
flushes executes.
v2: Reword commit descriptiom as suggested by Matt.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
Cc: Matt Roper
---
drivers/gpu/drm/i915/gt/intel_gt.c | 2
On Friday, 26 November 2021 09:00:06 CET Bernatowicz, Marcin wrote:
>
> On 11/18/2021 9:41 AM, Janusz Krzysztofik wrote:
> > Strange -ENODEV responses from the kernel to i915 driver rebind attempts
> > have been sporadically observed. After successfully unbinding the driver
with the device PCI bus address string it uses also printed.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index b36616688..2f2fb7ac1 100644
--- a/tests
ion status,
- shorten warning messages (Kamil),
- don't fill .mmio_size field until initialization succeeds (Kamil)
Signed-off-by: Janusz Krzysztofik
Cc: Kamil Konieczny
---
lib/intel_io.h | 4 +++
lib/intel_mmio.c | 64 +---
2 files changed, 65 insert
Hi Kamil,
Thanks for review.
On Friday, 4 March 2022 16:14:05 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> Dnia 2022-03-01 at 15:07:55 +0100, Janusz Krzysztofik napisał(a):
> > Commit 5f3cfa485eb4 ("lib: Use safe wrappers around libpciaccess
> > initializa
Hi Kamil,
On Monday, 7 March 2022 14:23:30 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> Dnia 2022-03-07 at 09:26:43 +0100, Janusz Krzysztofik napisał(a):
> > Commit 5f3cfa485eb4 ("lib: Use safe wrappers around libpciaccess
> > initialization functions") took care
ion status,
- shorten warning messages (Kamil),
- don't fill .mmio_size field until initialization succeeds (Kamil)
v4: fix condition of forcewake release, broken in v3,
- improve comments and warning messages (Kamil)
Signed-off-by: Janusz Krzysztofik
Cc: Kamil Konieczny
---
lib/intel_io.h |
to public
functions intel_mmio_use_pci_bar() and intel_mmio_use_dump_file().
Signed-off-by: Janusz Krzysztofik
---
lib/intel_io.h | 4 +++
lib/intel_mmio.c | 65 ++--
2 files changed, 62 insertions(+), 7 deletions(-)
diff --git a/lib/intel_io.h b/lib/
by pci_system_init().
Introduce safe IGT wrappers around those libpciaccess functions and use
those wrappers in IGT library and tests.
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
lib/igt_core.c | 20
lib/igt_core.h | 28
lib
-by: Janusz Krzysztofik
Cc: Chris Wilson
---
lib/igt_device.c | 34 --
lib/igt_device.h | 1 +
2 files changed, 29 insertions(+), 6 deletions(-)
diff --git a/lib/igt_device.c b/lib/igt_device.c
index c50bf4a1f7..1603bf351c 100644
--- a/lib/igt_device.c
+++ b/lib
numbering convention of Linux PCI ABI (Chris),
- fix and improve DOC.
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Chris Wilson # v2
---
lib/igt_device.c | 33 +++--
lib/igt_device.h | 1 +
2 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/lib
to public
functions intel_mmio_use_pci_bar() and intel_mmio_use_dump_file().
v2: apply last minute fixes, cached but unfortunately not committed before
sending
Signed-off-by: Janusz Krzysztofik
---
lib/intel_io.h | 4 +++
lib/intel_mmio.c | 67 ++-
Hi Michał,
Thanks for review.
On Tuesday, 22 February 2022 17:16:54 CET Michal Wajdeczko wrote:
>
> On 22.02.2022 16:11, Janusz Krzysztofik wrote:
> > The library provides igt_device_get_pci_device() function that allows to
> > get access to a PCI device from an open DRM devi
pci_system_cleanup() not called on errors and
instruct users to call it for symmetry when the obtained struct pci_device
is no longer needed.
Signed-off-by: Janusz Krzysztofik
---
lib/igt_device.c | 44
lib/igt_device.h | 1 +
2 files changed, 37 insertions
Hi Chris,
On Friday, 18 February 2022 17:03:01 CET Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2022-02-18 15:19:35)
> > @@ -206,15 +229,19 @@ static struct pci_device
> > *__igt_device_get_pci_device(int fd)
> > igt_warn("Couldn't find PCI de
On Wednesday, 30 August 2023 11:23:43 CEST David Gow wrote:
> On Wed, 30 Aug 2023 at 15:55, Janusz Krzysztofik
> wrote:
> >
> > Now we have memory space available to a kunit test case log exposed via
> > debugfs limited to 2048 bytes, while some para
Hi Mauro,
Thanks for review.
On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wrote:
> On Fri, 8 Sep 2023 14:32:39 +0200
> Janusz Krzysztofik wrote:
>
> > In a body of a subtest with dynamic sub-subtests, it is illegal to call
> > igt_fail() and its
t;= start) is
triggered. Fix it by restoring the original value.
Fixes: fc8d29e298cf ("drm: selftest: convert drm_mm selftest to KUnit")
Signed-off-by: Janusz Krzysztofik
Cc: "Maíra Canal"
Cc: Arthur Grillo
Cc: Javier Martinez Canillas
Cc: Daniel Latypov
Cc: sta...@vger.ke
Hi Mauro,
On Friday, 15 September 2023 14:28:49 CEST Mauro Carvalho Chehab wrote:
> On Fri, 8 Sep 2023 14:32:47 +0200
> Janusz Krzysztofik wrote:
>
> Forgot to mention on my past review:
>
> > + , ) == 1
Hi Maíra,
Thanks for review.
On Friday, 15 September 2023 16:01:31 CEST Maira Canal wrote:
> Hi,
>
> On 9/11/23 10:03, Janusz Krzysztofik wrote:
> > While drm_mm test was converted form igt selftest to kunit, unexpected
> > value of "end" argument equal "s
On Friday, 15 September 2023 15:09:58 CEST Janusz Krzysztofik wrote:
> Hi Mauro,
>
> On Friday, 15 September 2023 14:28:49 CEST Mauro Carvalho Chehab wrote:
> > On Fri, 8 Sep 2023 14:32:47 +0200
> > Janusz Krzysztofik wrote:
> >
> > Fo
On Friday, 15 September 2023 14:25:24 CEST Mauro Carvalho Chehab wrote:
> On Wed, 13 Sep 2023 16:04:10 +0200
> Janusz Krzysztofik wrote:
>
> > On Monday, 11 September 2023 11:01:42 CEST Mauro Carvalho Chehab wrote:
> > > On Fri, 8 Sep 2023 14:32:41 +0200
> &g
On Monday, 11 September 2023 11:01:42 CEST Mauro Carvalho Chehab wrote:
> On Fri, 8 Sep 2023 14:32:41 +0200
> Janusz Krzysztofik wrote:
>
> > While reading KTAP data from /dev/kmsg we now ignore interrupt signals
> > that may occur during read() and we cont
On Monday, 11 September 2023 13:57:29 CEST Mauro Carvalho Chehab wrote:
> On Mon, 11 Sep 2023 11:28:32 +0200
> Janusz Krzysztofik wrote:
>
> > Hi Mauro,
> >
> > Thanks for review.
> >
> > On Monday, 11 September 2023 10:52:51 CEST Mauro Carvalho Chehab wr
tools that rely on parsing of debugfs results can fail.
Increase kunit test case log size limit to 4096 bytes.
Signed-off-by: Janusz Krzysztofik
---
include/kunit/test.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/kunit/test.h b/include/kunit/test.h
index
Janusz Krzysztofik (17):
lib/kunit: Drop unused file stream
lib/kunit: Stop loading kunit module explicitly
lib/kunit: Fix struct kmod_module kunit_kmod not freed
lib/kunit: Optimize calls to igt_success/skip/fail()
lib/kunit: Fix illegal igt_fail() calls inside subtest body
lib/ktap
401 - 500 of 845 matches
Mail list logo
