CPU1
<4> [437.542719]
<4> [437.542721] lock(fs_reclaim);
<4> [437.542725] lock(acpi_device_lock);
<4> [437.542728]lock(fs_reclaim);
<4> [437.542732] lock(a
://gitlab.freedesktop.org/drm/intel/-/issues/6449
Fixes: 178a30c90ac7 ("drm/i915: Unbind objects in shrinker only if device is
runtime active")
Signed-off-by: Chris Wilson
Cc: Thomas Hellström
Cc: Matthew Auld
Cc: Tvrtko Ursulin
Cc: sta...@vger.kernel.org # v4.8+
Signed-off-by: Janusz Krzysztofik
--
Hi Matthew,
Thanks for review.
On Tuesday, 26 July 2022 20:14:05 CEST Matthew Auld wrote:
> On 20/07/2022 11:16, Janusz Krzysztofik wrote:
> > From: Chris Wilson
> >
> > Inside the shrinker, we cannot wake the device as that may cause
> > recursion into fs-reclaim
Hi Mauro,
Thanks for reviewing this series, I've just pushed it.
On Wednesday, 17 August 2022 14:53:48 CEST Mauro Carvalho Chehab wrote:
> Hi Janusz,
>
> On Fri, 12 Aug 2022 11:53:44 +0200
> Janusz Krzysztofik wrote:
>
> It seems that there is a numeration issue on this seri
On Wednesday, 28 September 2022 11:22:21 CEST Tvrtko Ursulin wrote:
>
> On 28/09/2022 09:58, Janusz Krzysztofik wrote:
> > Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to
> > flush rcaches"). It is trying to instantiate a cpuhp notifier from
+0x3c1/0x900
<4>[6.961106] ? dev_set_name+0x4e/0x70
<4>[6.961109] platform_device_add+0x108/0x240
<4>[6.961112] coretemp_cpu_online+0xe1/0x15e [coretemp]
<4>[6.961117] ? create_core_data+0x550/0x550 [coretemp]
<4>[6.961120] cpuhp_invoke_callback+
This reverts commit bc79ef6d5a223ea59acf874f0493b79c835b17d4 that
reverted commit ac9a5d522bb80be50ea84965699e1c8257d745ce. That revert is
no longer needed with "iommu: Remove iova cpu hotplugging flushing" in
place that breaks more instances of the same lockdep loop.
Signed-off-
tter in place.
Note: I'm no longer CCing IOMMU nor mainstream, they have been already
warned.
Chris Wilson (1):
iommu: Remove iova cpu hotplugging flushing
Janusz Krzysztofik (1):
Restore "iommu/dma: Fix race condition during iova_domain
initialization"
d
Hi Robin,
On Wednesday, 14 September 2022 17:54:36 CEST Robin Murphy wrote:
> On 2022-09-14 16:01, Lucas De Marchi wrote:
> > On Wed, Sep 14, 2022 at 02:40:45PM +0200, Karolina Drobnik wrote:
> >> This reverts commit ac9a5d522bb80be50ea84965699e1c8257d745ce.
> >>
> >> This change introduces a
On Wednesday, 14 September 2022 17:15:02 CEST Andi Shyti wrote:
> Hi Krzysztofik,
>
> if you are going to resend it, I just have a little thing if you
> don't mind,
>
> On Tue, Sep 13, 2022 at 06:10:39PM +0200, Janusz Krzysztofik wrote:
> > From: Chris Wilson
&g
Hi Tvrtko,
Thanks for review.
On Wednesday, 14 September 2022 17:37:19 CEST Tvrtko Ursulin wrote:
>
> On 13/09/2022 17:10, Janusz Krzysztofik wrote:
> > From: Chris Wilson
> >
> > i915_perf assumes that it can use the i915_gem_context reference to
> > prote
On Friday, 16 September 2022 17:12:30 CEST Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gem: Really move i915_gem_context.link under ref protection
> (rev4)
> URL : https://patchwork.freedesktop.org/series/105975/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes
se == NULL' and so will leak any of the
> common objects allocated.
>
> Signed-off-by: Chris Wilson
> Cc: Janusz Krzysztofik
> Signed-off-by: Matt Roper
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 16 +---
> 1 file changed, 13 insertions(+), 3 dele
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
drivers/gpu/drm/
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andi S
gned-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_ge
+0x3c1/0x900
<4>[6.961106] ? dev_set_name+0x4e/0x70
<4>[6.961109] platform_device_add+0x108/0x240
<4>[6.961112] coretemp_cpu_online+0xe1/0x15e [coretemp]
<4>[6.961117] ? create_core_data+0x550/0x550 [coretemp]
<4>[6.961120] cpuhp_invoke_callback+
On Thursday, 22 September 2022 14:09:35 CEST Robin Murphy wrote:
> On 22/09/2022 11:10 am, Janusz Krzysztofik wrote:
> > From: Chris Wilson
> >
> > Manual revert of commit f598a497bc7d ("iova: Add CPU hotplug handler to
> > flush rcaches"). It is trying
On Thursday, 22 September 2022 12:50:05 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12166 ->
Please ignore this series, it has issues. I'll update it and resubmit.
Thanks,
Janusz
On Thursday, 15 September 2022 18:52:08 CEST Janusz Krzysztofik wrote:
> i915_perf assumes that it can use the i915_gem_context reference to
> protect its i915->gem.contexts.list iteration
e
the same.
Since we care for other platforms using this test and contributing to it,
not developing their own, keep i915 workarounds limited to i915 devices.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 58 +++---
1 file changed, 32 inserti
Since we pass NULL to igt_audio_driver_unload(), realloc() it calls
allocates new memory for us. Free it each time we no longer need it,
before dropping a pointer to it, to avoid memory leaking.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 1 +
1 file changed, 1 insertion
uffer from issues related to an audio driver using i915 hardware. Fix it
by adding a copy of the workaround in its current shape also to
device_unplug() / bus_rescan() pair of functions.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 22 ++
1 file changed, 22
result in using different set of
health checks should device filters not work as expected.
Always use the stored chipset type instead of identifying it now and
again.
Signed-off-by: Janusz Krzysztofik
---
tests/core_hotunplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
Janusz Krzysztofik (4):
tests/core_hotunplug: Free mem allocated by igt_audio_driver_unload
tests/core_hotunplug: Also unload audio before device unplug
tests/core_hotunplug: Don't apply i915 workarounds on other platforms
tests/core_hotunplug: Select health checks for initially detected
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andi S
d9a9 ("drm/i915/gem: Drop free_work for GEM contexts")
Signed-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
1 file changed, 4 insert
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 8
drivers/gpu/drm/
' and so will leak any of the
> common objects allocated.
>
> v2:
> - Drop the destroy_pinned_context() helper for now. It's not really
>worth it with just a single callsite at the moment. (Janusz)
>
> Signed-off-by: Chris Wilson
> Cc: Janusz Krzysztofik
> Si
.
Unfortunately, it is not flushed on driver release. Fix it.
Chris Wilson (1):
drm/i915/gem: Really move i915_gem_context.link under ref protection
Janusz Krzysztofik (1):
drm/i915/gem: Flush contexts on driver release
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++---
drive
15/gem: Drop free_work for GEM contexts")
Signed-off-by: Chris Wilson
Reviewed-by: Andi Shyti
Signed-off-by: Andi Shyti
Signed-off-by: Janusz Krzysztofik
Cc: Tvrtko Ursulin
Cc: # v5.12+
---
drivers/gpu/drm/i915/gem/i915_gem_context.c | 14 +++---
drivers/gpu/d
per around it, replace last call to
i915_gem_drain_freed_objects() with existing i915_gem_drain_workqueue()
that performs both tasks.
Fixes: 75eefd82581f ("drm/i915: Release i915_gem_context from a worker")
Suggested-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Cc: sta...@kerne
On Thursday, 22 September 2022 21:18:51 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12166_full ->
On Thursday, 29 September 2022 11:35:23 CEST Patchwork wrote:
> == Series Details ==
>
> Series: iommu: Remove iova cpu hotplugging flushing (rev2)
> URL : https://patchwork.freedesktop.org/series/108880/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12193_full ->
I think this issue can hit any user with a platform that loads iommu and
coretemp drivers. Adding regressi...@lists.linux.dev to the loop.
Thanks,
Janusz
On Thursday, 22 September 2022 14:09:35 CEST Robin Murphy wrote:
> On 22/09/2022 11:10 am, Janusz Krzysztofik wrote:
> > From: Chr
t in place, the test is able to check synchronously if execution
of dependent test batches is still blocked on the not yet signaled fence
of the not yet completed spin batch, as it does in counterpart non-hanging
scenarios.
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_exec_fe
When i == 0, condition out[i] == i will be true even if a batch supposed
to store i in out[i] fails. Don't use 0.
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_exec_fence.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/i915/gem_exec_fence.c b
it.
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_exec_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 7ff7614dad..048870053a 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_f
t in place, the test is able to check synchronously if execution
of dependent test batches is still blocked on the not yet signaled fence
of the not yet completed spin batch, as it does in counterpart non-hanging
scenarios.
v2: preserve checking the pipeline runs ahead of the hang (Chris)
Signed-off-
When i = 0, condition out[i] == i will be true even if a batch supposed
to store i in out[i] fails. Don't use i = 0 in batches that store values
in out[i].
v2: still check for out[0] == 0 (Chris)
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_exec_fence.c | 13 -
1 file
it.
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_exec_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 7ff7614dad..048870053a 100644
--- a/tests/i915/gem_exec_fence.c
+++ b/tests/i915/gem_exec_f
runs ahead of the hang (Chris)
v3: use a more simple 'best effort' approach suggested by Chris
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
Cc: Mauro Carvalho Chehab
---
tests/i915/gem_exec_fence.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/
it.
Signed-off-by: Janusz Krzysztofik
Cc: Mauro Carvalho Chehab
---
tests/i915/gem_exec_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
index 7ff7614dad..048870053a 100644
--- a/tests/i915/gem_exec_fence.c
When i = 0, condition out[i] == i will be true even if a batch supposed
to store i in out[i] fails. Don't use i = 0 in batches that store values
in out[i].
v2: still check for out[0] == 0 (Chris)
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
Cc: Mauro Carvalho Chehab
---
tests/i915
On Wednesday, 23 November 2022 13:57:26 CET Tvrtko Ursulin wrote:
>
> On 23/11/2022 09:28, Janusz Krzysztofik wrote:
> > Hi Tvrtko,
> >
> > Thanks for your comments.
> >
> > On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote:
> >>
>
On Wednesday, 16 November 2022 15:42:46 CET Andrzej Hajda wrote:
> On 16.11.2022 12:25, Janusz Krzysztofik wrote:
> > According to the docs of i915_request_wait_timeout(), its return value
> > "may be zero if the request is unfinished after the timeout expires."
> &
7060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/i
the timeout value as return
code, so -ETIME is returned if there are still some requests not retired
after timeout, 0 otherwise.
v2: Move the added lines down so flush_submission() is not affected.
Fixes: f33a8a51602c ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-
() is not affected,
reword commit message and description.
PATCH 3: drop -- controversial, not needed.
Janusz Krzysztofik (2):
drm/i915: Fix negative value passed as remaining time
drm/i915: Never return 0 if not all requests retired
drivers/gpu/drm/i915/gt/intel_gt.c | 11
d back via remaining_timeout.
v2: Fix the issue on the caller side, not the provider.
Fixes: b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt.c | 9 +
.
Janusz Krzysztofik (2):
drm/i915: Fix negative value passed as remaining time
drm/i915: Never return 0 if not all requests retired
drivers/gpu/drm/i915/gt/intel_gt.c | 9 +++--
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
2 files changed, 8 insertions(+), 3 deletions
() is not affected.
Fixes: f33a8a51602c ("drm/i915: Merge wait_for_timelines with retire_request")
Signed-off-by: Janusz Krzysztofik
Reviewed-by: Andrzej Hajda
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi Andrzej,
Thanks for your comment.
On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote:
>
> On 21.11.2022 09:30, Janusz Krzysztofik wrote:
> > Hi Nimroy,
> >
> > Thanks for looking at this.
> >
> > On Friday, 18 November 2022 20:56:50 CET Das, Ni
On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote:
> Hi Andrzej,
>
> Thanks for your comment.
>
> On Monday, 21 November 2022 11:17:42 CET Andrzej Hajda wrote:
> >
> > On 21.11.2022 09:30, Janusz Krzysztofik wrote:
> > > Hi Ni
On Friday, 18 November 2022 11:42:21 CET Janusz Krzysztofik wrote:
> Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work
> with GuC") extended the API of intel_gt_retire_requests_timeout() with an
> extra argument 'remaining_timeout', intended for pass
Hi Nimroy,
Thanks for looking at this.
On Friday, 18 November 2022 20:56:50 CET Das, Nirmoy wrote:
>
> On 11/18/2022 11:42 AM, Janusz Krzysztofik wrote:
> > Users of intel_gt_retire_requests_timeout() expect 0 return value on
> > success. However, we have no protection f
this series and individual patches as v2.
Janusz Krzysztofik (3):
drm/i915: Fix negative remaining time after retire requests
drm/i915: Never return 0 on timeout when retiring requests
drm/i915: Never return 0 if request wait succeeds
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 26
ot;drm/i915/guc: Update intel_gt_wait_for_idle to work with
GuC")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.15+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 23 ++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/dri
Merge wait_for_timelines with retire_request")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c
b/drivers/gpu/drm/i915/gt/intel_gt_
he timeout is 0, it will return 1 if the
fence is signaled.", return 1 also when the fence is found signaled after
non-zero timeout has expired.
Fixes: 7e2e69ed4678 ("drm/i915: Fix i915_request fence wait semantics")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v
Hajda wrote:
> On 21.11.2022 11:59, Janusz Krzysztofik wrote:
> > On Monday, 21 November 2022 11:51:15 CET Janusz Krzysztofik wrote:
> >> Hi Andrzej,
> >>
> >> Thanks for your comment.
> >>
> >> On Monday, 21 November 2022 11:17:42 CET Andrze
Hi Andrzej,
Thanks for providing your R-b.
On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote:
> On 21.11.2022 15:56, Janusz Krzysztofik wrote:
> > Commit b97060a99b01 ("drm/i915/guc: Update intel_gt_wait_for_idle to work
> > with Gu
Hi Tvrtko,
Thanks for your comments.
On Tuesday, 22 November 2022 11:50:38 CET Tvrtko Ursulin wrote:
>
> On 21/11/2022 14:56, Janusz Krzysztofik wrote:
> > Users of intel_gt_retire_requests_timeout() expect 0 return value on
> > success. However, we have no protection f
On Tuesday, 22 November 2022 11:41:29 CET Tvrtko Ursulin wrote:
>
> On 21/11/2022 23:19, Janusz Krzysztofik wrote:
> > Hi Andrzej,
> >
> > Thanks for providing your R-b.
> >
> > On Monday, 21 November 2022 18:40:51 CET Andrzej Hajda wrote:
> >>
existing
contexts
Janusz Krzysztofik (1):
tests/i915/perf: Exercise barrier race
tests/i915/perf.c | 111 ++
1 file changed, 111 insertions(+)
--
2.25.1
-by: Chris Wilson
Signed-off-by: Janusz Krzysztofik
Cc: Andi Shyti
---
tests/i915/perf.c | 74 +++
1 file changed, 74 insertions(+)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index dd1f1ac399..e33cacc443 100644
--- a/tests/i915/perf.c
+++ b/tests
/-/issues/6333
Signed-off-by: Janusz Krzysztofik
Cc: Chris Wilson
---
tests/i915/perf.c | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index e33cacc443..11a3ec21ab 100644
--- a/tests/i915/perf.c
On Wednesday, 9 November 2022 20:09:34 CET Janusz Krzysztofik wrote:
> Fixes for issues discovered via code review while working on
> https://gitlab.freedesktop.org/drm/intel/issues/7349.
>
> Janusz Krzysztofik (3):
> drm/i915: Fix timeout handling when retiring requests
&g
was intended.
Fix it by replacing -ETIME value of the argument with 0.
Fixes: 09137e945437 ("drm/i915/gem: Unpin idle contexts from kswapd reclaim")
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
uccess, don't touch it, update the i915_fence_wait() wrapper
instead. Return 1 instead of 0, but keep -ETIME in case of timeout since
some i915 users of dma_fence_wait_timeout() may expect it.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
1 file changed, 1 ins
Fixes for issues discovered via code review while working on
https://gitlab.freedesktop.org/drm/intel/issues/7349.
Janusz Krzysztofik (3):
drm/i915: Fix timeout handling when retiring requests
drm/i915: Fix unintended submission flush after retire times out
drm/i915: Fix 0 return value from
lines with retire_request")
Signed-off-by: Janusz Krzysztofik
Cc: sta...@vger.kernel.org # v5.5+
---
drivers/gpu/drm/i915/gt/intel_gt_requests.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_requests.c
b/drivers/gpu/d
A comma is missing, fix it.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_vma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 3b969d679c1e2..947fde68e5f53 100644
--- a/drivers/gpu/drm
Hi Kamil,
Thanks for review.
On Tuesday, 31 January 2023 12:59:10 CET Kamil Konieczny wrote:
...
> > @@ -5259,6 +5324,15 @@ igt_main
> > igt_subtest("whitelisted-registers-userspace-config")
> > test_whitelisted_registers_userspace_config();
> >
>
> Please add description to
On Tuesday, 31 January 2023 17:55:54 CET Dixit, Ashutosh wrote:
> On Tue, 31 Jan 2023 08:19:48 -0800, Dixit, Ashutosh wrote:
> >
> > On Tue, 31 Jan 2023 01:17:29 -0800, Janusz Krzysztofik wrote:
> > >
> >
> > Hi Janusz,
> >
> > > Users repor
On Tuesday, 31 January 2023 17:19:48 CET Dixit, Ashutosh wrote:
> On Tue, 31 Jan 2023 01:17:29 -0800, Janusz Krzysztofik wrote:
> >
>
> Hi Janusz,
>
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurrently running graphics
Hi Kamil,
On Wednesday, 1 February 2023 19:21:57 CET Kamil Konieczny wrote:
> Hi Janusz,
>
> please send patches to igt ML and add other addresses to cc:
> I have one nit, see below.
>
> On 2023-01-31 at 10:17:31 +0100, Janusz Krzysztofik wrote:
> > Add a new subte
Hi Nirmoy,
On Friday, 10 March 2023 15:11:38 CET Nirmoy Das wrote:
> debug_active_activate() expected ref->count to be zero
> which is not true anymore as __i915_active_activate() calls
> debug_active_activate() after incrementing the count.
>
> Fixes: 04240e30ed06 ("drm/i915: Skip taking
r "ref->count == 1" as __i915_active_activate()
> already make sure of that.
>
> Fixes: 04240e30ed06 ("drm/i915: Skip taking acquire mutex for no ref->active
> callback")
> Cc: Chris Wilson
> Cc: Tvrtko Ursulin
> Cc: Thomas Hellström
> Cc: Andi Shyti
> Cc: i
On Friday, 10 March 2023 17:48:10 CET Das, Nirmoy wrote:
> Hi Janusz,
>
> On 3/10/2023 4:19 PM, Janusz Krzysztofik wrote:
> > Hi Nirmoy,
> >
> > On Friday, 10 March 2023 15:11:38 CET Nirmoy Das wrote:
> >> debug_active_activate() expected ref->count to
it with
collected proto-barriers (assuming we need that check).
Fixes: 9ff33bbcda25 ("drm/i915: Reduce locking around
i915_active_acquire_preallocate_barrier()")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.10+
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_act
lf")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.6+
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_active.c | 65 --
1 file changed, 44 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i915/i91
a link between list
nodes that precede and follow the deleted node.
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_active.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i915/i915_active.c
index
starting from v5.10. The third patch, while not fixing any real
bug, is believed to make the code more predictable and easy to understand,
then more easy to debug should other barrier related issue still exist.
Janusz Krzysztofik (3):
drm/i915/active: Serialize preallocation of idle barriers
drm
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
This test can work not only on render engines, as its current code
suggests, but also on compute class engines. Add them to the set of
engine classes supported by the test, in case a future platform has only
those and no RCS available.
Suggested-by: Chris Wilson
Signed-off-by: Janusz
uot;)
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Cc: Andi Shyti
Signed-off-by: Janusz Krzysztofik
---
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_active.c
b/drivers/gpu/drm/i91
Hi Andy,
Thanks for review.
On Thursday, 2 March 2023 01:42:05 CET Andi Shyti wrote:
> Hi Janusz,
>
> On Sat, Feb 25, 2023 at 11:12:18PM +0100, Janusz Krzysztofik wrote:
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurre
On Thursday, 16 February 2023 01:30:47 CET Patchwork wrote:
> == Series Details ==
>
> Series: tests: Exercise remote request vs barrier handling race
> URL : https://patchwork.freedesktop.org/series/114045/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12741_full
On Friday, 24 February 2023 09:38:54 CET Kamil Konieczny wrote:
> On 2023-02-13 at 15:34:45 +0100, Janusz Krzysztofik wrote:
> > If any of *-without-i915 subtests fails or skips for any reason, it may
> > leave the i915 module unloaded while keeping our device list populated
>
Dummy cover letter to prevent CI / patchwork from picking up a previous
one with an outdated Test-with: clause.
Janusz Krzysztofik (1):
drm/i915/active: Fix misuse of non-idle barriers as fence trackers
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
Dummy cover letter to prevent CI / patchwork from picking up a previous
one with an outdated Test-with: clause.
Janusz Krzysztofik (1):
drm/i915/active: Fix misuse of non-idle barriers as fence trackers
drivers/gpu/drm/i915/i915_active.c | 25 ++---
1 file changed, 14
t;), v5.4,
- reword commit description.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
Fixes: 311770173fac ("drm/i915/gt: Schedule request retirement when timeline
idles")
Cc: Chris Wilson
Cc: sta...@vger.kernel.org # v5.5
Signed-off-by: Janusz Krzyszt
On Monday, 20 February 2023 21:49:46 CET Kamil Konieczny wrote:
> On 2023-02-20 at 14:24:45 +0100, Janusz Krzysztofik wrote:
> > This test can work not only on render engines, as its current code
> > suggests, but also on compute class engines. Add them to the set of
> > eng
PAGE_CHG_MASK symbol, primarly used by pte_modify(), is likely
intentionally defined with that bit not set, keep that symbol unchanged.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/7648
Fixes: 281d4078bec3 ("x86: Make page cache mode a real type")
Signed-off-b
interfers with engine heartbeat and request preemption used by the test
for exercising reset statistics.
Disable request watchdog during the test execution.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8310
Signed-off-by: Janusz Krzysztofik
---
tests/i915/gem_reset_stats.c | 7 +++
1
On Thursday, 9 February 2023 20:32:31 CET Janusz Krzysztofik wrote:
> If any of *-without-i915 subtests fails or skips for any reason, it may
> leave the i915 module unloaded while keeping our device list populated
> with initially collected data. In a follow up igt_fixture section we t
Hi Umesh,
On Friday, 10 February 2023 18:24:53 CET Umesh Nerlige Ramappa wrote:
> On Fri, Feb 10, 2023 at 09:20:25AM -0800, Umesh Nerlige Ramappa wrote:
> >On Thu, Feb 09, 2023 at 12:50:39PM +0100, Janusz Krzysztofik wrote:
> >>Users reported oopses on list corruptions wh
subtest out of tests/i915/perf.c (Ashutosh).
Janusz Krzysztofik (1):
tests: Exercise remote request vs barrier handling race
tests/i915/gem_barrier_race.c | 159 ++
tests/meson.build | 8 ++
2 files changed, 167 insertions(+)
create mode 100644
601 - 700 of 845 matches
Mail list logo
