[Intel-gfx] [PATCH 10/10] drm/i915/display/tgl+: Use PPS index from vbt

2021-07-21 Thread José Roberto de Souza
Tigerlake and newer has two instances of PPS, to support up to two eDP panels. Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_pps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH] drm/i915: Extend Wa_1406941453 to adl-p

2021-07-22 Thread José Roberto de Souza
Workaround also needed for alderlake-P. HSDES: 14010801662 Cc: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915/display: Disable audio, DRRS and PSR before planes

2021-07-26 Thread José Roberto de Souza
ld be disabled before planes but it looks safer to switch back to the default refresh rate before following with the rest of the pipe disable sequence. BSpec: 49191 BSpec: 49190 Cc: Ville Syrjälä Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c

[Intel-gfx] [PATCH CI 03/10] drm/i915/bios: Enable parse of two integrated panels timing data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c| 53 +--- drivers/gpu/drm/i915/display/intel_bios.h| 1

[Intel-gfx] [PATCH CI 04/10] drm/i915/bios: Enable parse of two integrated panels backlight data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling backlight data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 59 +++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH CI 07/10] drm/i915/bios: Enable parse of two DSI panels data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling DSI data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/icl_dsi.c | 12 +- drivers/gpu/drm/i915/display/intel_bios.c

[Intel-gfx] [PATCH CI 05/10] drm/i915/bios: Enable parse of two integrated panels eDP data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling eDP data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/g4x_dp.c | 9 ++- drivers/gpu/drm/i915/display/intel_bios.c

[Intel-gfx] [PATCH CI 02/10] drm/i915/bios: Start to support two integrated panels

2021-07-29 Thread José Roberto de Souza
lvds_dither as it is not used. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 185 +- drivers/gpu/drm/i915/display/intel_bios.h | 2 + drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH CI 10/10] drm/i915/display/tgl+: Use PPS index from vbt

2021-07-29 Thread José Roberto de Souza
Tigerlake and newer has two instances of PPS, to support up to two eDP panels. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_pps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH CI 06/10] drm/i915/bios: Enable parse of two integrated panels PSR data

2021-07-29 Thread José Roberto de Souza
Continuing the conversion from single integrated VBT data to two, now handling PSR data. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 73 +-- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH CI 01/10] drm/i915/bios: Allow DSI ports to be parsed by parse_ddi_port()

2021-07-29 Thread José Roberto de Souza
Allow MIPI DSI ports to be parsed like any other DDI port. This will be helpful to integrate into just one function the parse of information about integrated panels(eDP and DSI). Cc: Ville Syrjälä Cc: Jani Nikula Reviewed-by: Matt Atwood Signed-off-by: José Roberto de Souza --- drivers/gpu

[Intel-gfx] [PATCH CI 08/10] drm/i915/bios: Nuke panel_type

2021-07-29 Thread José Roberto de Souza
All the users were converted, now we can drop it. Reviewed-by: Matt Atwood Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 36 --- drivers/gpu/drm/i915/i915_drv.h | 1 - 2 files changed, 37

[Intel-gfx] [PATCH CI 09/10] drm/i915/bios: Only use opregion panel index for display ver 8 and older

2021-07-29 Thread José Roberto de Souza
On newer platform this opregion call always fails, also it do not support multiple panels so dropping it. Reviewed-by: Matt Atwood Cc: Ville Syrjälä Cc: Jani Nikula Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bios.c | 19 +++ 1 file changed, 7

[Intel-gfx] [PATCH 1/4] drm/i915/display/tgl+: Dispatch atomic commits instead of front buffer modifications

2021-07-30 Thread José Roberto de Souza
: Daniel Vetter Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c | 3 ++- drivers/gpu/drm/i915/display/intel_display.c | 7 ++- drivers/gpu/drm/i915/display/intel_psr.c | 6 ++ 3 files changed, 14 insertions

[Intel-gfx] [PATCH 3/4] drm/i915: Nuke ORIGIN_GTT

2021-07-30 Thread José Roberto de Souza
There is no users of it, so no need to keep handling for it. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 10 +- drivers/gpu/drm/i915/display/intel_frontbuffer.h | 3 +-- 2 files changed, 2 insertions(+), 11 deletions

[Intel-gfx] [PATCH 2/4] drm/i915/display: Fix sel fetch plane offset calculation

2021-07-30 Thread José Roberto de Souza
+ damaged_area_within_plane.y1. This fixes glitches seen in fbcon caused by typing something in the terminal. BSpec: 55229 Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

[Intel-gfx] [PATCH 4/4] DO_NOT_MERGE: drm/i915/display: Enable PSR2 selective fetch by default

2021-07-30 Thread José Roberto de Souza
to have the damage clip set otherwise it will update the whole screen and the selective blocks will not match with expected. - kms_psr: psr2_*_(mmap_gtt, mmap_cpu, blt and render), all those tests should be dropped or skipped for display 12+. Signed-off-by: José Roberto de Souza --- drivers/gpu

[Intel-gfx] [PATCH] drm/i915/display: Disable PSR2 sel fetch in TGL pre-production

2021-05-05 Thread José Roberto de Souza
The implementation of two workarounds are missing causing failures in CI with pre-production HW. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg()

2021-05-13 Thread José Roberto de Souza
If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first iteration, err is uninitialized causing a wrong call to zap_vma_ptes(). Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot") Cc: Christoph Hellwig Signed-off-by: James Ausmus Signed-off-by: J

[Intel-gfx] [PATCH 1/4] drm/i915/display: Nuke has_infoframe

2021-05-13 Thread José Roberto de Souza
This was only reduntant information has_hdmi_sink can do the same job. set_infoframes() hooks will call intel_write_infoframe() for the supported infoframes types and it will only be enabled if given type is set in crtc_state->infoframes.enable. Cc: Ville Syrjälä Signed-off-by: José Roberto

[Intel-gfx] [PATCH 3/4] drm/i915/display: Replace intel_dp_set_infoframes() enable calls by dig_port->set_infoframes()

2021-05-13 Thread José Roberto de Souza
assert_hdmi_transcoder_func_disabled() check needed to be dropped. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c| 11 ++- drivers/gpu/drm/i915/display/intel_dp.c | 36 ++--- drivers/gpu/drm/i915/display/intel_dp.h

[Intel-gfx] [PATCH 2/4] drm/i915/display: Replace intel_dp_set_infoframes() disable calls by dig_port->set_infoframes()

2021-05-13 Thread José Roberto de Souza
Both do the same thing and this change help towards the goal of nuke intel_dp_set_infoframes() completely. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c| 5 ++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 +++-- 2 files changed, 5

[Intel-gfx] [PATCH 4/4] drm/i915/display: Fix fastsets involving PSR

2021-05-13 Thread José Roberto de Souza
/display: Fill PSR state during hardware configuration read out") Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v2 1/4] drm/i915/display: Fix fastsets involving PSR

2021-05-14 Thread José Roberto de Souza
/display: Fill PSR state during hardware configuration read out") Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm

[Intel-gfx] [PATCH v2 2/4] drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled

2021-05-14 Thread José Roberto de Souza
asked state to what was programmed to hardware. Cc: Gwan-gyeong Mun Cc: Radhakrishna Sripada Reported-by: Ville Syrjälä Fixes: 78b772e1a01f ("drm/i915/display: Fill PSR state during hardware configuration read out" Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 3/4] drm/i915/display: Nuke has_infoframe

2021-05-14 Thread José Roberto de Souza
ort->set_infoframes() calls. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/g4x_hdmi.c | 22 ++- drivers/gpu/drm/i915/display/intel_ddi.c | 17 +- drivers/gpu/drm/i915/display/intel_display.c | 6 ++--- .../drm/i915/d

[Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

2021-05-14 Thread José Roberto de Souza
intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will take care to disable all enabled infoframes. Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH CI] drm/i915: Initialize err in remap_io_sg()

2021-05-17 Thread José Roberto de Souza
lizing ret here. Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot") Reviewed-by: Christoph Hellwig Cc: Christoph Hellwig Signed-off-by: James Ausmus Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Intel-gfx] [PATCH 2/5] drm/i915/adl_p: Handle TC cold

2021-05-24 Thread José Roberto de Souza
tc_cold_block() is called BSpec: 55480 Cc: Imre Deak Signed-off-by: José Roberto de Souza Signed-off-by: Clinton Taylor Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 6 ++ drivers/gpu/drm/i915/display/intel_tc.c| 14 ++ drivers/gpu

[Intel-gfx] [PATCH 3/5] drm/i915: WA for zero memory channel

2021-05-24 Thread José Roberto de Souza
or reading it, so lets force it to 1 in this case. Cc: Stanislav Lisovskiy Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_bw.c | 2 +- 1 file changed, 1 in

[Intel-gfx] [PATCH 4/5] drm/i915/display/adl_p: Allow DC3CO in pipe and port B

2021-05-24 Thread José Roberto de Souza
DC3CO is allowed in all the combinations between pipe and port A and B on alderlake-P. BSpec: 49196 Cc: Anshuman Gupta Cc: Gwan-gyeong Mun Cc: Matt Atwood Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 20 1 file changed, 16

[Intel-gfx] [PATCH 5/5] drm/i915/display/adl_p: Disable PSR2

2021-05-24 Thread José Roberto de Souza
We are missing the implementation of some workarounds to enabled PSR2 in Alderlake P, so to avoid any CI report of issues around PSR2 disabling it until all PSR2 workarounds are implemented. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c

[Intel-gfx] [PATCH 1/5] drm/i915/display/adl_p: Drop earlier return in tc_has_modular_fia()

2021-05-24 Thread José Roberto de Souza
MODULAR_FIA_MASK is set in adl_p so we can drop this ealier return and read registers. Also to avoid warnings from icl_tc_port_assert_ref_held() when calling tc_cold_block() in this functions it is necessary to held the lock. Cc: Imre Deak Signed-off-by: José Roberto de Souza --- drivers/gpu

[Intel-gfx] [PATCH CI 1/2] drm/i915/display: Fix sel fetch plane offset calculation

2021-08-14 Thread José Roberto de Souza
+ damaged_area_within_plane.y1. This fixes glitches seen in fbcon caused by typing something in the terminal. BSpec: 55229 Reviewed-by: Gwan-gyeong Mun Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 8 ++-- 1 file changed, 2

[Intel-gfx] [PATCH CI 2/2] drm/i915: Nuke ORIGIN_GTT

2021-08-14 Thread José Roberto de Souza
There is no users of it, so no need to keep handling for it. Reviewed-by: Gwan-gyeong Mun Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 10 +- drivers/gpu/drm/i915/display/intel_frontbuffer.h | 3 +-- 2 files changed

[Intel-gfx] [PATCH 1/3] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-08-14 Thread José Roberto de Souza
-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c | 6 ++ drivers/gpu/drm/i915/display/intel_display.c | 7 ++- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 ++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ 4 files changed, 16

[Intel-gfx] [PATCH 3/3] drm/i915/psr: Drop frontbuffer rendering support

2021-08-14 Thread José Roberto de Souza
will leave this task to whoever will fix DC3CO. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_debugfs.c | 2 - .../drm/i915/display/intel_display_types.h| 2 - .../gpu/drm/i915/display/intel_frontbuffer.c | 2 - drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/3] drm/i915/display: Drop PSR support from HSW and BDW

2021-08-14 Thread José Roberto de Souza
At this point is sure that HSW and BDW will never have PSR enabled by default, so here dropping it from device info and cleaning up code. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 97 drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread José Roberto de Souza
Cc: Rob Clark Cc: Deepak Rawat Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_damage_helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c inde

[Intel-gfx] [PATCH 1/8] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-17 Thread José Roberto de Souza
Cc: Rob Clark Cc: Deepak Rawat Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_damage_helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_damage_helper.c b/drivers/gpu/drm/drm_damage_helper.c inde

[Intel-gfx] [PATCH 4/8] drm/i915/display: Some code improvements and code style fixes for DRRS

2021-08-17 Thread José Roberto de Souza
It started as a code style fix for the lines above 100 col but it turned out to simplyfications to intel_dp_set_drrs_state(). Now it receives the desired refresh rate type, high or low. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 60

[Intel-gfx] [PATCH 8/8] drm/i915/display: Drop PSR frontbuffer rendering support

2021-08-17 Thread José Roberto de Souza
will leave this task to whoever will fix DC3CO. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_debugfs.c | 2 - .../drm/i915/display/intel_display_types.h| 2 - .../gpu/drm/i915/display/intel_frontbuffer.c | 2 - drivers/gpu/drm/i9

[Intel-gfx] [PATCH 3/8] drm/i915/display: Move DRRS code its own file

2021-08-17 Thread José Roberto de Souza
intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce some lines from it. Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- Documentation/gpu/i915.rst| 14 +- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm

[Intel-gfx] [PATCH 2/8] drm/i915/display: Drop PSR support from HSW and BDW

2021-08-17 Thread José Roberto de Souza
At this point is sure that HSW and BDW will never have PSR enabled by default, so here dropping it from device info and cleaning up code. v2: - enable psr support for display 9 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 97

[Intel-gfx] [PATCH 0/8] Drop frontbuffer rendering support from Skylake and newer

2021-08-17 Thread José Roberto de Souza
José Roberto de Souza (8): drm/damage_helper: Fix handling of cursor dirty buffers drm/i915/display: Drop PSR support from HSW and BDW drm/i915/display: Move DRRS code its own file drm/i915/display: Some code improvements and code style fixes for DRRS drm/i915/display: Share code between

[Intel-gfx] [PATCH 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-08-17 Thread José Roberto de Souza
-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c | 6 ++ drivers/gpu/drm/i915/display/intel_display.c | 7 ++- drivers/gpu/drm/i915/display/intel_frontbuffer.c | 6 ++ drivers/gpu/drm/i915/i915_drv.h | 2 ++ 4 files changed, 16

[Intel-gfx] [PATCH 6/8] drm/i915/display: Prepare DRRS for frontbuffer rendering drop

2021-08-17 Thread José Roberto de Souza
can change between high and low refresh rates as needed. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ drivers/gpu/drm/i915/display/intel_drrs.c| 9 + drivers/gpu/drm/i915/display/intel_drrs.h| 4 3 files changed, 15 insertions

[Intel-gfx] [PATCH 5/8] drm/i915/display: Share code between intel_edp_drrs_flush and invalidate

2021-08-17 Thread José Roberto de Souza
Both functions are pretty much equal, with minor changes that can be handled by a single parameter. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 82 +-- 1 file changed, 32 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 0/8] Drop frontbuffer rendering support from Skylake and newer

2021-08-24 Thread José Roberto de Souza
- enabling PSR support for display 9, it was left disabled as mistake - returning in frontbuffer functions to not set fb_tracking.busy/flip_bits Cc: Gwan-gyeong Mun Cc: Daniel Vetter José Roberto de Souza (8): drm/i915/display: Drop PSR support from HSW and BDW drm/i915/display: Move DRRS co

[Intel-gfx] [PATCH v2 5/8] drm/i915/display: Share code between intel_drrs_flush and intel_drrs_invalidate

2021-08-24 Thread José Roberto de Souza
Both functions are pretty much equal, with minor changes that can be handled by a single parameter. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 82 +-- 1 file changed, 32 insertions(+), 50 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH v2 8/8] drm/i915/display: Drop PSR frontbuffer rendering support

2021-08-24 Thread José Roberto de Souza
will leave this task to whoever will fix DC3CO. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_debugfs.c | 2 - .../drm/i915/display/intel_display_types.h| 2 - .../gpu/drm/i915/display/intel_frontbuffer.c | 2 - drivers/gpu/drm/i9

[Intel-gfx] [PATCH v2 2/8] drm/i915/display: Move DRRS code its own file

2021-08-24 Thread José Roberto de Souza
intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce some lines from it. Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- Documentation/gpu/i915.rst| 14 +- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm

[Intel-gfx] [PATCH v2 4/8] drm/i915/display: Some code improvements and code style fixes for DRRS

2021-08-24 Thread José Roberto de Souza
It started as a code style fix for the lines above 100 col but it turned out to simplifications to intel_drrs_set_state(). Now it receives the desired refresh rate type, high or low. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 60

[Intel-gfx] [PATCH v2 1/8] drm/i915/display: Drop PSR support from HSW and BDW

2021-08-24 Thread José Roberto de Souza
At this point is sure that HSW and BDW will never have PSR enabled by default, so here dropping it from device info and cleaning up code. v2: - enable psr support for display 9 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 97

[Intel-gfx] [PATCH v2 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-08-24 Thread José Roberto de Souza
setting the busy/flip_bits Cc: Daniel Vetter Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c| 6 ++ drivers/gpu/drm/i915/display/intel_fb.c| 8 +++- .../gpu/drm/i915

[Intel-gfx] [PATCH v2 6/8] drm/i915/display: Prepare DRRS for frontbuffer rendering drop

2021-08-24 Thread José Roberto de Souza
change between high and low refresh rates as needed. Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ drivers/gpu/drm/i915/display/intel_drrs.c| 9 + drivers/gpu/drm/i915/display/intel_drrs.h| 4 3 files changed, 15 insertions(+) diff

[Intel-gfx] [PATCH v2 3/8] drm/i915/display: Renaming DRRS functions to intel_drrs_*()

2021-08-24 Thread José Roberto de Souza
: José Roberto de Souza --- Documentation/gpu/i915.rst| 13 +-- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +- .../drm/i915/display/intel_display_debugfs.c | 6 +- drivers/gpu/drm/i915/display/intel_dp.c | 6 +- drivers/gpu/drm/i915/display/intel_drrs.c

[Intel-gfx] [PATCH CI 2/3] drm/i915/display: Move DRRS code its own file

2021-08-27 Thread José Roberto de Souza
intel_dp.c is a 5k lines monster, so moving DRRS out of it to reduce some lines from it. Reviewed-by: Rodrigo Vivi Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- Documentation/gpu/i915.rst| 14 +- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH CI 3/3] drm/i915/display: Renaming DRRS functions to intel_drrs_*()

2021-08-27 Thread José Roberto de Souza
static function (intel_drrs_set_state) Reviewed-by: Rodrigo Vivi Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- Documentation/gpu/i915.rst| 13 +-- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +- .../drm/i915/display/intel_display_debugfs.c

[Intel-gfx] [PATCH CI 1/3] drm/i915/display: Drop PSR support from HSW and BDW

2021-08-27 Thread José Roberto de Souza
At this point is sure that HSW and BDW will never have PSR enabled by default, so here dropping it from device info and cleaning up code. v2: - enable psr support for display 9 Reviewed-by: Rodrigo Vivi Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v3 1/3] drm/i915/display: Some code improvements and code style fixes for DRRS

2021-09-03 Thread José Roberto de Souza
It started as a code style fix for the lines above 100 col but it turned out to simplifications to intel_drrs_set_state(). Now it receives the desired refresh rate type, high or low. v3: - Fixed the mode refesh rate debug message Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH v3 3/3] drm/i915/display: Prepare DRRS for frontbuffer rendering drop

2021-09-03 Thread José Roberto de Souza
change between high and low refresh rates as needed. Reviewed-by: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ drivers/gpu/drm/i915/display/intel_drrs.c| 9 + drivers/gpu/drm/i915/display/intel_drrs.h| 4 3 files

[Intel-gfx] [PATCH v3 2/3] drm/i915/display: Share code between intel_drrs_flush and intel_drrs_invalidate

2021-09-03 Thread José Roberto de Souza
Both functions are pretty much equal, with minor changes that can be handled by a single parameter. v3: - not scheduling work from invalidate operations Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_drrs.c | 82 +-- 1 file

[Intel-gfx] [PATCH CI 2/2] drm/i915/display: Drop PSR frontbuffer rendering support

2021-09-09 Thread José Roberto de Souza
will leave this task to whoever will fix DC3CO. Reviewed-by: Gwan-gyeong Mun Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- .../drm/i915/display/intel_display_debugfs.c | 2 - .../drm/i915/display/intel_display_types.h| 2 - .../gpu/drm/i915/display/intel_frontbuffe

[Intel-gfx] [PATCH CI 1/2] drm/i915/display/skl+: Drop frontbuffer rendering support

2021-09-09 Thread José Roberto de Souza
setting the busy/flip_bits Reviewed-by: Gwan-gyeong Mun Cc: Daniel Vetter Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c| 6 ++ drivers/gpu/drm/i915/display/intel_fb.c

[Intel-gfx] [PATCH 2/5] drm/i915/display/adlp: Add new PSR2 workarounds

2021-09-09 Thread José Roberto de Souza
Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 23 ++- drivers/gpu/drm/i915/i915_reg.h | 4 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/5] drm/i915/display/adlp: Fix PSR2_MAN_TRK_CTL_SU_REGION_END_ADDR calculation

2021-09-09 Thread José Roberto de Souza
As the SU_REGION_START begins at 0, the SU_REGION_END should be number of lines - 1. BSpec: 50424 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/5] drm/i915/display: Wait at least 2 frames before selective update

2021-09-09 Thread José Roberto de Souza
BSpec states that the minimum number of frames before selective update is 2, so making sure this minimum limit is fulfilled. BSpec: 50422 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Intel-gfx] [PATCH 4/5] drm/i915/display/psr: Use drm damage helpers to calculate plane damaged area

2021-09-09 Thread José Roberto de Souza
ld be added to pipe_clip and not saving power. Cc: Daniel Vetter Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 37 +--- 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/di

[Intel-gfx] [PATCH 5/5] drm/i915/display: Workaround cursor left overs with PSR2 selective fetch enabled

2021-09-09 Thread José Roberto de Souza
-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 25 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 670b0ceba110f..18e721dde22e2 100644

[Intel-gfx] [PATCH 2/2] drm/i915/display: Disable FBC when PSR2 is enabled display 12 and newer

2021-06-25 Thread José Roberto de Souza
This is now a requirement for all display 12 and newer, not only for tigerlake. BSpec: 50422 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drm/i915/display/adl_p: Implement PSR changes

2021-06-25 Thread José Roberto de Souza
but will need to be aligned with DSC when the PSRS + DSC support lands BSpec: 50422 BSpec: 50424 Cc: Gwan-gyeong Mun Cc: Anusha Srivatsa Signed-off-by: José Roberto de Souza Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_psr.c | 43 ++-- drivers

[Intel-gfx] [PATCH] drm/i915/display/dg1: Correctly map DPLLs during state readout

2021-06-30 Thread José Roberto de Souza
t;get_config()") Cc: Lucas De Marchi Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 19 --- drivers/gpu/drm/i915/i915_reg.h | 3 --- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 7/7] drm/i915/display/xelpd: Exetend Wa_14011508470

2021-07-08 Thread José Roberto de Souza
This workaround is also applicable to xelpd display so extending it. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 2/7] drm/i915: Implement Wa_1508744258

2021-07-08 Thread José Roberto de Souza
Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a

[Intel-gfx] [PATCH 5/7] drm/i915: Limit Wa_22010178259 to affected platforms

2021-07-08 Thread José Roberto de Souza
This workaround is not needed for platforms with display 13. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 6/7] drm/i915/display/adl_p: Correctly program MBUS DBOX A credits

2021-07-08 Thread José Roberto de Souza
Alderlake-P have different values for MBUS DBOX A credits depending if MBUS join is enabled or not. BSpec: 50343 BSpec: 54369 Cc: Matt Atwood Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display.c | 16 1 file changed, 12 insertions(+), 4

[Intel-gfx] [PATCH 1/7] drm/i915: Settle on "adl-x" in WA comments

2021-07-08 Thread José Roberto de Souza
From: Lucas De Marchi Most of the places are using this format so lets consolidate it. Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/display/intel_cursor.c| 2 +- drivers/gpu

[Intel-gfx] [PATCH 4/7] drm/i915: Limit maximum number of memory channels

2021-07-08 Thread José Roberto de Souza
Alderlake-P PCODE is returning 4 memory channels while it has a maximum of 2. So adding this limit and printing a debug message but the real fix will need to come from PCODE. HSDES: 22013272110 Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_dram.c | 4 1 file changed

[Intel-gfx] [PATCH 3/7] drm/i915/adl_s: Extend Wa_1406941453

2021-07-08 Thread José Roberto de Souza
BSpec: 54370 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index

[Intel-gfx] [PATCH CI 1/6] drm/i915/display: Settle on "adl-x" in WA comments

2021-07-12 Thread José Roberto de Souza
Most of the places are using this format so lets consolidate it. v2: - split patch in two: display and non-display because of conflicts between drm-intel-gt-next x drm-intel-next Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm

[Intel-gfx] [PATCH CI 5/6] drm/i915: Limit Wa_22010178259 to affected platforms

2021-07-12 Thread José Roberto de Souza
This workaround is not needed for platforms with display 13. Cc: Gwan-gyeong Mun Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH CI 3/6] drm/i915: Implement Wa_1508744258

2021-07-12 Thread José Roberto de Souza
Same bit was required for Wa_14012131227 in DG1 now it is also required as Wa_1508744258 to TGL, RKL, DG1, ADL-S and ADL-P. Cc: Gwan-gyeong Mun Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 7 +++ 1 file changed, 7

[Intel-gfx] [PATCH CI 6/6] drm/i915/display/xelpd: Extend Wa_14011508470

2021-07-12 Thread José Roberto de Souza
This workaround is also applicable to xelpd display so extending it. Cc: Gwan-gyeong Mun Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH CI 2/6] drm/i915: Settle on "adl-x" in WA comments

2021-07-12 Thread José Roberto de Souza
Most of the places are using this format so lets consolidate it. v2: - split patch in two: display and non-display because of conflicts between drm-intel-gt-next x drm-intel-next Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza Signed-off-by: Lucas De Marchi --- drivers/gpu/drm

[Intel-gfx] [PATCH CI 4/6] drm/i915/adl_s: Extend Wa_1406941453

2021-07-12 Thread José Roberto de Souza
BSpec: 54370 Cc: Gwan-gyeong Mun Reviewed-by: Matt Roper Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt

[Intel-gfx] [PATCH 4/4] drm/i915/display/psr2: Force a PSR exit in the frontbuffer modification flushes

2021-07-16 Thread José Roberto de Souza
-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 1c41042841fb1..7316967aba94b 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/4] drm/i915/display: Disable FBC when PSR2 is enabled for xelpd platforms

2021-07-16 Thread José Roberto de Souza
xelpd platforms also requires that FBC is disabled when PSR2 is enabled so extending it. BSpec: 50422 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/4] drm/i915/display/psr2: Fix cursor updates using legacy apis

2021-07-16 Thread José Roberto de Souza
this patch is possible to see a mouse movement lag in Gnome when PSR2 selective fetch is enabled. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_cursor.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 2/4] drm/i915/display/psr2: Mark as updated all planes that intersect with pipe_clip

2021-07-16 Thread José Roberto de Souza
Without this planes that were added by intel_psr2_sel_fetch_update() that intersect with pipe damaged area will not have skl_program_plane() and intel_psr2_program_plane_sel_fetch() called, causing panel to not be properly updated. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza

[Intel-gfx] [PATCH CI 2/3] drm/i915: Do not set any power wells when there is no display

2021-04-08 Thread José Roberto de Souza
Power wells are only part of display block and not necessary when running a headless driver. Reviewed-by: Radhakrishna Sripada Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_power.c | 5 - 1 file changed

[Intel-gfx] [PATCH CI 1/3] drm/i915: Skip display interruption setup when display is not available

2021-04-08 Thread José Roberto de Souza
Return ealier in the functions doing interruption setup for GEN8+ also adding a warning in gen8_de_irq_handler() to let us know that something else is still missing. Reviewed-by: Radhakrishna Sripada Cc: Ville Syrjälä Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza Signed-off-by

[Intel-gfx] [PATCH CI 3/3] drm/i915: skip display initialization when there is no display

2021-04-08 Thread José Roberto de Souza
splay. Reviewed-by: Radhakrishna Sripada Cc: Lucas De Marchi Signed-off-by: José Roberto de Souza Signed-off-by: Jani Nikula Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 44 +++ .../drm/i915/display/intel_display_power.c

[Intel-gfx] [PATCH 2/2] Revert "drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications"

2021-04-08 Thread José Roberto de Souza
This reverts commit 71c1a4998320962f7b8362b2c5ee36610d49e8fb. The proper fix is Wa_14013723622, so now we can revert this WA and get back some power savings. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 16 +--- 1 file

[Intel-gfx] [PATCH 1/2] drm/i915/display: Implement Wa_14013723622

2021-04-08 Thread José Roberto de Souza
This WA fix some display glitches when the system is under high memory pressure. BSpec: 52890 Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_pm.c | 5 + 2 files changed, 8 insertions(+) diff --git a/drivers

[Intel-gfx] [PATCH] drm/i915/display: Defeature PSR2 for RKL and ADL-S

2021-04-08 Thread José Roberto de Souza
PSR2 is defeatured for RKL and ADL-S, no important power impact as those are desktop CPUs and PSR2 was not even enabled by default yet in platforms without PSR2 HW tracking. HSDES: 14011750631 HSDES: 14011741325 BSpec: 53273 Cc: Caz Yokoyama Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de

[Intel-gfx] [PATCH] drm/i915/display/psr: Fix cppcheck warnings

2021-04-09 Thread José Roberto de Souza
Fix redundant condition, caught in cppcheck by kernel test robot. Reported-by: kernel test robot Cc: Gwan-gyeong Mun Fixes: b64d6c51380b ("drm/i915/display: Support PSR Multiple Instances") Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_psr.c | 3 +

[Intel-gfx] [PATCH 1/5] drm/i915/display: Fill PSR state during hardware configuration read out

2021-04-17 Thread José Roberto de Souza
like frontbuffer modifications and CRC. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 + drivers/gpu/drm/i915/display/intel_display.c | 5 +++ drivers/gpu/drm/i915/display/intel_psr.c | 47 drivers/gpu/drm

[Intel-gfx] [PATCH 5/5] drm/i915/display/xelpd: Implement Wa_14013475917

2021-04-17 Thread José Roberto de Souza
This workaround requires that VIDEO_DIP_ENABLE_VSC_HSW is never set with PSR. BSpec: 54369 BSpec: 54077 Cc: Matt Atwood Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 2/5] drm/i915/display: Replace intel_psr_enabled() calls by intel_crtc_state check

2021-04-17 Thread José Roberto de Souza
g hardware configuration read out" it is possible. Cc: Gwan-gyeong Mun Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/display/intel_dp.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/dis

<    1   2   3   4   5   6   7   8   9   10   >