[Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 03/10] drm/rockchip/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/dr

[Intel-gfx] [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/a

[Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

the number of source in the list. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Changes Since V2: - update commit message - update callback documentation - print one source name per line Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_c

[Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

. Changes since V1: - refactor code to use single spin lock Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm

[Intel-gfx] [PATCH 07/10] drm/i915/crc: implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[Intel-gfx] [PATCH 06/10] drm/i915/crc: implement verify_crc_source callback

This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[Intel-gfx] [PATCH 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the crc sources supported by driver in current platform. Signed-off-by: Mahesh Kumar Cc: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 11 ++ drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 + drivers/gpu

[Intel-gfx] [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[Intel-gfx] [PATCH v4 02/10] drm: crc: Introduce get_crc_sources callback

the number of source in the list. Changes Since V1: (Daniel) - return const pointer to an array of crc sources list - do validation of sources in CRC-core Changes Since V2: - update commit message - update callback documentation - print one source name per line Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and may need inputs Cc: dri-de...@lists.freedesktop.org Mahesh Kumar (10): drm: crc: Introduce verify_crc

[Intel-gfx] [PATCH v4 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[Intel-gfx] [PATCH v4 03/10] drm/rockchip/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/dr

[Intel-gfx] [PATCH v4 06/10] drm/i915/crc: implement verify_crc_source callback

This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers

[Intel-gfx] [PATCH v4 01/10] drm: crc: Introduce verify_crc_source callback

e callback description Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_debugfs_crc.c | 8 include/drm/drm_crtc.h| 16 2 files changed, 24

[Intel-gfx] [PATCH v4 07/10] drm/i915/crc: implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers

[Intel-gfx] [PATCH v4 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Changes Since V2: - further optimize the code Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten

[Intel-gfx] [PATCH v4 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/a

[Intel-gfx] [PATCH v4 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the crc sources supported by driver in current platform. Changes Since V1: - move sources list per-crtc - init sources-list only for gen3 Signed-off-by: Mahesh Kumar Cc: Laurent Pinchart --- drivers/gpu/drm/rcar-du

[Intel-gfx] [PATCH v4 08/10] drm/crc: Cleanup crtc_crc_open function

. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst Acked-by: Leo Li Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/display/amdgpu_dm

[Intel-gfx] [PATCH 0/3] Decode memdev info and bandwidth and implemnt latency WA

This series adds support to calculate system memdev parameters and calculate total system memory bandwidth. This parameters and BW will be used to enable WM level-0 latency workaround and display memory bandwidth related WA for gen9. Mahesh Kumar (3): drm/i915/bxt: Decode memory bandwidth and

[Intel-gfx] [PATCH 1/3] drm/i915/bxt: Decode memory bandwidth and parameters

This patch adds support to decode system memory bandwidth and other parameters for broxton platform, which will be used for arbitrated display memory bandwidth calculation in GEN9 based platforms and WM latency level-0 Work-around calculation on GEN9+ platforms. Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 2/3] drm/i915/skl+: Decode memory bandwidth and parameters

This patch adds support to decode system memory bandwidth and other parameters for skylake and Gen9+ platforms, which will be used for arbitrated display memory bandwidth calculation in GEN9 based platforms and WM latency level-0 Work-around calculation on GEN9+. Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 3/3] drm/i915: Implement 16GB dimm wa for latency level-0

Memory with 16GB dimms require an increase of 1us in level-0 latency. This patch implements the same. Bspec: 4381 Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 35 +-- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v5 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Changes Since V2: - further optimize the code Changes Since V3: - Adopt to driver style - Address review comments from Laurent Pinchart Signed-off-by: Ma

[Intel-gfx] [PATCH v5 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

Laurent Pinchart Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 85 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 ++ 2 files changed, 87 insertions(+), 1 deletion(-) diff --git a

[Intel-gfx] [PATCH 2/5] drm/i915/skl+: Decode memory bandwidth and parameters

/memdev_info/dram_info - create a struct to hold channel info Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 131 ++-- drivers/gpu/drm/i915/i915_drv.h | 7 +++ drivers/gpu/drm/i915/i915_reg.h | 21 +++ 3 files changed, 155 insertions(+), 4

[Intel-gfx] [PATCH 1/5] drm/i915/bxt: Decode memory bandwidth and parameters

/dram_info Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 116 drivers/gpu/drm/i915/i915_drv.h | 11 drivers/gpu/drm/i915/i915_reg.h | 30 +++ 3 files changed, 157 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/5] Decode memdev info and bandwidth and implemnt latency WA

lets also make sure that we override IPC value set of BIOS incase we decide to disable IPC in KMS. Mahesh Kumar (5): drm/i915/bxt: Decode memory bandwidth and parameters drm/i915/skl+: Decode memory bandwidth and parameters drm/i915: Implement 16GB dimm wa for latency level-0 drm/i915/kbl

[Intel-gfx] [PATCH 5/5] drm/i915/skl+: don't trust IPC value set by BIOS

If KMS decide to disable IPC make sure we override IPC configuration set by BIOS. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH 4/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

IPC may cause underflows if not used with dual channel symmetric memory configuration. Disable IPC for non symmetric configurations in affected platforms. Display WA #1141 Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 43 - drivers/gpu

[Intel-gfx] [PATCH 3/5] drm/i915: Implement 16GB dimm wa for latency level-0

Memory with 16GB dimms require an increase of 1us in level-0 latency. This patch implements the same. Bspec: 4381 changes since V1: - s/memdev_info/dram_info - make skl_is_16gb_dimm pure function Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 40

[Intel-gfx] [PATCH] drm/i915/skl: distribute DDB based on panel resolution

make changes to distribute ddb based on display width. So display with higher width will get bigger chunk of DDB. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107113 Cc: raviraj.p.sita...@intel.com Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 55

[Intel-gfx] [PATCH v2 0/2] distribute DDB based on panel resolution

This series make changes to distribute DDB based on resolution of panel instead of dividing equally among pipes. Mahesh Kumar (2): drm/i915: ddb_size is of u16 type drm/i915/skl: distribute DDB based on panel resolution drivers/gpu/drm/i915/intel_pm.c | 66

[Intel-gfx] [PATCH v1 1/2] drm/i915: ddb_size is of u16 type

ddb_size is u16 so use same return type for intel_get_ddb_size wrapper. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH v2 2/2] drm/i915/skl: distribute DDB based on panel resolution

: raviraj.p.sita...@intel.com Cc: Chris Wilson Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 54 +++-- 1 file changed, 41 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH v3 2/2] drm/i915/skl: distribute DDB based on panel resolution

errors (Chris) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107113 Cc: raviraj.p.sita...@intel.com Cc: Chris Wilson Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 55 ++--- 1 file changed, 40 insertions(+), 15 deletions(-) diff --git

[Intel-gfx] [PATCH V6 10/10] drm/rcar-du/crc: Implement get_crc_sources callback

Laurent Pinchart Changes Since V3/4/5: (Laurent Pinchart review) - s/rcar_du_crtc_crc_sources_list_init/rcar_du_crtc_crc_init - s/rcar_du_crtc_crc_sources_list_uninit/rcar_du_crtc_crc_cleanup - other cleanup Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart

[Intel-gfx] [PATCH v5 0/3] Improve crc-core driver interface

ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and may need inputs Changes: - Rebase on top of VKMS driver Cc: dri-de...@lists.freedesktop.org Mahes

[Intel-gfx] [PATCH v5 2/3] drm/crc: Cleanup crtc_crc_open function

. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Changes since V3: - rebase on top of VKMS driver Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Cc: Haneen Mohammed Reviewed-by: Maarten Lankhorst (V2) Acked-by: Leo Li

[Intel-gfx] [PATCH v1 1/3] drm/vkms/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Cc: dri-de...@lists.freedesktop.org Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/vkms/vkms_crc.c | 36 drivers/gpu/drm/vkms/vkms_c

[Intel-gfx] [PATCH v4 3/3] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[Intel-gfx] [PATCH V2 1/3] drm/vkms/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/vkms/vkms_crc.c | 38 ++ drive

[Intel-gfx] [PATCH V3 1/3] drm/vkms/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Changes Since V2: - don't return early from set_crc_source to keep behavior same (Haneen) Cc: Haneen Mohammed Signed-off-b

[Intel-gfx] [PATCH V4 3/4] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[Intel-gfx] [PATCH V3 1/4] drm/vkms/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Changes Since V2: - don't return early from set_crc_source to keep behavior same (Haneen) Cc: Haneen Mohammed Signed-off-by: Mahesh

[Intel-gfx] [PATCH 0/4] Improve crc-core driver interface

leanup of crtc_crc_open function first allocate memory before enabling CRC generation - Don't block open() call instead wait in crc read call. Changes: - Rebase on top of VKMS driver - Include pre_crc_read patch Cc: dri-de...@lists.freedesktop.org Mahesh Kumar (4): drm/vkms/crc

[Intel-gfx] [PATCH V5 2/4] drm/crc: Cleanup crtc_crc_open function

. Changes since V1: - refactor code to use single spin lock Changes since V2: - rebase Changes since V3: - rebase on top of VKMS driver Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org Cc: Laurent Pinchart Cc: Haneen Mohammed Reviewed-by: Maarten Lankhorst (V2) Acked-by: Leo Li

[Intel-gfx] [PATCH V2 4/4] drm/crc: add pre_crc_read function

This patch implements a callback function which will be called before crc read. In this function driver can implement any preparation work required for successfully reading CRC data. Changes Since V1: - rebase Cc: dri-de...@lists.freedesktop.org Signed-off-by: Mahesh Kumar --- drivers/gpu/drm

[Intel-gfx] [PATCH V3 3/5] drm/i915: Implement 16GB dimm wa for latency level-0

Memory with 16GB dimms require an increase of 1us in level-0 latency. This patch implements the same. Bspec: 4381 changes since V1: - s/memdev_info/dram_info - make skl_is_16gb_dimm pure function Changes since V2: - make is_16gb_dimm more generic - rebase Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH V3 2/5] drm/i915/skl+: Decode memory bandwidth and parameters

/memdev_info/dram_info - create a struct to hold channel info Changes Since V2: - rewrite code to adhere i915 coding style - not valid for GLK Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 145 ++-- drivers/gpu/drm/i915/i915_drv.h | 8 +++ drivers

[Intel-gfx] [PATCH 0/5] Decode memdev info and bandwidth and implemnt latency WA

lets also make sure that we override IPC value set of BIOS incase we decide to disable IPC in KMS. Mahesh Kumar (5): drm/i915/bxt: Decode memory bandwidth and parameters drm/i915/skl+: Decode memory bandwidth and parameters drm/i915: Implement 16GB dimm wa for latency level-0 drm/i915/skl

[Intel-gfx] [PATCH V3 1/5] drm/i915/bxt: Decode memory bandwidth and parameters

/dram_info Changes since V2: - Adhere to i915 coding style (Rodrigo) Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 117 drivers/gpu/drm/i915/i915_drv.h | 11 drivers/gpu/drm/i915/i915_reg.h | 30 +++ 3 files changed, 158

[Intel-gfx] [PATCH V1 4/5] drm/i915/skl+: don't trust IPC value set by BIOS

If KMS decide to disable IPC make sure we override IPC configuration set by BIOS. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH V2 5/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations

IPC may cause underflows if not used with dual channel symmetric memory configuration. Disable IPC for non symmetric configurations in affected platforms. Display WA #1141 Changes Since V1: - Re-arrange the code. - update wrapper to return if memory is symmetric (Rodrigo) Signed-off-by: Mahesh

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Reject compressed Y/Yf with interlaced modes

state->fb->modifier == I915_FORMAT_MOD_Yf_TILED || > + state->fb->modifier == I915_FORMAT_MOD_Y_TILED_CCS || > + state->fb->modifier == I915_FORMAT_MOD_Yf_TILED_CCS) { LGTM... Reviewed-by: Mahesh Kumar -Mahesh >

[Intel-gfx] [PATCH V4 3/5] drm/i915: Implement 16GB dimm wa for latency level-0

condition (Maarten) Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.c | 33 +++-- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/intel_pm.c | 10 ++ 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask

This cleanup patch makes changes to use for_each_pipe loop during bit-mask assignment of allowed crtc with encoder. Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Mahesh Kumar Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_ddi.c | 4 +++- drivers/gpu/drm/i915/intel_dp.c | 5

[Intel-gfx] [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask

This cleanup patch makes changes to use for_each_pipe loop during bit-mask assignment of allowed crtc with encoder. changes: - use BIT(i) macro instead of (1 << i) (Chris) Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_ddi.c | 4 +++- d

[Intel-gfx] [PATCH v3] drm/i915: use for_each_pipe loop to assign crtc_mask

This cleanup patch makes changes to use for_each_pipe loop during bit-mask assignment of allowed crtc with encoder. changes: - use BIT(i) macro instead of (1 << i) (Chris) changes from V2: - use int for consistency (Jani) Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: Mahesh

[Intel-gfx] [PATCH v4] drm/i915: use for_each_pipe loop to assign crtc_mask

la Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_ddi.c | 4 +++- drivers/gpu/drm/i915/intel_dp.c | 5 - drivers/gpu/drm/i915/intel_hdmi.c | 5 - 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/dr

[Intel-gfx] [PATCH v5] drm/i915: use for_each_pipe loop to assign crtc_mask

rom V4: - drop DP/HDMI changes, as already part of patch from ville Cc: Jani Nikula Cc: Rodrigo Vivi Signed-off-by: Mahesh Kumar Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/d

[Intel-gfx] [PATCH 2/2] drm/i915/icl: Enable 2nd DBuf slice only when needed

. Changes since V3: - Create a generic helper to enable/disable slice - don't return early if total_data_rate is 0, it may be cursor only commit, or atomic modeset without any plane. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c| 10 + drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 0/3] Optimize use of DBuf slices

Patches in this series were originally part of series: https://patchwork.freedesktop.org/series/36993/ Reposting it here after rebase Mahesh Kumar (3): drm/i915/icl: track dbuf slice-2 status drm/i915/icl: Enable 2nd DBuf slice only when needed drm/i915/icl: update ddb entry start/end mask

[Intel-gfx] [PATCH 2/3] drm/i915/icl: Enable 2nd DBuf slice only when needed

. Changes since V3: - Create a generic helper to enable/disable slice - don't return early if total_data_rate is 0, it may be cursor only commit, or atomic modeset without any plane. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c| 10 + drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 3/3] drm/i915/icl: update ddb entry start/end mask during hw ddb readout

Gen11/ICL onward ddb entry start/end mask is increased from 10 bits to 11 bits. This patch make changes to use proper mask for ICL+ during hardware ddb value readout. Changes since V1: - Use _MASK & _SHIFT macro (James) Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 1/3] drm/i915/icl: track dbuf slice-2 status

This patch adds support to start tracking status of DBUF slices. This is foundation to introduce support for enabling/disabling second DBUF slice dynamically for ICL. Signed-off-by: Mahesh Kumar Reviewed-by: James Ausmus --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/3] drm/i915/icl: Enable 2nd DBuf slice only when needed

. Changes since V3: - Create a generic helper to enable/disable slice - don't return early if total_data_rate is 0, it may be cursor only commit, or atomic modeset without any plane. Changes since V3: - Solve checkpatch warnings - use kernel types u8/u64 instead of uint8_t/uint64_t Sign

[Intel-gfx] [PATCH 1/3] drm/i915/icl: track dbuf slice-2 status

This patch adds support to start tracking status of DBUF slices. This is foundation to introduce support for enabling/disabling second DBUF slice dynamically for ICL. Changes Since V1: - use kernel type u8 over uint8_t Signed-off-by: Mahesh Kumar Reviewed-by: James Ausmus --- drivers/gpu/drm

[Intel-gfx] [PATCH 3/3] drm/i915/icl: update ddb entry start/end mask during hw ddb readout

f-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_pm.c | 18 ++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 176dca6554f4..e3a6c535617d 100644 --- a/dri

[Intel-gfx] [PATCH 0/3] Optimize use of DBuf slices

Patches in this series were originally part of series: https://patchwork.freedesktop.org/series/36993/ Reposting it here after rebase use kernel types u8/u16 etc instead of uint8_t Mahesh Kumar (3): drm/i915/icl: track dbuf slice-2 status drm/i915/icl: Enable 2nd DBuf slice only when needed

[Intel-gfx] [PATCH] drm/i915/skl+: ddb allocation algorithm optimization

mark level for each plane in crtc, for efficient power saving. This algorithm uses fix ddb allocation for cursor planes. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 326 ++-- 2 files changed, 184

[Intel-gfx] [PATCH] drm/i915/icl: fix icl_unmap/map_plls_to_ports

All connectors may not have best_encoder attached, so don't dereference encoder pointer for each connector. Fixes: c27e917e2bda (drm/i915/icl: add basic support for the ICL clocks) Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_ddi.c | 6 -- 1 file changed, 4 insertions(

[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and need inputs Mahesh Kumar (10): drm: crc: Introduce verify_crc_source callback drm: crc: Introduce

[Intel-gfx] [PATCH 02/10] drm: crc: Introduce pre_crc_read function

This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/drm_debugfs_crc.c | 8 i

[Intel-gfx] [PATCH 09/10] drm/crc: Cleanup crtc_crc_open function

. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +- drivers/gpu/drm/drm_debugfs_crc.c | 52 +- drivers/gpu/drm/i915/intel_drv.h | 3 +- drivers

[Intel-gfx] [PATCH 05/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +++ drivers/gpu/drm/amd/display/amdgpu_dm/amdgp

[Intel-gfx] [PATCH 04/10] drm/rockchip/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rockchip drm driver. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/d

[Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar --- drive

[Intel-gfx] [PATCH 10/10] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh

[Intel-gfx] [PATCH 03/10] drm: crc: Introduce get_crc_sources callback

Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/drm_debugfs_crc.c | 3 +++ include/drm/drm_crtc.h| 10 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 2b4a737c5aeb..2751d124387d 100644 --- a/drive

[Intel-gfx] [PATCH 07/10] drm/i915/crc: implement verify_crc_source callback

This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_pipe_crc.c | 109

[Intel-gfx] [PATCH 08/10] drm/i915/crc: implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 06/10] drm/rcar-du/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/d

[Intel-gfx] [PATCH 00/10] Improve crc-core driver interface

ng-crc-pipe-X ig@kms_pipe_crc_basic@nonblocking-crc-pipe-X-frame-sequence In nonblocking crc tests we'll get lesser crc's due to skipping crc AMD/Rockchip/rcar code path is not validated and need inputs Changes: - Add dri-devel in Cc Mahesh Kumar (10): drm: crc: Introduce verify_crc

[Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node and while opening data node for crc reading. This will help in avoiding setting of wrong string for source. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freed

[Intel-gfx] [PATCH 02/10] drm: crc: Introduce pre_crc_read function

This patch implements a callback function "pre_crc_read" which will be called before crc read. In this function driver can implement and preparation work required for successfully reading CRC data. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drive

[Intel-gfx] [PATCH 03/10] drm: crc: Introduce get_crc_sources callback

Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_debugfs_crc.c | 3 +++ include/drm/drm_crtc.h| 10 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 2b

[Intel-gfx] [PATCH 04/10] drm/rockchip/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rockchip drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH 08/10] drm/i915/crc: implement get_crc_sources callback

This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Signed-off-by: Mahesh Kumar --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 07/10] drm/i915/crc: implement verify_crc_source callback

This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_pipe_crc.c

[Intel-gfx] [PATCH 05/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 4 drivers/g

[Intel-gfx] [PATCH 10/10] Revert "drm: crc: Wait for a frame before returning from open()"

This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kuma

[Intel-gfx] [PATCH 06/10] drm/rcar-du/crc: Implement verify_crc_source callback

This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH 09/10] drm/crc: Cleanup crtc_crc_open function

. Signed-off-by: Mahesh Kumar Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +- drivers/gpu/drm/drm_debugfs_crc.c | 52 +- drivers/gpu/drm/i915/intel_drv.h

Re: [Intel-gfx] [PATCH 2/4] drm/i915/skl+: calculate ddb minimum allocation (v5)

On Friday 27 May 2016 03:43 AM, Matt Roper wrote: From: "Kumar, Mahesh" don't always use 8 ddb as minimum, instead calculate using proper algorithm. v2: optimizations as per Matt's comments. v3 (by Matt): - Fix boolean logic for !fb test in skl_ddb_min_alloc() - Adjust negative tiling f

Re: [Intel-gfx] [PATCH 3/4] drm/i915/skl+: calculate plane pixel rate (v4)

Reviewed-by: Kumar Mahesh On Tuesday 17 May 2016 04:22 AM, Matt Roper wrote: From: "Kumar, Mahesh" Don't use pipe pixel rate for plane pixel rate. Calculate plane pixel according to formula adjusted plane_pixel_rate = adjusted pipe_pixel_rate * downscale ammount downscale amount = max[1, sr

Re: [Intel-gfx] [PATCH 4/4] drm/i915/skl+: Use scaling amount for plane data rate calculation (v4)

Reviewed-by: Kumar Mahesh On Friday 20 May 2016 03:33 AM, Matt Roper wrote: From: "Kumar, Mahesh" if downscaling is enabled plane data rate increases according to scaling amount. take scaling amount under consideration while calculating plane data rate v2: Address Matt's comments, where data

Re: [Intel-gfx] [PATCH 2/4] drm/i915/skl+: calculate ddb minimum allocation (v6)

Reviewed-by: Kumar Mahesh On Tuesday 31 May 2016 10:28 PM, Matt Roper wrote: From: "Kumar, Mahesh" don't always use 8 ddb as minimum, instead calculate using proper algorithm. v2: optimizations as per Matt's comments. v3 (by Matt): - Fix boolean logic for !fb test in skl_ddb_min_alloc()

<    1   2   3   4   5   >