Hi Jeremy,
On Fri, May 20, 2011 at 08:06:20PM -0500, Jeremy Bush wrote:
Hello,
I posted something similar to this on the ALSA mailing list, but they
directed me here, since HDMI detection has to do with the video driver
instead of ALSA.
Right.
I have my machine hooked up to an Onkyo
On Mon, 1 Aug 2011 21:51:40 +0800, Wu Fengguang fengguang...@intel.com
wrote:
1) intel_write_eld() is not called at all
It seems we need to call intel_write_eld() in other places besides
inside -mode_set(). Is -detect() the right place to do so? In
other words
: Bossart, Pierre-louis pierre-louis.boss...@intel.com
Signed-off-by: Ben Skeggs bske...@redhat.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/drm_edid.c | 171 +
drivers/gpu/drm/i915/i915_drv.h |2
drivers/gpu/drm/i915
Keith: this version completes the IvyBridge support :)
Bossart: hotplug is working fine now, with some minor issues:
- on G45, monitor hot removal is not handled at all in
i915_driver_irq_handler(). I'll leave it as a future TODO.
- on IvyBridge, _repeated_ plug/unplug will trigger
[
...@intel.com
CC: Jeremy Bush contractfrombe...@gmail.com
CC: Christopher White c.wh...@pulseforce.com
CC: Bossart, Pierre-louis pierre-louis.boss...@intel.com
Signed-off-by: Ben Skeggs bske...@redhat.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/drm_edid.c | 171
and Wu :)
Am Sonntag, den 04.09.2011, 05:15 +0800 schrieb Wu Fengguang:
Changes from v4: remove a debug call to dump_stack().
Thanks to Bossart for catching this!
His first name is Pierre-Louis. I do not know how you address people at
Intel though.
Thanks for the reminding!
---
I
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote:
On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang fengguang...@intel.com
wrote:
Changes from v4: remove a debug call to dump_stack().
Thanks to Bossart for catching this!
---
Add ELD support for Intel Eaglelake, IbexPeak
On Sun, Sep 04, 2011 at 06:57:23PM +0800, James Cloos wrote:
WF == Wu Fengguang fengguang...@intel.com writes:
WF ... If only the stereo playback capability is reported, the user
WF won't be able to start 8-channel playback; if the 8-channel ELD is
WF reported, then user space applications
pierre-louis.boss...@intel.com
CC: Paul Menzel paulepan...@users.sourceforge.net
CC: James Cloos cl...@jhcloos.com
CC: Chris Wilson ch...@chris-wilson.co.uk
Signed-off-by: Ben Skeggs bske...@redhat.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/drm_edid.c | 171
zhenyu.z.w...@intel.com
CC: Jeremy Bush contractfrombe...@gmail.com
CC: Christopher White c.wh...@pulseforce.com
CC: Pierre-Louis Bossart pierre-louis.boss...@intel.com
CC: Paul Menzel paulepan...@users.sourceforge.net
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915
I'd like to do more cleanups:
+ int aud_cntl_st;
+ int aud_cntrl_st2;
s/aud_cntrl_st2/aud_cntl_st2/
+ if (IS_IVYBRIDGE(connector-dev)) {
+ hdmiw_hdmiedid = GEN7_HDMIW_HDMIEDID_A;
+ aud_cntl_st = GEN7_AUD_CNTRL_ST_A;
+ aud_cntrl_st2 =
...@intel.com
CC: Wang Zhenyu zhenyu.z.w...@intel.com
CC: Jeremy Bush contractfrombe...@gmail.com
CC: Christopher White c.wh...@pulseforce.com
CC: Paul Menzel paulepan...@users.sourceforge.net
CC: Pierre-Louis Bossart pierre-louis.boss...@intel.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
On Mon, Sep 05, 2011 at 07:04:50PM +0800, Chris Wilson wrote:
On Mon, 5 Sep 2011 09:14:00 +0800, Wu Fengguang fengguang...@intel.com
wrote:
On Sun, Sep 04, 2011 at 08:08:37PM +0800, Chris Wilson wrote:
On Sun, 4 Sep 2011 05:15:10 +0800, Wu Fengguang fengguang...@intel.com
wrote
Hi Christopher,
The log does confirm that the drm_edid_to_eld function is running, and
that we're not far from a solution:
[ 21.061417] [drm:drm_edid_to_eld], ELD monitor TX-SR607
[ 21.061421] [drm:drm_edid_to_eld], ELD size 13, SAD count 8
It looks all sane to this point.
As for
Hi Sander,
On Tue, Nov 1, 2011 at 8:45 PM, Wu Fengguang fengguang...@intel.com wrote:
Hi Christopher,
The log does confirm that the drm_edid_to_eld function is running, and
that we're not far from a solution:
[ 21.061417] [drm:drm_edid_to_eld], ELD monitor TX-SR607
[ 21.061421
SandyBridge should be using the same register addresses as IvyBridge.
btw, rename the register names accordingly.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h |6 +++---
drivers/gpu/drm/i915/intel_display.c | 10 +-
2 files changed, 8
:23AM +0800, Christopher White wrote:
There appears to be some issues with the patch? I'm on SandyBridge and
using the HD3000's HDMI.
I've now tried manually merging the ELD patch (both files Wu Fengguang
submitted) and compiling Kernel 3.0.4. I've also tried drm-intel-next
Kernel 3.1 pre
Hi Takashi,
I enumerated all the DELL DisplayPort monitors in our lab and find
only two of them being able to produce audible DisplayPort audio...
- DELL 2408WFP
- DELL 2709W
- DELL 3008WFP
no CEA extension found
- DELL U2410
ELD reports OK but cannot hear DP sound
Here are the EDID for the DELL monitors, grabbed by command
cp /sys/class/drm/card0-DP-3/edid .
Thanks,
Fengguang
On Wed, Nov 09, 2011 at 03:20:53PM +0800, Wu Fengguang wrote:
Hi Takashi,
I enumerated all the DELL DisplayPort monitors in our lab and find
only two of them being able
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:35.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35
Christopher,
The dump tool did not work with that environment variable either.
However, it occurred to me that intel_audio_dump may be too outdated in
my distro. It was built on 2010-04-01, v1.0.2+git20100324. If I look at
http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ I can see that
Wow I reproduced the bug and got a very interesting dmesg:
gfx =[ 4561.287980] [drm:intel_write_eld], ELD on
[CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11]
gfx =[ 4561.291730] [drm:ironlake_write_eld], ELD on pipe B
gfx =[ 4561.293804] [drm:ironlake_write_eld], Audio
On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote:
Wow I reproduced the bug and got a very interesting dmesg:
gfx =[ 4561.287980] [drm:intel_write_eld], ELD on
[CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11]
gfx =[ 4561.291730] [drm:ironlake_write_eld], ELD on pipe
On Thu, Nov 10, 2011 at 03:55:22PM +0800, Wu Fengguang wrote:
On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote:
Wow I reproduced the bug and got a very interesting dmesg:
gfx =[ 4561.287980] [drm:intel_write_eld], ELD on
[CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11
On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote:
On 11/10/11 12:22 PM, Takashi Iwai wrote:
At Thu, 10 Nov 2011 12:00:53 +0100,
Christopher White wrote:
On 11/10/11 9:55 AM, Christopher White wrote:
On 11/10/11 8:55 AM, Wu Fengguang wrote:
On Thu, Nov 10, 2011 at 03:33
On Thu, Nov 10, 2011 at 09:01:24PM +0800, Christopher White wrote:
On 11/10/11 1:56 PM, Wu Fengguang wrote:
On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote:
On 11/10/11 12:22 PM, Takashi Iwai wrote:
At Thu, 10 Nov 2011 12:00:53 +0100,
Christopher White wrote:
On 11/10
Got the delay - it's 72.986623-72.747632 = 239ms.
[ 72.739944] HDMI hot plug event: Codec=3 Pin=6
Presence_Detect=1 ELD_Valid=0
[ 72.742541] HDMI status: Codec=3 Pin=6 Presence_Detect=1
ELD_Valid=0
[ 72.745082] HDMI hot plug event: Codec=3 Pin=6
On Thu, Nov 10, 2011 at 09:47:46PM +0800, Wu Fengguang wrote:
Got the delay - it's 72.986623-72.747632 = 239ms.
[ 72.739944] HDMI hot plug event: Codec=3 Pin=6
Presence_Detect=1 ELD_Valid=0
[ 72.742541] HDMI status: Codec=3 Pin=6 Presence_Detect=1
On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote:
At Thu, 10 Nov 2011 21:51:50 +0800,
Wu Fengguang wrote:
So maybe the hardware is in some state that is unable to provide the
real ELD content?
That's my guess as well. I think the hardware may still be doing some
, according to your comments, here is the patch, tested OK on
HDMI :) DP not tested yet.
This notifies the audio driver of the HDMI/DP monitor hot removal
event.
- clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
- clear ELD Valid bit
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers
On Fri, Nov 11, 2011 at 04:49:57PM +0800, Takashi Iwai wrote:
At Fri, 11 Nov 2011 16:22:41 +0800,
Wu Fengguang wrote:
On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote:
At Fri, 11 Nov 2011 10:29:25 +0800,
Wu Fengguang wrote:
On Thu, Nov 10, 2011 at 10:28:19PM +0800
On Fri, Nov 11, 2011 at 07:23:05PM +0800, Takashi Iwai wrote:
At Fri, 11 Nov 2011 19:12:57 +0800,
Wu Fengguang wrote:
(snip)
One note that we don't rely on PD bit because not all (non-Intel)
hardware report it correctly.
Oops. Do you imply ELDV is reliable on all
(snip)
And I'm not sure whether HDMI audio is played
while DPMS is off. I haven't tested it.
It will go silence on DPMS. I noticed this while doing long term HDMI
audio playback tests. This should better be fixed in future on the
graphics side.
Hm, but I wonder
A bunch of cleanups, fixes and new fields to intel_audio_dump, tested OK on
G45, Ironlake and IvyBridge.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
11:00:39.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c
Convert  (Hex 00ad) to - (Hex 2d), the former leads to ugly outputs
in some situations.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 70 ++---
1 file changed, 35 insertions(+), 35 deletions(-)
--- intel-gpu-tools.orig
The raw channel count is not user friendly and may be misleading.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
16:21
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:34.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10
- no need to show the 1-bit AUD_OUT_DIG_CNVT_* as hex value
- show the Connection_select_Control_* bits as hex values
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--- intel-gpu-tools.orig
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:35.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09
10:35:34.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 47 +
1 file changed, 27 insertions(+), 20 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:19:06.0 +0800
+++ intel-gpu-tools/tools
The original test mistakenly calls dump_cpt() for Ironlake,
due to HAS_PCH_SPLIT := IS_GEN5 || IS_GEN6 || IS_GEN7.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |8
1 file changed, 8 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:47.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |2 ++
1 file changed, 2 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:48.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:48.0
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:50.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |4
1 file changed, 4 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:50.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:50.0
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:46.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 27 ++-
1 file changed, 22 insertions(+), 5 deletions(-)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:39.0 +0800
+++ intel-gpu-tools/tools
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 47 +
1 file changed, 47 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
11:11:41.0 +0800
+++ intel-gpu-tools/tools
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 18 ++
1 file changed, 18 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:49.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
tools/intel_audio_dump.c | 30 ++
1 file changed, 30 insertions(+)
--- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12
10:52:40.0 +0800
+++ intel-gpu-tools/tools/intel_audio_dump.c
On Mon, Nov 14, 2011 at 10:05:05AM +0800, Zhenyu Wang wrote:
On 2011.11.11 16:50:41 +0800, Wu Fengguang wrote:
I still think you should do those in hot_plug(), to call detect() for
current
status, write eld and set specific audio enable/disable bit for all
audio stuff
On Mon, Nov 14, 2011 at 05:45:12PM +0800, Takashi Iwai wrote:
At Sat, 12 Nov 2011 10:27:26 +0800,
Wu Fengguang wrote:
(snip)
And I'm not sure whether HDMI audio is played
while DPMS is off. I haven't tested it.
It will go silence on DPMS. I noticed this while
memset(eld) clears eld-proc_entry which will leak the struct
snd_info_entry when unloading the module.
Fix it by
- remove memset(eld)
- set eld-eld_valid to true _after_ all eld fields have been filled
- don't access the other eld fields when (eld-eld_valid == false)
Signed-off-by: Wu Fengguang
-off-by: Wu Fengguang fengguang...@intel.com
---
sound/pci/hda/hda_local.h |2 +
sound/pci/hda/patch_hdmi.c | 49 ++-
2 files changed, 44 insertions(+), 7 deletions(-)
--- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0
+0800
On Tue, Nov 15, 2011 at 10:45:15PM +0800, Takashi Iwai wrote:
At Tue, 15 Nov 2011 22:41:16 +0800,
Wu Fengguang wrote:
On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote:
At Tue, 15 Nov 2011 22:31:55 +0800,
Wu Fengguang wrote:
memset(eld) clears eld-proc_entry which
- if (eld_valid)
+ if (eld_valid) {
if (!snd_hdmi_get_eld(eld, codec, pin_nid))
snd_hdmi_show_eld(eld);
+ else {
Oops, forgot testing @retry here! Updated patch follows.
+ queue_delayed_work(codec-bus-workq,
+
-off-by: Wu Fengguang fengguang...@intel.com
---
sound/pci/hda/hda_local.h |2 +
sound/pci/hda/patch_hdmi.c | 49 ++-
2 files changed, 44 insertions(+), 7 deletions(-)
--- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0
+0800
On Wed, Nov 16, 2011 at 01:10:37AM +0800, Takashi Iwai wrote:
At Wed, 16 Nov 2011 00:57:08 +0800,
Wu Fengguang wrote:
+static void hda_eld_work(struct work_struct *work)
+{
+ struct hdmi_eld *eld = container_of(
+ container_of(work, struct delayed_work, work
On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote:
Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM:
The Intel HDMI chips (ironlake at least) are found to have ~250ms delay
between the ELD_Valid=1 hotplug event is send and the ELD buffer becomes
actually readable
Keith,
Here are 3 fixes on HDMI/ELD audio.
The third one adds a -hot_remove hook to drm_connector_funcs. Please review.
[PATCH 1/3] drm/i915: fix ELD writing for SandyBridge
[PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD
[PATCH 3/3] drm/i915: hot removal notification to HDMI
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler nbow...@elliptictech.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h |6 +++---
drivers/gpu/drm/i915/intel_display.c | 10 +-
2 files changed, 8 insertions(+), 8 deletions
On monitor hot removal:
1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE
2) clear ELD Valid bit
So that the audio driver will receive hot plug events and take action to
refresh its device state and ELD contents.
cc: Wang Zhenyu zhenyu.z.w...@intel.com
Signed-off-by: Wu Fengguang fengguang
Sorry forgot to remove this left over chunk...
Note that I've not yet got the hardware to test the DisplayPort part
of this patch, but should be able to do so this week.
--- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16
20:54:27.0 +0800
+++
On monitor hot removal:
1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE
2) clear ELD Valid bit
So that the audio driver will receive hot plug events and take action to
refresh its device state and ELD contents.
cc: Wang Zhenyu zhenyu.z.w...@intel.com
Signed-off-by: Wu Fengguang fengguang
On Wed, Nov 16, 2011 at 11:51:28PM +0800, Stephen Warren wrote:
Wu Fengguang wrote at Tuesday, November 15, 2011 7:48 PM:
On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote:
Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM:
The Intel HDMI chips (ironlake at least
Below is the dmesg representing a video mode set.
ELD writes from the graphics driver
[ 424.254958] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2],
[ENCODER:11:TMDS-11]
[ 424.257670] [drm:ironlake_write_eld], ELD on pipe B
[ 424.259833]
in X, -mode_set won't be called at all. Only
-get_modes and -detect are called...
Thanks,
Fengguang
On Wed, Nov 16, 2011 at 09:35:48PM +0800, Wu Fengguang wrote:
Sorry forgot to remove this left over chunk...
Note that I've not yet got the hardware to test the DisplayPort part
of this patch
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang fengguang...@intel.com
wrote:
However when in X, -mode_set won't be called at all. Only
-get_modes and -detect are called...
The desktop software will call mode_set when
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang fengguang...@intel.com
wrote:
However when in X, -mode_set won't be called at all. Only
-get_modes and -detect are called...
The desktop software will call mode_set when
drm_edid_to_eld
-hotplug
intel_write_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On hot remove, the call sequence is
-hotplug
clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
cc: Wang Zhenyu zhenyu.z.w...@intel.com
Signed-off-by: Wu
On Mon, Nov 21, 2011 at 04:47:38PM +0800, Takashi Iwai wrote:
At Mon, 21 Nov 2011 09:58:09 +0800,
Wu Fengguang wrote:
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote:
On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang fengguang...@intel.com
wrote:
However when
On Tue, Nov 22, 2011 at 12:55:43AM +0800, Keith Packard wrote:
On Mon, 21 Nov 2011 14:37:49 +0800, Wu Fengguang fengguang...@intel.com
wrote:
On monitor hot plug/unplug, update ELD and set/clear SDVO_AUDIO_ENABLE
or DP_AUDIO_OUTPUT_ENABLE accordingly. So that the audio driver
intel_write_eld
set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
On hot remove, the call sequence is
-hotplug
clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE
cc: Wang Zhenyu zhenyu.z.w...@intel.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm
On Wed, Nov 23, 2011 at 02:25:14AM +0800, Keith Packard wrote:
On Tue, 22 Nov 2011 15:40:55 +0800, Wu Fengguang fengguang...@intel.com
wrote:
So the v3 patch will behave equally well on KMS console, gnome desktop
and bare X. Shall we just use it, or go back and use the original
On Thu, Nov 24, 2011 at 03:26:49AM +0800, Keith Packard wrote:
On Wed, 23 Nov 2011 16:29:58 +0800, Wu Fengguang fengguang...@intel.com
wrote:
What I need is a hot plug hook that knows whether the monitor is
plugged or removed, which is only possible if the hook is called
after -detect
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-24
08:09
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler nbow...@elliptictech.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers
Keith,
The 4 patches are well tested and integrates the review comments.
The only missing part is hot plug notification for DP -- most DP monitors in
the market don't support DP audio well. So I cannot test this for now.
Thanks,
Fengguang
___
zhenyu.z.w...@intel.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c |4 +++-
drivers/gpu/drm/i915/intel_hdmi.c |8 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/intel_hdmi.c2011-11-24
17
-by: Keith Packard kei...@keithp.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers
The only missing part is hot plug notification for DP -- most DP monitors in
the market don't support DP audio well. So I cannot test this for now.
btw, we'd like to buy a Philips 221P3LPYEB that _seems_ to have DP
audio support. I'd appreciate if any one can help confirm.
Thanks,
Fengguang
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Sorry, this moves some necessary changes from patch 2/4 to here
-by: Keith Packard kei...@keithp.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers
and set to Normal.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c |1 +
1 file changed, 1 insertion(+)
This works both on KMS console and gnome desktop.
Hot plug/unplug and DPMS on/off are all tested OK.
--- linux.orig/drivers/gpu/drm/i915/intel_dp.c 2011
Keith,
The complete set of fixes for passing HDMI/DP ELD to audio driver.
[PATCH 1/5] drm/i915: fix ELD writing for SandyBridge
[PATCH 2/5] drm/i915: rename audio ELD registers
[PATCH 3/5] drm/i915: dont trigger hotplug events on unchanged ELD
[PATCH 4/5] drm/i915: HDMI hot remove
-by: Keith Packard kei...@keithp.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h | 22 +++---
drivers/gpu/drm/i915/intel_display.c | 22 +++---
2 files changed, 22 insertions(+), 22 deletions(-)
--- linux.orig/drivers
The ELD may or may not change when switching the video mode.
If unchanged, don't trigger hot plug events to HDMI audio driver.
This avoids disturbing the user with repeated printks.
Reported-by: Nick Bowler nbow...@elliptictech.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers
SandyBridge should be using the same register addresses as IvyBridge.
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
--- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-28
On Mon, Nov 28, 2011 at 04:06:37PM +0800, Wu Fengguang wrote:
The only missing part is hot plug notification for DP -- most DP monitors in
the market don't support DP audio well. So I cannot test this for now.
btw, we'd like to buy a Philips 221P3LPYEB that _seems_ to have DP
audio support
Hi,
I managed to trigger the below BUG_ON when switching modes in an IvyBridge box.
i915_wait_request():
BUG_ON(seqno == 0);
The call trace is at the bottom of the following dmesg. Any ideas?
Thanks,
Fengguang
---
[ 554.872849] [drm:drm_mode_getconnector], [CONNECTOR:6:?]
[
Hi Andrea,
On Fri, Dec 30, 2011 at 08:07:27PM +0100, Andrea Arcangeli wrote:
Hi,
after upgrading my HTPC to HD3000 graphics (2700K), I didn't find
anymore a way to disable the hdmi audio from the DVI2HDMI cable (I
connect DVI output of the motherboard to the HDMI input of the LCDTV
in HD).
On Sat, Dec 31, 2011 at 01:20:11PM +0100, Andrea Arcangeli wrote:
On Sat, Dec 31, 2011 at 09:28:37AM +0800, Wu Fengguang wrote:
Hi Andrea,
On Fri, Dec 30, 2011 at 08:07:27PM +0100, Andrea Arcangeli wrote:
Hi,
after upgrading my HTPC to HD3000 graphics (2700K), I didn't find
. Since
the DVI mode is mainly tied to audio functionality from end user POV,
add a new off-dvi audio mode:
xrandr --output HDMI1 --set audio off-dvi
Reported-by: Andrea Arcangeli aarca...@redhat.com
Signed-off-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_drv.h
On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote:
On Fri, 6 Jan 2012 11:26:40 +0800
Wu Fengguang fengguang...@intel.com wrote:
Andrea,
Would you test this patch at convenient time?
Thanks,
Fengguang
---
Subject: drm/i915: add an off-dvi HDMI audio mode
Date
On Fri, Jan 06, 2012 at 05:12:57PM +0100, Andrea Arcangeli wrote:
On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote:
A better name might be off-dvi-mode or off-dvi-only or something.
force-dvi is probably better name, off is counter intuitive.
Yeah, force-dvi looks good!
I
-by: Wu Fengguang fengguang...@intel.com
---
drivers/gpu/drm/i915/i915_reg.h |3 +++
drivers/gpu/drm/i915/intel_display.c |5 +
2 files changed, 8 insertions(+)
--- linux.orig/drivers/gpu/drm/i915/i915_reg.h 2012-01-06 15:00:55.0
+0800
+++ linux/drivers/gpu/drm/i915
On Mon, Jan 09, 2012 at 09:22:47AM -0800, Keith Packard wrote:
On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang fengguang...@intel.com
wrote:
+#define IBX_AUD_CONFIG_A 0xe2000
+#define CPT_AUD_CONFIG_A 0xe5000
These register addresses match the docs
1 - 100 of 110 matches
Mail list logo