Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Morton, Derek J
p.org >Subject: Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, >tests/: Add Werror by default. > >On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote: >> On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: >> > Easier to catch

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Damien Lespiau
On Mon, May 09, 2016 at 06:55:12PM +0300, Marius Vlad wrote: > > Adding a test (with patchwork integration!) that ensures each commit > > posted on this mailing-list compiles without new warning with a chosen > > toolchain (and even passes distcheck!) would be nice. > We have this for check and

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Marius Vlad
On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote: > On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > > Easier to catch compilation errors. > > > Having -Werror by default is a no go as you cannot control/predict the > set of warnings (and the quality of those) of all

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Damien Lespiau
On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > Easier to catch compilation errors. Having -Werror by default is a no go as you cannot control/predict the set of warnings (and the quality of those) of all previous and future gcc/clang versions. Always using this flag will cause

[Intel-gfx] [PATCH i-g-t] benchmarks/, overlay/, demos/, tools/, tests/: Add Werror by default.

2016-05-09 Thread Marius Vlad
Easier to catch compilation errors. Signed-off-by: Marius Vlad --- benchmarks/Makefile.am | 2 +- demos/Makefile.am | 3 ++- overlay/Makefile.am| 3 ++- tests/Makefile.am | 2 +- tools/Makefile.am | 4 +++- 5 files changed, 9 insertions(+), 5