Re: [Intel-wired-lan] [PATCH 8/9] ice: restore timestamp configuration after reset

2023-10-27 Thread Jacob Keller
On 8/7/2023 3:36 AM, Karol Kolacinski wrote: > The driver calls ice_ptp_cfg_timestamp() during > ice_ptp_prepare_for_reset() to disable timestamping while the device is > resetting. It then attempts to restore timestamp configuration at the > end of ice_rebuild(). However, it currently forcibly

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] ethtool: Implement ethtool_puts()

2023-10-27 Thread Andrew Lunn
> +/** > + * ethtool_puts - Write string to ethtool string data > + * @data: Pointer to start of string to update Isn't it actually a pointer to a pointer to the start of string to update? > +extern void ethtool_puts(u8 **data, const char *str); Andrew

Re: [Intel-wired-lan] [PATCH net-next v3 3/3] net: Convert some ethtool_sprintf() to ethtool_puts()

2023-10-27 Thread Andrew Lunn
On Fri, Oct 27, 2023 at 10:05:35PM +, Justin Stitt wrote: > This patch converts some basic cases of ethtool_sprintf() to > ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > | ethtool_sprintf(, buffer[i].name); > or

Re: [Intel-wired-lan] [PATCH next v2 2/3] checkpatch: add ethtool_sprintf rules

2023-10-27 Thread Joe Perches
On 2023-10-27 12:40, Justin Stitt wrote: Yeah you can push it but it's not really a standalone so perhaps I'll just steal the diff and wrap into v3? Fine by me. No need for my sign off. ___ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org

Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps

2023-10-27 Thread Jacob Keller
On 10/26/2023 3:59 AM, Karol Kolacinski wrote: > From: Jacob Keller > > The ice driver currently discards any outstanding timestamps that are > happening very near to a .adjtime or .settime callback. This was > originally added by commit b1a582e64bf2 ("ice: introduce >

Re: [Intel-wired-lan] [PATCH net-next] iavf: use iavf_schedule_aq_request() helper

2023-10-27 Thread Jacob Keller
On 10/27/2023 2:51 AM, Petr Oros wrote: > Use the iavf_schedule_aq_request() helper when we need to > schedule a watchdog task immediately. No functional change. > > Signed-off-by: Petr Oros > --- This does not apply as-is to Intel Wired LAN dev-queue. I have no objection to netdev taking

Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps

2023-10-27 Thread Jacob Keller
On 10/26/2023 3:59 AM, Karol Kolacinski wrote: > -/** > - * ice_ptp_flush_all_tx_tracker - Flush all timestamp trackers on this clock > - * @pf: Board private structure > - * > - * Called by the clock owner to flush all the Tx timestamp trackers > associated > - * with the clock. > - */ >

Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove unnecessary discarding of timestamps

2023-10-27 Thread Jacob Keller
On 10/26/2023 3:59 AM, Karol Kolacinski wrote: > From: Jacob Keller > > The ice driver currently discards any outstanding timestamps that are > happening very near to a .adjtime or .settime callback. This was > originally added by commit b1a582e64bf2 ("ice: introduce >

Re: [Intel-wired-lan] [PATCH net-next] iavf: use iavf_schedule_aq_request() helper

2023-10-27 Thread Wojciech Drewek
On 27.10.2023 11:51, Petr Oros wrote: > Use the iavf_schedule_aq_request() helper when we need to > schedule a watchdog task immediately. No functional change. > > Signed-off-by: Petr Oros > --- Reviewed-by: Wojciech Drewek > drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 10 +++---

[Intel-wired-lan] [PATCH net-next] iavf: use iavf_schedule_aq_request() helper

2023-10-27 Thread Petr Oros
Use the iavf_schedule_aq_request() helper when we need to schedule a watchdog task immediately. No functional change. Signed-off-by: Petr Oros --- drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 10 +++--- drivers/net/ethernet/intel/iavf/iavf_main.c| 15 +-- 2 files