Re: [Intel-wired-lan] [PATCH v8 iwl-next 00/12] Introduce ETH56G PHY model for E825C products

2024-04-16 Thread Tony Nguyen
On 4/12/2024 6:06 AM, Karol Kolacinski wrote: E825C products have a different PHY model than E822, E823 and E810 products. This PHY is ETH56G and its support is necessary to have functional PTP stack for E825C products. Can you clean up the new kernel-doc (-Wall) issues that these patches are

Re: [Intel-wired-lan] [PATCH iwl-next v4 00/12] Add support for Rx timestamping for both ice and iavf drivers.

2024-04-16 Thread Tony Nguyen
On 4/10/2024 5:16 AM, Mateusz Polchlopek wrote: Initially, during VF creation it registers the PTP clock in the system and negotiates with PF it's capabilities. In the meantime the PF enables the Flexible Descriptor for VF. Only this type of descriptor allows to receive Rx timestamps. Enablin

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex

2024-04-16 Thread Brelinski, Tony
> -Original Message- > From: Intel-wired-lan On Behalf Of > Erwan Velu > Sent: Tuesday, March 19, 2024 7:17 AM > Cc: Velu, Erwan ; linux-ker...@vger.kernel.org; Eric > Dumazet ; net...@vger.kernel.org; Nguyen, > Anthony L ; intel-wired-...@lists.osuosl.org; > Jakub Kicinski ; Paolo Abeni ;

Re: [Intel-wired-lan] [PATCH net] igc: Fix LED-related deadlock on driver unbind

2024-04-16 Thread Lukas Wunner
On Tue, Apr 16, 2024 at 04:06:49PM +0200, Kurt Kanzenbach wrote: > On Mon Apr 15 2024, Lukas Wunner wrote: > > Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226") > > Reported-by: Roman Lozko > > Closes: > > https://lore.kernel.org/r/CAEhC_B=ksywxcg_+aqqxurgegkq+4mqnsv8ebhokbc3-obj...@

Re: [Intel-wired-lan] [PATCH net-next v2 07/15] mm: page_frag: add '_va' suffix to page_frag API

2024-04-16 Thread Alexander H Duyck
On Mon, 2024-04-15 at 21:19 +0800, Yunsheng Lin wrote: > Currently most of the API for page_frag API is returning > 'virtual address' as output or expecting 'virtual address' > as input, in order to differentiate the API handling between > 'virtual address' and 'struct page', add '_va' suffix to th

Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-16 Thread Jakub Kicinski
On Mon, 15 Apr 2024 13:15:41 +0300 Lifshits, Vitaly wrote: > Thank you for this patch and this observation. > I think that you found a real misbehaviour in the original patch. > However, I still think that forcing SMBUS functionality shouldn't be > part of the ULP enabling flow, since they are two

Re: [Intel-wired-lan] [PATCH iwl-next v5] ice: Add automatic VF reset on Tx MDD events

2024-04-16 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of Simon > Horman > Sent: Monday, April 8, 2024 3:32 PM > To: Marcin Szycik > Cc: Loktionov, Aleksandr ; Drewek, Wojciech > ; net...@vger.kernel.org; Chmielewski, Pawel > ; Nguyen, Anthony L > ; Wang, Liang-min ; > Kitszel, Przemyslaw

[Intel-wired-lan] [PATCH iwl-next] igb: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags. Use flow_rule_match_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_match_has_control_flags() sets a NL extended error message, and we

[Intel-wired-lan] [PATCH iwl-next] ice: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags. Use flow_rule_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOP

[Intel-wired-lan] [PATCH iwl-next] i40e: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags. Use flow_rule_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOP

[Intel-wired-lan] [PATCH iwl-next] iavf: flower: validate control flags

2024-04-16 Thread Asbjørn Sloth Tønnesen
This driver currently doesn't support any control flags. Use flow_rule_has_control_flags() to check for control flags, such as can be set through `tc flower ... ip_flags frag`. In case any control flags are masked, flow_rule_has_control_flags() sets a NL extended error message, and we return -EOP

Re: [Intel-wired-lan] [PATCH net] igc: Fix LED-related deadlock on driver unbind

2024-04-16 Thread Kurt Kanzenbach
On Mon Apr 15 2024, Lukas Wunner wrote: > Roman reports a deadlock on unplug of a Thunderbolt docking station > containing an Intel I225 Ethernet adapter. > > The root cause is that led_classdev's for LEDs on the adapter are > registered such that they're device-managed by the netdev. That > resul

Re: [Intel-wired-lan] [PATCH net] igc: Fix LED-related deadlock on driver unbind

2024-04-16 Thread Simon Horman
On Mon, Apr 15, 2024 at 03:48:48PM +0200, Lukas Wunner wrote: > Roman reports a deadlock on unplug of a Thunderbolt docking station > containing an Intel I225 Ethernet adapter. > > The root cause is that led_classdev's for LEDs on the adapter are > registered such that they're device-managed by th

Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Fix deadlock on module removal

2024-04-16 Thread Simon Horman
On Mon, Apr 15, 2024 at 12:59:37PM +0200, Kurt Kanzenbach wrote: > From: Lukas Wunner > > The removal of the igc module leads to a deadlock: > > |[Mon Apr 8 17:38:55 2024] __mutex_lock.constprop.0+0x3e5/0x7a0 > |[Mon Apr 8 17:38:55 2024] ? preempt_count_add+0x85/0xd0 > |[Mon Apr 8 17:38:55

[Intel-wired-lan] [PATCH iwl-net] ice: Interpret .set_channels() input differently

2024-04-16 Thread Larysa Zaremba
A bug occurs because a safety check guarding AF_XDP-related queues in ethnl_set_channels(), does not trigger. This happens, because kernel and ice driver interpret the ethtool command differently. How the bug occurs: 1. ethtool -l -> combined: 40 2. Attach AF_XDP to queue 30 3. ethtool -L rx 15

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-16 Thread Jiri Pirko
Tue, Apr 16, 2024 at 08:16:17AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Tue, Apr 16, 2024 at 07:14:43AM +0200, Michal Swiatkowski wrote: >> On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote: >> > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com >> > wro

Re: [Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup

2024-04-16 Thread Simon Horman
On Mon, Apr 15, 2024 at 10:49:07AM +0200, Marcin Szycik wrote: > ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost > identical, except for setting filter action. Reduce them to one function > with an extra param, which handles both cases. > > Reviewed-by: Mateusz Polchlope

Re: [Intel-wired-lan] [PATCH v6 09/11] pps: generators: Add PPS Generator TIO Driver

2024-04-16 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 11, 2024 3:59 AM > To: D, Lakshmi Sowjanya ; > jstu...@google.com; giome...@enneenne.com; cor...@lwn.net; linux- > ker...@vger.kernel.org > Cc: x...@kernel.org; net...@vger.kernel.org; linux-...@vger.kernel.org; intel-

Re: [Intel-wired-lan] [PATCH v6 08/11] timekeeping: Add function to convert realtime to base clock

2024-04-16 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 11, 2024 3:46 AM > To: D, Lakshmi Sowjanya ; > jstu...@google.com; giome...@enneenne.com; cor...@lwn.net; linux- > ker...@vger.kernel.org > Cc: x...@kernel.org; net...@vger.kernel.org; linux-...@vger.kernel.org; intel-

Re: [Intel-wired-lan] [PATCH v6 01/11] x86/tsc: Add base clock properties in clocksource structure

2024-04-16 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 11, 2024 3:03 AM > To: D, Lakshmi Sowjanya ; > jstu...@google.com; giome...@enneenne.com; cor...@lwn.net; linux- > ker...@vger.kernel.org > Cc: x...@kernel.org; net...@vger.kernel.org; linux-...@vger.kernel.org; intel-

Re: [Intel-wired-lan] [PATCH v6 01/11] x86/tsc: Add base clock properties in clocksource structure

2024-04-16 Thread D, Lakshmi Sowjanya
> -Original Message- > From: Thomas Gleixner > Sent: Thursday, April 11, 2024 2:51 AM > To: D, Lakshmi Sowjanya ; > jstu...@google.com; giome...@enneenne.com; cor...@lwn.net; linux- > ker...@vger.kernel.org > Cc: x...@kernel.org; net...@vger.kernel.org; linux-...@vger.kernel.org; intel-