Re: [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers.

2024-04-22 Thread Mateusz Polchlopek
On 4/23/2024 7:57 AM, Rahul Rameshbabu wrote: On Mon, 22 Apr, 2024 11:37:14 +0200 Mateusz Polchlopek wrote: On 4/18/2024 10:19 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:48 -0400 Mateusz Polchlopek wrote: Initially, during VF creation it registers the PTP clock in the system

Re: [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers.

2024-04-22 Thread Rahul Rameshbabu
On Mon, 22 Apr, 2024 11:37:14 +0200 Mateusz Polchlopek wrote: > On 4/18/2024 10:19 PM, Rahul Rameshbabu wrote: >> On Thu, 18 Apr, 2024 01:24:48 -0400 Mateusz Polchlopek >> wrote: >>> Initially, during VF creation it registers the PTP clock in >>> the system and negotiates with PF it's capabili

[Intel-wired-lan] Fw: [Bug 218761] New: e1000e: One core of cpu reach 100% usage, after connecting ethernet.

2024-04-22 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 22 Apr 2024 18:39:38 + From: bugzilla-dae...@kernel.org To: step...@networkplumber.org Subject: [Bug 218761] New: e1000e: One core of cpu reach 100% usage, after connecting ethernet. https://bugzilla.kernel.org/show_bug.cgi?id=218761 Bug I

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] ixgbe: Add support for E610 device capabilities detection

2024-04-22 Thread Simon Horman
On Mon, Apr 22, 2024 at 10:41:47AM +, Kwapulinski, Piotr wrote: > >-Original Message- > >From: Simon Horman > >Sent: Saturday, April 20, 2024 8:18 PM > >To: Kwapulinski, Piotr > >Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Gomes, > >Vinicius ; Wegrzyn, Stefan > >;

[Intel-wired-lan] [PATCH 5/5] drivers/s390/cio: ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
Currently, we allocate a lbuf-sized kernel buffer and copy lbuf from userspace to that buffer. Later, we use scanf on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using scanf. Fix this issue by allocating 1 more byte to at the end o

[Intel-wired-lan] [PATCH 4/5] drivers/scsi/qedf: ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
Currently, we allocate a count-sized kernel buffer and copy count from userspace to that buffer. Later, we use kstrtouint on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using kstrtouint. Fix this issue by using memdup_user_nul inst

[Intel-wired-lan] [PATCH 3/5] drivers/scsi/bfa/bfad: ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from userspace to that buffer. Later, we use sscanf on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using sscanf. Fix this issue by using memdup_user_nul instead of

[Intel-wired-lan] [PATCH 2/5] drivers/net/brocade-bnad: ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
Currently, we allocate a nbytes-sized kernel buffer and copy nbytes from userspace to that buffer. Later, we use sscanf on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using sscanf. Fix this issue by using memdup_user_nul instead of

[Intel-wired-lan] [PATCH 1/5] drivers/net/ethernet/intel-ice: ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
Currently, we allocate a count-sized kernel buffer and copy count bytes from userspace to that buffer. Later, we use sscanf on this buffer but we don't ensure that the string is terminated inside the buffer, this can lead to OOB read when using sscanf. Fix this issue by using memdup_user_nul instea

[Intel-wired-lan] [PATCH 0/5] Ensure the copied buf is NULL terminated

2024-04-22 Thread Bui Quang Minh
/qedf/qedf_debugfs.c| 2 +- 5 files changed, 11 insertions(+), 10 deletions(-) --- base-commit: ed30a4a51bb196781c8058073ea720133a65596f change-id: 20240422-fix-oob-read-19ae7f8f3711 Best regards, -- Bui Quang Minh

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-22 Thread Jiri Pirko
Mon, Apr 22, 2024 at 03:06:11PM CEST, piotr.kwapulin...@intel.com wrote: [...] >diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >b/drivers/net/ethernet/intel/ixgbe/ixgbe.h >index 559b443..ea6df1e 100644 >--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >+++ b/drivers/net/ethernet/intel/ixgb

Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS

2024-04-22 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Erwan Velu > Sent: Friday, April 19, 2024 8:10 PM > To: Pucha, HimasekharX Reddy > Subject: Re: [Intel-wired-lan] [PATCH v4 iwl-net] i40e: Prevent setting MTU > if greater than MFS > > Hum that's pretty unexpected. >Can you print "new_mtu" and "max_mtu" in

Re: [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support

2024-04-22 Thread Jiri Pirko
Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkow...@linux.intel.com wrote: >Hi, > >This is a series to prepare port representor for supporting also >subfunctions. We need correct devlink locking and the possibility to >update parent VSI after port representor is created. > >Refactor how devlin

[Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-22 Thread Piotr Kwapulinski
Add high level link management support for E610 device. Enable the following features: - driver load - bring up network interface - IP address assignment - pass traffic - show statistics (e.g. via ethtool) - disable network interface - driver unload Co-developed-by: Carolyn Wyborny Signed-off-by:

[Intel-wired-lan] [PATCH iwl-next v4 4/5] ixgbe: Add support for NVM handling in E610 device

2024-04-22 Thread Piotr Kwapulinski
Add low level support for accessing NVM in E610 device. NVM operations are handled via the Admin Command Interface. Add the following NVM specific operations: - acquire, release, read - validate checksum - read shadow ram Co-developed-by: Stefan Wegrzyn Signed-off-by: Stefan Wegrzyn Co-developed

[Intel-wired-lan] [PATCH iwl-next v4 3/5] ixgbe: Add link management support for E610 device

2024-04-22 Thread Piotr Kwapulinski
Add low level link management support for E610 device. Link management operations are handled via the Admin Command Interface. Add the following link management operations: - get link capabilities - set up link - get media type - get link status, link status events - link power management Co-devel

[Intel-wired-lan] [PATCH iwl-next v4 2/5] ixgbe: Add support for E610 device capabilities detection

2024-04-22 Thread Piotr Kwapulinski
Add low level support for E610 device capabilities detection. The capabilities are discovered via the Admin Command Interface. Discover the following capabilities: - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom, reset - device caps: vsi, fdir, 1588 - phy caps Co-developed-by: Stefan We

[Intel-wired-lan] [PATCH iwl-next v4 1/5] ixgbe: Add support for E610 FW Admin Command Interface

2024-04-22 Thread Piotr Kwapulinski
Add low level support for Admin Command Interface (ACI). ACI is the Firmware interface used by a driver to communicate with E610 adapter. Add the following ACI features: - data structures, macros, register definitions - commands handling - events handling Co-developed-by: Stefan Wegrzyn Signed-of

[Intel-wired-lan] [PATCH iwl-next v4 0/5] ixgbe: Add support for Intel(R) E610 device

2024-04-22 Thread Piotr Kwapulinski
Add initial support for Intel(R) E610 Series of network devices. The E610 is based on X550 but adds firmware managed link, enhanced security capabilities and support for updated server manageability. This patch series adds low level support for the following features and enables link management.

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] ixgbe: Add support for E610 device capabilities detection

2024-04-22 Thread Kwapulinski, Piotr
>-Original Message- >From: Simon Horman >Sent: Saturday, April 20, 2024 8:18 PM >To: Kwapulinski, Piotr >Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Gomes, Vinicius >; Wegrzyn, Stefan ; >Jagielski, Jedrzej ; Sokolowski, Jan > >Subject: Re: [PATCH iwl-next v2 2/5] ixg

Re: [Intel-wired-lan] [PATCH iwl-next v5 00/12] Add support for Rx timestamping for both ice and iavf drivers.

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 10:19 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:48 -0400 Mateusz Polchlopek wrote: Initially, during VF creation it registers the PTP clock in the system and negotiates with PF it's capabilities. In the meantime the PF enables the Flexible Descriptor for VF. Only

Re: [Intel-wired-lan] [PATCH iwl-next v5 02/12] ice: support Rx timestamp on flex descriptor

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 8:57 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:50 -0400 Mateusz Polchlopek wrote: From: Simei Su To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by the VF to request PTP capability and responded by the PF what capability is enabled for that VF.

Re: [Intel-wired-lan] [PATCH iwl-next v5 04/12] iavf: add support for negotiating flexible RXDID format

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 9:11 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:52 -0400 Mateusz Polchlopek wrote: From: Jacob Keller Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF driver the ability to determine what Rx descriptor formats are available. This requires sen

Re: [Intel-wired-lan] [PATCH iwl-next v5 05/12] iavf: negotiate PTP capabilities

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 9:16 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:53 -0400 Mateusz Polchlopek wrote: From: Jacob Keller Add a new extended capabilities negotiation to exchange information from the PF about what PTP capabilities are supported by this VF. This requires sending a VIRT

Re: [Intel-wired-lan] [PATCH iwl-next v5 06/12] iavf: add initial framework for registering PTP clock

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 9:28 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:54 -0400 Mateusz Polchlopek wrote: From: Jacob Keller Add the iavf_ptp.c file and fill it in with a skeleton framework to allow registering the PTP clock device. Add implementation of helper functions to check if a

Re: [Intel-wired-lan] [PATCH iwl-next v5 08/12] iavf: periodically cache PHC time

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 9:51 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:56 -0400 Mateusz Polchlopek wrote: From: Jacob Keller The Rx timestamps reported by hardware may only have 32 bits of storage for nanosecond time. These timestamps cannot be directly reported to the Linux stack, as i

Re: [Intel-wired-lan] [PATCH iwl-next v5 09/12] iavf: refactor iavf_clean_rx_irq to support legacy and flex descriptors

2024-04-22 Thread Mateusz Polchlopek
On 4/18/2024 10:00 PM, Rahul Rameshbabu wrote: On Thu, 18 Apr, 2024 01:24:57 -0400 Mateusz Polchlopek wrote: From: Jacob Keller Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of negotiating to enable the advanced flexible descriptor layout. Add the flexible NIC layout (R