[Intel-wired-lan] [iwl-net][PATCH v2] Revert "e1000e: move force SMBUS near the end of enable_ulp function"

2024-06-10 Thread Hui Wang
This reverts commit bfd546a552e140b0a4c8a21527c39d6d21addb28 Commit bfd546a552e1 ("e1000e: move force SMBUS near the end of enable_ulp function") introduces system suspend failure on some ethernet cards, at the moment, the pciid of the affected ethernet cards include [8086:15b8] and [8086:15bc].

Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: Allow different FW API versions based on MAC type

2024-06-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > Greenwalt > Sent: Thursday, June 6, 2024 7:19 PM > To: intel-wired-...@lists.osuosl.org > Cc: Greenwalt, Paul > Subject: [Intel-wired-lan] [PATCH iwl-next v1] ice: Allow different FW API > versions based on MAC type > > Al

Re: [Intel-wired-lan] [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable_ulp function"

2024-06-10 Thread Hui Wang
On 6/10/24 22:14, Zhang, Rui wrote: On Mon, 2024-06-10 at 08:36 +0200, Paul Menzel wrote: Dear Hui, Naama also added Tested-by lines two both commits in question. Could Intel’s test coverage please extended to the problem at hand? Acked-by: Paul Menzel Plus that, 1. Todd and I can test w

Re: [Intel-wired-lan] [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable_ulp function"

2024-06-10 Thread Hui Wang
On 6/10/24 14:36, Paul Menzel wrote: Dear Hui, Thank you for your patch. Am 10.06.24 um 03:32 schrieb Hui Wang: This reverts commit bfd546a552e140b0a4c8a21527c39d6d21addb28 Commit bfd546a552e1 ("e1000e: move force SMBUS near the end of enable_ulp function") introduces system suspend failu

Re: [Intel-wired-lan] [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset

2024-06-10 Thread Jakub Kicinski
On Fri, 7 Jun 2024 14:15:52 +0200 Dawid Osuchowski wrote: > We cannot use ice_wait_for_reset() since both the ethtool handler and the > adapter reset flow call rtnl_lock() during operation. If we wait for > reset completion inside of an ethtool handling function such as > ice_get_coalesce(), the w

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Jacob Keller
On 6/9/2024 1:15 AM, Richard chien wrote: > This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task, the Intel online f

Re: [Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-10 Thread Andrew Lunn
On Sun, Jun 09, 2024 at 04:57:35PM +0800, Richard chien wrote: > This patch adds support for firmware update to the in-tree ixgbe driver and > it is actually a port > from the out-of-tree ixgbe driver. In-band firmware update is one of the > essential system maintenance > tasks. To simplify this

Re: [Intel-wired-lan] [PATCH net-next 2/5] sfc: use flow_rule_is_supp_enc_control_flags()

2024-06-10 Thread Edward Cree
On 09/06/2024 18:33, Asbjørn Sloth Tønnesen wrote: > Change the existing check for unsupported encapsulation control flags, > to use the new helper flow_rule_is_supp_enc_control_flags(). > > No functional change, only compile tested. > > Signed-off-by: Asbjørn Sloth Tønnesen Acked-by: Edward Cr

Re: [Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Andrew Lunn
On Sun, Jun 09, 2024 at 04:15:26PM +0800, Richard chien wrote: > This patch adds support for firmware update to the in-tree igb driver and it > is actually a port from the out-of-tree igb driver. > In-band firmware update is one of the essential system maintenance tasks. To > simplify this task,

Re: [Intel-wired-lan] [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC

2024-06-10 Thread Jacob Keller
On 6/8/2024 11:14 AM, Samal, Anil wrote: > Hi Jacob, > Can you please help me with the branch name that I should rebase? > Last time I rebased to "dev-queue" branch of "git clone > git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git". > > Let me know, if I should use a different br

Re: [Intel-wired-lan] [PATCH iwl-next v7 01/12] virtchnl: add support for enabling PTP on iAVF

2024-06-10 Thread Jacob Keller
On 6/8/2024 5:55 AM, Simon Horman wrote: > If you need to respin this for some reason, please consider updating > the Kernel doc for the following to include a short description. > Else, please consider doing so as a follow-up > > * struct virtchnl_ptp_caps > * struct virtchnl_phc_time > > Lik

[Intel-wired-lan] [PATCH] ixgbe: Add support for firmware update

2024-06-10 Thread Richard chien
This patch adds support for firmware update to the in-tree ixgbe driver and it is actually a port from the out-of-tree ixgbe driver. In-band firmware update is one of the essential system maintenance tasks. To simplify this task, the Intel online firmware update utility provides a common interfa

[Intel-wired-lan] [PATCH] igb: Add support for firmware update

2024-06-10 Thread Richard chien
This patch adds support for firmware update to the in-tree igb driver and it is actually a port from the out-of-tree igb driver. In-band firmware update is one of the essential system maintenance tasks. To simplify this task, the Intel online firmware update utility provides a common interface th

[Intel-wired-lan] [PATCH iwl-net 3/3] ice: make NAPI setting code aware that rtnl-locked request is waiting

2024-06-10 Thread Larysa Zaremba
ice_vsi_rebuild() is a critical section in the reset path. Sometimes, rtnl-locked callbacks have to wait for it to finish. However, it is possible they will wait for an eternity, because the critical section contains calls to ice_queue_set_napi() that try to take rtnl_lock. Make ice_queue_set_napi

[Intel-wired-lan] [PATCH iwl-net 2/3] ice: fix locking in ice_xsk_pool_setup()

2024-06-10 Thread Larysa Zaremba
With ICE_CFG_BUSY PF state flag locking used in ice_xdp(), there is no need to lock with VSI state inside ice_xsk_pool_setup(). For robust synchronization the state between reset preparation and PF VSI rebuild has to be handled, in the same way as in ice_xdp_setup_prog(). Remove locking logic from

[Intel-wired-lan] [PATCH iwl-net 1/3] ice: synchronize XDP setup with reset

2024-06-10 Thread Larysa Zaremba
XDP setup and PF reset code access the same resources in the following sections: * ice_vsi_close() in ice_prepare_for_reset() - already rtnl-locked * ice_vsi_rebuild() for the PF VSI - not protected With an unfortunate timing, such accesses can result in a crash such as the one below: [ +1.999878

[Intel-wired-lan] [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf() and reset

2024-06-10 Thread Larysa Zaremba
Fix the problems that are triggered by tx_timeout and ice_xdp() calls, including both pool and program operations. PF reset can be triggered asynchronously, e.g. by tx_timeout. With some unfortunate timings both reset and .ndo_bpf will try to access and modify XDP rings at the same time, causing s

Re: [Intel-wired-lan] [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable_ulp function"

2024-06-10 Thread Zhang, Rui
On Mon, 2024-06-10 at 08:36 +0200, Paul Menzel wrote: > Dear Hui, > > > Thank you for your patch. > > > Am 10.06.24 um 03:32 schrieb Hui Wang: > > This reverts commit bfd546a552e140b0a4c8a21527c39d6d21addb28 > > > > Commit bfd546a552e1 ("e1000e: move force SMBUS near the end of > > enable_ulp

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Paul Menzel
Dear Aleksandr, Thank you for your response. Am 10.06.24 um 12:20 schrieb Loktionov, Aleksandr: -Original Message- From: Intel-wired-lan On Behalf Of Loktionov, Aleksandr Sent: Monday, June 10, 2024 12:16 PM -Original Message- From: Loktionov, Aleksandr Sent: Monday, J

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Loktionov, Aleksandr
> -Original Message- > From: Intel-wired-lan On > Behalf Of Loktionov, Aleksandr > Sent: Monday, June 10, 2024 12:16 PM > To: Paul Menzel ; Kang, Kelvin > > Cc: Sokolowski, Jan ; > net...@vger.kernel.org; Kubalewski, Arkadiusz > ; Nguyen, Anthony L > ; intel-wired-...@lists.osuosl.org;

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Paul Menzel
Dear Aleksandr, Thank you for your prompt reply. Am 10.06.24 um 12:14 schrieb Loktionov, Aleksandr: -Original Message- From: Paul Menzel Sent: Monday, June 10, 2024 11:45 AM […] Am 10.06.24 um 11:20 schrieb Aleksandr Loktionov: After 230f3d53a547 patch all I/O errors are being c

Re: [Intel-wired-lan] [PATCH iwl-next v7 01/12] virtchnl: add support for enabling PTP on iAVF

2024-06-10 Thread Mateusz Polchlopek
On 6/8/2024 2:55 PM, Simon Horman wrote: On Tue, Jun 04, 2024 at 09:13:49AM -0400, Mateusz Polchlopek wrote: From: Jacob Keller Add support for allowing a VF to enable PTP feature - Rx timestamps The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be set by the VF to request acc

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Loktionov, Aleksandr
> -Original Message- > From: Loktionov, Aleksandr > Sent: Monday, June 10, 2024 12:14 PM > To: Paul Menzel ; Kang, Kelvin > > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Kubalewski, > Arkadiusz ; Sokolowski, Jan > ; Leon Romanovsky > Subject: RE:

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Loktionov, Aleksandr
> -Original Message- > From: Paul Menzel > Sent: Monday, June 10, 2024 11:45 AM > To: Loktionov, Aleksandr ; Kang, > Kelvin > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Kubalewski, > Arkadiusz ; Sokolowski, Jan > ; Leon Romanovsky > Subject: Re:

Re: [Intel-wired-lan] [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset

2024-06-10 Thread Pucha, HimasekharX Reddy
> -Original Message- > From: Intel-wired-lan On Behalf Of Dawid > Osuchowski > Sent: Friday, June 7, 2024 5:46 PM > To: intel-wired-...@lists.osuosl.org > Cc: Kwan, Ngai-mint ; net...@vger.kernel.org; > Chmielewski, Pawel ; Simon Horman > ; Polchlopek, Mateusz ; Dawid > Osuchowski > S

Re: [Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Paul Menzel
Dear Aleksandr, dear Kelvin, Thank you for your patch. Am 10.06.24 um 11:20 schrieb Aleksandr Loktionov: After 230f3d53a547 patch all I/O errors are being converted into EAGAIN which leads to retries until timeout so nvmupdate sometimes fails after more than 20 minutes! Remove misleading EIO

[Intel-wired-lan] [PATCH iwl-net] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-10 Thread Aleksandr Loktionov
After 230f3d53a547 patch all I/O errors are being converted into EAGAIN which leads to retries until timeout so nvmupdate sometimes fails after more than 20 minutes! Remove misleading EIO to EGAIN conversion and pass all errors as is. Fixes: 230f3d53a547 ("i40e: remove i40e_status") Co-developed-

Re: [Intel-wired-lan] [PATCH net-next 5/5] ice: flower: validate encapsulation control flags

2024-06-10 Thread Marcin Szycik
On 09.06.2024 19:33, Asbjørn Sloth Tønnesen wrote: > Encapsulation control flags are currently not used anywhere, > so all flags are currently unsupported by all drivers. > > This patch adds validation of this assumption, so that > encapsulation flags may be used in the future. > > In case any

[Intel-wired-lan] [tnguy-next-queue:dev-queue 20/95] drivers/net/ethernet/intel/ice/ice_parser.c:971 __ice_pg_nm_cam_match() error: memcmp() '&item->key.val' too small (9 vs 13)

2024-06-10 Thread Dan Carpenter
.org/0day-ci/archive/20240610/202406100753.38qaqzo9-...@intel.com/config) compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by

[Intel-wired-lan] [iwl-next v3 4/4] ice: update representor when VSI is ready

2024-06-10 Thread Michal Swiatkowski
In case of reset of VF VSI can be reallocated. To handle this case it should be properly updated. Reload representor as vsi->vsi_num can be different than the one stored when representor was created. Instead of only changing antispoof do whole VSI configuration for eswitch. Signed-off-by: Michal

[Intel-wired-lan] [iwl-next v3 3/4] ice: move VSI configuration outside repr setup

2024-06-10 Thread Michal Swiatkowski
It is needed because subfunction port representor shouldn't configure the source VSI during representor creation. Move the code to separate function and call it only in case the VF port representor is being created. Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_eswitc

[Intel-wired-lan] [iwl-next v3 2/4] ice: move devlink locking outside the port creation

2024-06-10 Thread Michal Swiatkowski
In case of subfunction lock will be taken for whole port creation and removing. Do the same in VF case. Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 -- drivers/net/ethernet/intel/ice/devlink/devlink_port.c | 4 ++-- drivers/net/ethernet/intel/i

[Intel-wired-lan] [iwl-next v3 1/4] ice: store representor ID in bridge port

2024-06-10 Thread Michal Swiatkowski
It is used to get representor structure during cleaning. Reviewed-by: Wojciech Drewek Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/ice/ice_eswitch_br.c | 4 +++- drivers/net/ethernet/intel/ice/ice_eswitch_br.h | 1 + drivers/net/ethernet/intel/ice/ice_repr.c | 7 ++

[Intel-wired-lan] [iwl-next v3 0/4] ice: prepare representor for SF support

2024-06-10 Thread Michal Swiatkowski
Hi, This is a series to prepare port representor for supporting also subfunctions. We need correct devlink locking and the possibility to update parent VSI after port representor is created. Refactor how devlink lock is taken to suite the subfunction use case. VSI configuration needs to be done