Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-14 Thread Jakub Kicinski
On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > To debug link issues in the field, serdes Tx/Rx equalizer values > help to determine the health of serdes lane. > > Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. > The following list of equalizer param is supported > a. rx_equ

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 3ec8d7572a69d142d49f52b28ce8d84e5fef9131

2024-06-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git 10GbE branch HEAD: 3ec8d7572a69d142d49f52b28ce8d84e5fef9131 CDC-NCM: add support for Apple's private interface elapsed time: 2431m configs tested: 41 configs skipped: 2 The following configs have been built succ

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS a9b9741854a9fe9df948af49ca5514e0ed0429df

2024-06-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 200GbE branch HEAD: a9b9741854a9fe9df948af49ca5514e0ed0429df bnxt_en: Adjust logging of firmware messages in case of released token in __hwrm_send() elapsed time: 1494m configs tested: 41 configs skipped: 2 The f

[Intel-wired-lan] [PATCH iwl-next] ice: Add a per-VF limit on number of FDIR filters

2024-06-14 Thread Ahmed Zaki
While the iavf driver adds a s/w limit (128) on the number of FDIR filters that the VF can request, a malicious VF driver can request more than that and exhaust the resources for other VFs. Add a similar limit in ice. CC: sta...@vger.kernel.org Reviewed-by: Przemek Kitszel Suggested-by: Sridhar

[Intel-wired-lan] [PATCH iwl-next v3 0/3] ice:Support to dump PHY config, FEC

2024-06-14 Thread Anil Samal
Implementation to dump PHY configuration and FEC statistics to facilitate link level debugging of customer issues. Implementation has two parts a. Serdes equalization # ethtool -d eth0 Output: Offset Values -- -- 0x:

[Intel-wired-lan] [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics

2024-06-14 Thread Anil Samal
To debug link issues in the field, it is paramount to dump fec corrected/uncorrected block counts from firmware. Firmware requires PCS quad number and PCS port number to read FEC statistics. Current driver implementation does not maintain above physical properties of a port. Add new driver API to

[Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values

2024-06-14 Thread Anil Samal
To debug link issues in the field, serdes Tx/Rx equalizer values help to determine the health of serdes lane. Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. The following list of equalizer param is supported a. rx_equalization_pre2 b. rx_equalization_pre1 c. rx_equalization

[Intel-wired-lan] [PATCH iwl-next v3 1/3] ice: Extend Sideband Queue command to support flags

2024-06-14 Thread Anil Samal
Current driver implementation for Sideband Queue supports a fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from firmware, Sideband Queue command is used with a different flag. Extend API for Sideband Queue command to use 'flags' as input argument. Reviewed-by: Simon Horman Reviewed-by:

Re: [Intel-wired-lan] [iwl-next v3 2/4] ice: move devlink locking outside the port creation

2024-06-14 Thread Simon Horman
On Mon, Jun 10, 2024 at 09:44:32AM +0200, Michal Swiatkowski wrote: > In case of subfunction lock will be taken for whole port creation and > removing. Do the same in VF case. > > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman

Re: [Intel-wired-lan] [iwl-next v3 4/4] ice: update representor when VSI is ready

2024-06-14 Thread Simon Horman
On Mon, Jun 10, 2024 at 09:44:34AM +0200, Michal Swiatkowski wrote: > In case of reset of VF VSI can be reallocated. To handle this case it > should be properly updated. > > Reload representor as vsi->vsi_num can be different than the one stored > when representor was created. > > Instead of only

Re: [Intel-wired-lan] [iwl-next v3 1/4] ice: store representor ID in bridge port

2024-06-14 Thread Simon Horman
On Mon, Jun 10, 2024 at 09:44:31AM +0200, Michal Swiatkowski wrote: > It is used to get representor structure during cleaning. > > Reviewed-by: Wojciech Drewek > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman

Re: [Intel-wired-lan] [iwl-next v3 3/4] ice: move VSI configuration outside repr setup

2024-06-14 Thread Simon Horman
On Mon, Jun 10, 2024 at 09:44:33AM +0200, Michal Swiatkowski wrote: > It is needed because subfunction port representor shouldn't configure > the source VSI during representor creation. > > Move the code to separate function and call it only in case the VF port > representor is being created. > >

Re: [Intel-wired-lan] [PATCH iwl-net v5] ice: Do not get coalesce settings while in reset

2024-06-14 Thread Dawid Osuchowski
On 11.06.2024 04:47, Jakub Kicinski wrote: Why does the reset not call netif_device_detach()? Then core will know not to call the driver. Will use this approach in new patch, thanks. --Dawid

Re: [Intel-wired-lan] [iwl-next v5 12/15] ice: implement netdevice ops for SF representor

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 01:25:00PM +0200, Michal Swiatkowski wrote: > Subfunction port representor needs the basic netdevice ops to work > correctly. Create them. > > Reviewed-by: Wojciech Drewek > Reviewed-by: Jiri Pirko > Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman

Re: [Intel-wired-lan] [iwl-next v5 05/15] ice: allocate devlink for subfunction

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 01:24:53PM +0200, Michal Swiatkowski wrote: > From: Piotr Raczynski > > Make devlink allocation function generic to use it for PF and for SF. > > Add function for SF devlink port creation. It will be used in next > patch. > > Create header file for subfunction device. De

Re: [Intel-wired-lan] [PATCH iwl-next v2 4/5] ice: implement transmit hardware timestamp statistics

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 03:46:58PM -0700, Jesse Brandeburg wrote: > The kernel now has common statistics for transmit timestamps, so > implement them in the ice driver. > > use via > ethtool -I -T eth0 > > Reviewed-by: Jacob Keller > Reviewed-by: Jakub Kicinski > Reviewed-by: Hariprasad Kelam

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/5] ice: implement ethtool standard stats

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 03:46:56PM -0700, Jesse Brandeburg wrote: > Add support for MAC/pause/RMON stats. This enables reporting hardware > statistics in a common way via: > > ethtool -S eth0 --all-groups > and > ethtool --include-statistics --show-pause eth0 > > While doing so, add support for o

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/5] net: docs: add missing features that can have stats

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 03:46:55PM -0700, Jesse Brandeburg wrote: > While trying to figure out ethtool -I | --include-statistics, I noticed > some docs got missed when implementing commit 0e9c127729be ("ethtool: > add interface to read Tx hardware timestamping statistics"). > > Fix up the docs to

Re: [Intel-wired-lan] [PATCH iwl-next v2 5/5] ice: refactor to use helpers

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 03:46:59PM -0700, Jesse Brandeburg wrote: > Use the ice_netdev_to_pf() helper in more places and remove a bunch of > boilerplate code. Not every instance could be replaced due to use of the > netdev_priv() output or the vsi variable within a bunch of functions. > > Reviewed

[Intel-wired-lan] [PATCH iwl-next] ice: Distinguish driver reset and removal for AQ shutdown

2024-06-14 Thread Marcin Szycik
From: Piotr Gardocki Admin queue command for shutdown AQ contains a flag to indicate driver unload. However, the flag is always set in the driver, even for resets. It can cause the firmware to consider driver as unloaded once the PF reset is triggered on all ports of device, which could lead to u

Re: [Intel-wired-lan] [PATCH iwl-next v2 3/5] ice: add tracking of good transmit timestamps

2024-06-14 Thread Simon Horman
On Thu, Jun 06, 2024 at 03:46:57PM -0700, Jesse Brandeburg wrote: > As a pre-requisite to implementing timestamp statistics, start tracking > successful PTP timestamps. There already existed a trace event, but > add a counter as well so it can be displayed by the next patch. > > Good count is a u6

[Intel-wired-lan] [PATCH net v2] ice: use proper macro for testing bit

2024-06-14 Thread Petr Oros
Do not use _test_bit() macro for testing bit. The proper macro for this is one without underline. Fixes: 4da71a77fc3b ("ice: read internal temperature sensor") Signed-off-by: Petr Oros Acked-by: Ivan Vecera --- Changes for v2: - added target tree --- drivers/net/ethernet/intel/ice/ice_hwmon.c |

Re: [Intel-wired-lan] [PATCH v3 iwl-net 1/8] ice: respect netif readiness in AF_XDP ZC related ndo's

2024-06-14 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Thu, 13 Jun 2024 18:07:53 +0200 > On Thu, Jun 13, 2024 at 05:51:25PM +0200, Maciej Fijalkowski wrote: >> On Wed, Jun 12, 2024 at 11:15:31AM +0200, Alexander Lobakin wrote: >>> From: Alexander Lobakin >>> Date: Wed, 12 Jun 2024 11:09:10 +0200 >>> From: Maciej F

Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix hot issue NVM content is corrupted after nvmupdate

2024-06-14 Thread Paul Menzel
Dear Aleksandr, Am 12.06.24 um 13:04 schrieb Aleksandr Loktionov: The bug affects users only at the time when they try to update NVM, and only F/W versions that generate errors while nvmupdate. For example X710DA2 with 0x8000ECB7 F/W is affected, but there are probably more... After 230f3d53a5

Re: [Intel-wired-lan] [iwl-next v1] ice: Check all ice_vsi_rebuild() errors in function

2024-06-14 Thread Larysa Zaremba
On Wed, May 29, 2024 at 05:09:52PM +, Pucha, HimasekharX Reddy wrote: > > -Original Message- > > From: Intel-wired-lan On Behalf Of > > Karen Ostrowska > > Sent: Tuesday, May 28, 2024 2:32 PM > > To: intel-wired-...@lists.osuosl.org > > Cc: Joyner, Eric ; net...@vger.kernel.org; Kitsz

Re: [Intel-wired-lan] [iwl-next v1] ice: Check all ice_vsi_rebuild() errors in function

2024-06-14 Thread Larysa Zaremba
On Tue, Jun 11, 2024 at 11:01:55AM +0200, Paul Menzel wrote: > Dear Eric, dear Karen, > > > Thank you for the patch. > > > Am 28.05.24 um 11:01 schrieb Karen Ostrowska: > > From: Eric Joyner > > > > Check the return value from ice_vsi_rebuild() and prevent the usage of > > incorrectly configu