[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS d1815992133ebcc6007009645571f322f4bc7c44

2024-08-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue branch HEAD: d1815992133ebcc6007009645571f322f4bc7c44 ice: fix truesize operations for PAGE_SIZE >= 8192 elapsed time: 801m configs tested: 156 configs skipped: 4 The following configs have been built

[Intel-wired-lan] [PATCH iwl-next v3] ice: add E830 HW VF mailbox message limit support

2024-08-12 Thread Paul Greenwalt
E830 adds hardware support to prevent the VF from overflowing the PF mailbox with VIRTCHNL messages. E830 will use the hardware feature (ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf(). To prevent a VF from overflowing the PF, the PF sets the number of messages per VF that

Re: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-12 Thread Vinicius Costa Gomes
Hi, Daiwei Li writes: >> @Daiwei Li, I don't have a 82580 handy, please confirm that the patch > fixes the issue you are having. > > Thank you for the patch! I can confirm it fixes my issue. Below I offer a > patch that also works in response to Paul's feedback. > Your patch looks better than m

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Add netif_device_attach/detach into PF reset flow

2024-08-12 Thread Larysa Zaremba
On Mon, Aug 12, 2024 at 02:50:09PM +0200, Dawid Osuchowski wrote: > Ethtool callbacks can be executed while reset is in progress and try to > access deleted resources, e.g. getting coalesce settings can result in a > NULL pointer dereference seen below. > > Reproduction steps: > Once the driver is

Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Add Energy Efficient Ethernet ability for X710 Base-T/KR/KX cards

2024-08-12 Thread Simon Horman
On Mon, Aug 12, 2024 at 10:09:37AM +0200, Przemek Kitszel wrote: > On 8/9/24 17:25, Simon Horman wrote: > > On Thu, Aug 08, 2024 at 01:22:17PM +0200, Aleksandr Loktionov wrote: > > > > ... > > > > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c > > > b/drivers/net/ethernet/intel/i4

Re: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code

2024-08-12 Thread Larysa Zaremba
On Mon, Aug 12, 2024 at 03:03:19PM +0200, Maciej Fijalkowski wrote: > On Wed, Jul 24, 2024 at 06:48:36PM +0200, Larysa Zaremba wrote: > > Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing, > > because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF > > state, no

[Intel-wired-lan] [PATCH] Break include dependency cycle

2024-08-12 Thread Diomidis Spinellis
Header ixgbe_type.h includes ixgbe_mbx.h. Also, header ixgbe_mbx.h included ixgbe_type.h, thus introducing a circular dependency. Removing the second include is OK, because its includers, ixgbe_mbx.c and ixgbe_82599.c, include ixgbe.h, which includes ixgbe_type.h. Signed-off-by: Diomidis Spinelli

Re: [Intel-wired-lan] [PATCH iwl-net v1] igb: Fix not clearing TimeSync interrupts for 82580

2024-08-12 Thread Daiwei Li
> @Daiwei Li, I don't have a 82580 handy, please confirm that the patch fixes the issue you are having. Thank you for the patch! I can confirm it fixes my issue. Below I offer a patch that also works in response to Paul's feedback. > Please also add a description of the test case I am running pt

Re: [Intel-wired-lan] [iwl-net v2 2/2] igb: Fix missing time sync events

2024-08-12 Thread Daiwei Li
> Of course, I'll prepare a patch for that. Excellent, thank you! On Fri, Aug 9, 2024 at 9:39 AM Vinicius Costa Gomes wrote: > > Daiwei Li writes: > > > Hi, > > > > It appears this change breaks PTP on the 82580 controller, as ptp4l reports: > > > >> timed out while polling for tx timestamp in

Re: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring

2024-08-12 Thread Larysa Zaremba
On Mon, Aug 12, 2024 at 02:58:00PM +0200, Maciej Fijalkowski wrote: > On Wed, Jul 24, 2024 at 06:48:34PM +0200, Larysa Zaremba wrote: > > If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on > > VSI without applying new ring configuration. When unconfiguring the VSI, we > > ca

[Intel-wired-lan] [RFC net-next 5/6] iavf: Use napi_affinity_no_change

2024-08-12 Thread Joe Damato
Use napi_affinity_no_change instead of iavf's internal implementation, simplifying and centralizing the logic. To support this, struct iavf_q_vector has been extended to store the IRQ number, and irq_num's type is changed to unsigned int. Signed-off-by: Joe Damato --- drivers/net/ethernet/intel/

[Intel-wired-lan] [RFC net-next 4/6] i40e: Use napi_affinity_no_change

2024-08-12 Thread Joe Damato
Use napi_affinity_no_change instead of i40e's internal implementation, simplifying and centralizing the logic. To facilitate this, fix the type of irq_num to be unsigned int. Signed-off-by: Joe Damato --- drivers/net/ethernet/intel/i40e/i40e.h | 2 +- drivers/net/ethernet/intel/i40e/i40e_ma

[Intel-wired-lan] [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers

2024-08-12 Thread Joe Damato
Greetings: Several drivers make a check in their napi poll functions to determine if the CPU affinity of the IRQ has changed. If it has, the napi poll function returns a value less than the budget to force polling mode to be disabled, so that it can be rescheduled on the correct CPU next time the

Re: [Intel-wired-lan] [PATCH 6.10.y] idpf: fix memleak in vport interrupt configuration

2024-08-12 Thread Greg KH
On Mon, Aug 12, 2024 at 03:44:55PM +0200, Alexander Lobakin wrote: > From: Michal Kubiak > > commit 3cc88e8405b8d55e0ff035e31971aadd6baee2b6 upstream. > > The initialization of vport interrupt consists of two functions: > 1) idpf_vport_intr_init() where a generic configuration is done > 2) idp

[Intel-wired-lan] [PATCH 6.10.y] idpf: fix memleak in vport interrupt configuration

2024-08-12 Thread Alexander Lobakin
From: Michal Kubiak commit 3cc88e8405b8d55e0ff035e31971aadd6baee2b6 upstream. The initialization of vport interrupt consists of two functions: 1) idpf_vport_intr_init() where a generic configuration is done 2) idpf_vport_intr_req_irq() where the irq for each q_vector is requested. The firs

Re: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code

2024-08-12 Thread Maciej Fijalkowski
On Wed, Jul 24, 2024 at 06:48:36PM +0200, Larysa Zaremba wrote: > Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing, > because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF > state, not VSI one. Therefore it does not protect the queue pair from > e.g. reset. >

Re: [Intel-wired-lan] [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring

2024-08-12 Thread Maciej Fijalkowski
On Wed, Jul 24, 2024 at 06:48:34PM +0200, Larysa Zaremba wrote: > If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on > VSI without applying new ring configuration. When unconfiguring the VSI, we > can encounter the state in which there is an XDP program but no XDP rings > to

[Intel-wired-lan] [PATCH iwl-net v2] ice: Add netif_device_attach/detach into PF reset flow

2024-08-12 Thread Dawid Osuchowski
Ethtool callbacks can be executed while reset is in progress and try to access deleted resources, e.g. getting coalesce settings can result in a NULL pointer dereference seen below. Reproduction steps: Once the driver is fully initialized, trigger reset: # echo 1 > /sys/class/net//device/r

Re: [Intel-wired-lan] [PATCH iwl-next v8 06/14] iavf: add initial framework for registering PTP clock

2024-08-12 Thread Alexander Lobakin
From: Mateusz Polchlopek Date: Mon, 12 Aug 2024 12:01:34 +0200 > > > On 8/8/2024 2:24 PM, Alexander Lobakin wrote: >> From: Mateusz Polchlopek >> Date: Thu, 8 Aug 2024 13:04:29 +0200 >> >>> >>> >>> On 7/30/2024 3:40 PM, Alexander Lobakin wrote: From: Mateusz Polchlopek Date: Tue, 30

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Add netif_device_attach/detach into PF reset flow

2024-08-12 Thread Dawid Osuchowski
On 12.08.2024 12:22, Dawid Osuchowski wrote: Ethtool callbacks can be executed while reset is in progress and try to access deleted resources, e.g. getting coalesce settings can result in a NULL pointer dereference seen below. Please disregard this submission, I have been made aware of addition

Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Add Energy Efficient Ethernet ability for X710 Base-T/KR/KX cards

2024-08-12 Thread Loktionov, Aleksandr
> -Original Message- > From: Simon Horman > Sent: Friday, August 9, 2024 5:26 PM > To: Loktionov, Aleksandr > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Kubalewski, > Arkadiusz > Subject: Re: [PATCH iwl-next v1] i40e: Add Energy Efficient Ether

[Intel-wired-lan] [PATCH iwl-net] ice: Add netif_device_attach/detach into PF reset flow

2024-08-12 Thread Dawid Osuchowski
Ethtool callbacks can be executed while reset is in progress and try to access deleted resources, e.g. getting coalesce settings can result in a NULL pointer dereference seen below. Once the driver is fully initialized, trigger reset: # echo 1 > /sys/class/net//device/reset when reset is i

Re: [Intel-wired-lan] [PATCH iwl-next v8 06/14] iavf: add initial framework for registering PTP clock

2024-08-12 Thread Mateusz Polchlopek
On 8/8/2024 2:24 PM, Alexander Lobakin wrote: From: Mateusz Polchlopek Date: Thu, 8 Aug 2024 13:04:29 +0200 On 7/30/2024 3:40 PM, Alexander Lobakin wrote: From: Mateusz Polchlopek Date: Tue, 30 Jul 2024 05:15:01 -0400 [...] +bool iavf_ptp_cap_supported(struct iavf_adapter *adapter,

Re: [Intel-wired-lan] [PATCH iwl-next v1] i40e: Add Energy Efficient Ethernet ability for X710 Base-T/KR/KX cards

2024-08-12 Thread Przemek Kitszel
On 8/9/24 17:25, Simon Horman wrote: On Thu, Aug 08, 2024 at 01:22:17PM +0200, Aleksandr Loktionov wrote: ... diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index 1d0d2e5..cd7509f 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_e