Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski :
On Tue, 20 Aug 2024 16:43:46 +0300 you wrote:
> BIT() is unsigned long but ->pu.flg_msk and ->pu.flg_val are u64 type.
> On 32 bit systems, unsigned long is a u32 and the mismatch between u32
> and u64 will break thin
Allow the user to get and set configuration of Embedded SYNC feature
on the ice driver dpll pins.
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Arkadiusz Kubalewski
---
v2:
- align to v2 changes of "dpll: add Embedded SYNC feature for a pin"
drivers/net/ethernet/intel/ice/ice_dpll.c | 230 ++
Implement and document new pin attributes for providing Embedded SYNC
capabilities to the DPLL subsystem users through a netlink pin-get
do/dump messages. Allow the user to set Embedded SYNC frequency with
pin-set do netlink message.
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Arkadiusz Kubal
Introduce and allow DPLL subsystem users to get/set capabilities of
Embedded SYNC on a dpll's pin.
Signed-off-by: Arkadiusz Kubalewski
Arkadiusz Kubalewski (2):
dpll: add Embedded SYNC feature for a pin
ice: add callbacks for Embedded SYNC enablement on dpll pins
Documentation/driver-api/d
On 8/20/2024 6:26 AM, Maciej Fijalkowski wrote:
...
Fixes: 080b0c8d6d26 ("ice: Fix ASSERT_RTNL() warning during certain scenarios")
Shouldn't you include:
Fixes: 91fdbce7e8d6 ("ice: Add support in the driver for associating queue with
napi")
as we were iterating over XDP rings that were att
On Mon, Aug 19, 2024 at 11:27:56AM +0200, Aleksandr Loktionov wrote:
> Add "EEE: Enabled/Disabled" to dmesg for supported X710 Base-T/KR/KX cards.
> According to the IEEE standard report the EEE ability and and the
> EEE Link Partner ability. Use the kernel's 'ethtool_keee' structure
> and report E
gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc axs103_smp_defconfig gcc-13.2.0
arc randconfig-001-20240821 gcc-13.2.0
arc randconfig-002-20240821 gcc-13.2.0
arm allmodconfig gcc
gcc-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arc randconfig-001-20240821 gcc-13.2.0
arc randconfig-002-20240821 gcc
On Wed, Aug 21, 2024 at 04:24:09PM +0200, Krzysztof Galazka wrote:
> For IPv4 and IPv6 packets shorter than minimum Ethernet
> frame payload, recvmsg returns lenght including padding.
> Use length from header for checksum verification to avoid
> csum test failing on correct packets.
>
> Fixes: 1d0
defconfig gcc-13.2.0
arc allmodconfig gcc-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arc randconfig-001-20240821
allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc axs103_smp_defconfig gcc-13.2.0
arc randconfig-001-20240821 gcc-13.2.0
arc randconfig-002-20240821 gcc-13.2.0
arm allmodconfig
Ethtool callbacks can be executed while reset is in progress and try to
access deleted resources, e.g. getting coalesce settings can result in a
NULL pointer dereference seen below.
Reproduction steps:
Once the driver is fully initialized, trigger reset:
# echo 1 > /sys/class/net//device/r
Dne 20. 08. 24 v 23:30 Bjorn Helgaas napsal(a):
On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote:
Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a):
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
On 19. 08. 24, 6:50, Jiri Slaby wrote:
CC e1000e guys + Jesse (due to 75
For IPv4 and IPv6 packets shorter than minimum Ethernet
frame payload, recvmsg returns lenght including padding.
Use length from header for checksum verification to avoid
csum test failing on correct packets.
Fixes: 1d0dc857b5d8 (selftests: drv-net: add checksum tests)
Signed-off-by: Krzysztof Gal
On 8/21/2024 5:59 PM, Bjorn Helgaas wrote:
[+to Dima, Vitaly, Hui; beginning of thread at
https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741c...@kernel.org]
On Wed, Aug 21, 2024 at 01:39:11PM +0200, Petr Valenta wrote:
Dne 20. 08. 24 v 23:30 Bjorn Helgaas napsal(a):
On Tue, Aug 20, 20
[+to Dima, Vitaly, Hui; beginning of thread at
https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741c...@kernel.org]
On Wed, Aug 21, 2024 at 01:39:11PM +0200, Petr Valenta wrote:
> Dne 20. 08. 24 v 23:30 Bjorn Helgaas napsal(a):
> > On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:34 +0200
> From: Mateusz Polchlopek
>
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. This commit changes the prefix from
Imperative. Like "change the prefix and move mentioned structs to...
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:33 +0200
> From: Jacob Keller
>
> The Rx timestamps reported by hardware may only have 32 bits of storage
> for nanosecond time. These timestamps cannot be directly reported to the
> Linux stack, as it expects 64bits of time.
>
> To handle thi
Krzysztof Galazka wrote:
> For IPv4 and IPv6 packets shorter than minimum Ethernet
> frame payload, recvmsg returns lenght including padding.
nit: length
> Use length from header for checksum verification to avoid
> csum test failing on correct packets.
>
> Fixes: 1d0dc857b5d8 (selftests: drv-ne
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:32 +0200
> From: Jacob Keller
>
> Implement support for reading the PHC time indirectly via the
> VIRTCHNL_OP_1588_PTP_GET_TIME operation.
[...]
> +/**
> + * iavf_queue_ptp_cmd - Queue PTP command for sending over virtchnl
> + * @adapter: pri
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:31 +0200
> From: Jacob Keller
>
> Add the iavf_ptp.c file and fill it in with a skeleton framework to
> allow registering the PTP clock device.
> Add implementation of helper functions to check if a PTP capability
> is supported and handle chan
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:30 +0200
> From: Jacob Keller
>
> Add a new extended capabilities negotiation to exchange information from
> the PF about what PTP capabilities are supported by this VF. This
> requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiti
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:29 +0200
> From: Jacob Keller
>
> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
> driver the ability to determine what Rx descriptor formats are
> available. This requires sending an additional message during
> initializ
On 8/21/2024 8:09 AM, Jiri Slaby wrote:
On 20. 08. 24, 23:30, Bjorn Helgaas wrote:
On Tue, Aug 20, 2024 at 11:13:54PM +0200, Petr Valenta wrote:
Dne 20. 08. 24 v 20:09 Bjorn Helgaas napsal(a):
On Mon, Aug 19, 2024 at 07:23:42AM +0200, Jiri Slaby wrote:
On 19. 08. 24, 6:50, Jiri Slaby wrote:
allmodconfig gcc-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arc randconfig-001-20240821 gcc-13.2.0
arc randconfig-002
From: Ben Shelton
Add a devlink health reporter for MDD events. The 'dump' handler will
return the information captured in each call to ice_handle_mdd_event().
A device reset (CORER/PFR) will put the reporter back in healthy state.
Signed-off-by: Ben Shelton
Reviewed-by: Igor Bagnucki
Reviewed
Print the ethtool stats and skb diagnostic information as part of Tx hang
devlink health dump.
Move the declarations of ethtool functions that devlink health uses out
to a new file: ice_ethtool_common.h
To utilize our existing ethtool code in this context, convert it to
non-static.
Reviewed-by:
Add Tx hang devlink health reporter, see struct ice_tx_hang_event to see
what is reported.
Subsequent commits will extend it by more info, for now it dumps
descriptors with little metadata.
Reviewed-by: Igor Bagnucki
Reviewed-by: Wojciech Drewek
Co-developed-by: Mateusz Polchlopek
Signed-off-b
From: Mateusz Polchlopek
Add devlink_fmsg_dump_skb() function that adds some diagnostic
information about skb (like length, pkt type, MAC, etc) to devlink
fmsg mechanism using bunch of devlink_fmsg_put() function calls.
Signed-off-by: Mateusz Polchlopek
Signed-off-by: Przemek Kitszel
---
incl
Add devlink_fmsg_put() that dispatches based on the type
of the value to put, example: bool -> devlink_fmsg_bool_pair_put().
Reviewed-by: Wojciech Drewek
Reviewed-by: Simon Horman
Signed-off-by: Mateusz Polchlopek
Signed-off-by: Przemek Kitszel
---
include/net/devlink.h | 11 +++
1 fi
Improve CamelCase recognition logic to avoid reporting on
_Generic() use.
Other C keywords, such as _Bool, are intentionally omitted, as those
should be rather avoided in new source code.
Reviewed-by: Wojciech Drewek
Reviewed-by: Simon Horman
Signed-off-by: Mateusz Polchlopek
Signed-off-by: Pr
Reports for two kinds of events are implemented, Malicious Driver
Detection (MDD) and Tx hang.
Patches 1, 2, 3: core improvements (checkpatch.pl, devlink extension)
Patches 3, 4, 5: ice devlink health infra + reporters
Mateusz did good job caring for this series, and hardening the code,
but he's
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:26 +0200
> From: Jacob Keller
>
> Add support for allowing a VF to enable PTP feature - Rx timestamps
>
> The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be
> set by the VF to request access to the new operations. In addition, t
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:28 +0200
> From: Jacob Keller
>
> Support for allowing VF to negotiate the descriptor format requires that
> the VF specify which descriptor format to use when requesting Rx queues.
> The VF is supposed to request the set of supported formats v
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:27 +0200
> From: Simei Su
>
> To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
> the VF to request PTP capability and responded by the PF what capability
> is enabled for that VF.
>
> Hardware captures timestamps which con
From: Paul Greenwalt
Date: Tue, 20 Aug 2024 17:26:16 -0400
> E830 adds hardware support to prevent the VF from overflowing the PF
> mailbox with VIRTCHNL messages. E830 will use the hardware feature
> (ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf().
>
> To prevent a VF f
Drop unused auxbus/auxdev support from the PTP code due to
move to the ice_adapter.
Signed-off-by: Sergey Temerkhanov
Reviewed-by: Przemek Kitszel
Reviewed-by: Simon Horman
---
drivers/net/ethernet/intel/ice/ice_ptp.c | 252 ---
drivers/net/ethernet/intel/ice/ice_ptp.h | 2
Use struct ice_adapter to hold shared PTP data and control PTP
related actions instead of auxbus. This allows significant code
simplification and faster access to the container fields used in
the PTP support code.
Move the PTP port list to the ice_adapter container to simplify
the code and avoid r
Address E825C devices by PCI ID since dual IP core configurations
need 1 ice_adapter for both devices.
Signed-off-by: Sergey Temerkhanov
Reviewed-by: Simon Horman
---
drivers/net/ethernet/intel/ice/ice_adapter.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git
Add ice_get_ctrl_ptp() wrapper to simplify the PTP support code
in the functions that do not use ctrl_pf directly.
Add the control PF pointer to struct ice_adapter
Rearrange fields in struct ice_adapter
Signed-off-by: Sergey Temerkhanov
Reviewed-by: Przemek Kitszel
Reviewed-by: Simon Horman
---
Introduce ice_get_phy_model() to improve code readability
Signed-off-by: Sergey Temerkhanov
Reviewed-by: Przemek Kitszel
Reviewed-by: Simon Horman
---
drivers/net/ethernet/intel/ice/ice.h| 5 +
drivers/net/ethernet/intel/ice/ice_ptp.c| 19 +-
drivers/net/ethern
This series replaces multiple aux buses and devices used in the PTP support
code with struct ice_adapter holding the necessary shared data
Patches 1,2 add convenience wrappers
Patch 3 does the main refactoring
Patch 4 finalizes the refactoring
Previous discussion:
https://lists.osuosl.org/piperm
On 2024/8/21 0:02, Alexander Duyck wrote:
> On Tue, Aug 20, 2024 at 6:07 AM Yunsheng Lin wrote:
>>
>> On 2024/8/19 23:54, Alexander Duyck wrote:
>>
>> ...
>>
>>
>> "There are three types of API as proposed in this patchset instead of
>> two types of API:
>> 1. page_frag_alloc_va()
From: Mateusz Polchlopek
Rx timestamping introduced in PF driver caused the need of refactoring
the VF driver mechanism to check packet fields.
The function to check errors in descriptor has been removed and from
now only previously set struct fields are being checked. The field DD
(descriptor d
From: Mateusz Polchlopek
The union iavf_32byte_rx_desc consists of two unnamed structs defined
inside. One of them represents legacy 32 byte descriptor and second the
16 byte descriptor (extended to 32 byte). Each of them consists of
bunch of unions, structs and __le fields that represent specifi
From: Jacob Keller
Add the iavf_ptp.c file and fill it in with a skeleton framework to
allow registering the PTP clock device.
Add implementation of helper functions to check if a PTP capability
is supported and handle change in PTP capabilities.
Enabling virtual clock would be possible, though i
From: Jacob Keller
Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
negotiating to enable the advanced flexible descriptor layout. Add the
flexible NIC layout (RXDID=2) as a member of the Rx descriptor union.
Also add bit position definitions for the status and error indication
From: Jacob Keller
Implement support for reading the PHC time indirectly via the
VIRTCHNL_OP_1588_PTP_GET_TIME operation.
Based on some simple tests with ftrace, the latency of the indirect
clock access appears to be about ~110 microseconds. This is due to the
cost of preparing a message to send
From: Jacob Keller
Add support for receive timestamps to the Rx hotpath. This support only
works when using the flexible descriptor format, so make sure that we
request this format by default if we have receive timestamp support
available in the PTP capabilities.
In order to report the timestamp
From: Jacob Keller
Add a new extended capabilities negotiation to exchange information from
the PF about what PTP capabilities are supported by this VF. This
requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiting
for the response from the PF. Handle this early on during the VF
init
From: Jacob Keller
Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which
allow userspace to request timestamp enablement for the device. This
support allows standard Linux applications to request the timestamping
desired.
As with other devices that support timestamping all packe
From: Jacob Keller
The Rx timestamps reported by hardware may only have 32 bits of storage
for nanosecond time. These timestamps cannot be directly reported to the
Linux stack, as it expects 64bits of time.
To handle this, the timestamps must be extended using an algorithm that
calculates the co
From: Mateusz Polchlopek
Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
idpf and iavf Intel drivers. This commit changes the prefix from
idpf_* to libeth_* and moves mentioned structs to libeth's rx.h header
file.
Usage in idpf driver has been adjusted.
Suggested-by: Alexan
From: Jacob Keller
Add support for allowing a VF to enable PTP feature - Rx timestamps
The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be
set by the VF to request access to the new operations. In addition, the
VIRTCHNL_OP_1588_PTP_CAPS command is used to determine the specific
cap
From: Jacob Keller
Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
driver the ability to determine what Rx descriptor formats are
available. This requires sending an additional message during
initialization and reset, the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS. This
operation requ
From: Simei Su
To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
the VF to request PTP capability and responded by the PF what capability
is enabled for that VF.
Hardware captures timestamps which contain only 32 bits of nominal
nanoseconds, as opposed to the 64bit timestamps
From: Jacob Keller
Support for allowing VF to negotiate the descriptor format requires that
the VF specify which descriptor format to use when requesting Rx queues.
The VF is supposed to request the set of supported formats via the new
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then set one of the sup
Initially, during VF creation it registers the PTP clock in
the system and negotiates with PF it's capabilities. In the
meantime the PF enables the Flexible Descriptor for VF.
Only this type of descriptor allows to receive Rx timestamps.
Enabling virtual clock would be possible, though it would pr
nfig gcc-13.2.0
arc allmodconfig gcc-13.2.0
arc allnoconfig gcc-13.2.0
arc allyesconfig gcc-13.2.0
arc defconfig gcc-13.2.0
arc randconfig-001-20240821
On 8/21/24 08:22, Maciej Fijalkowski wrote:
On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
@@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum
ice_reset_req reset_type)
{
struct device *dev = ice_pf_to_dev(pf);
struct ice_hw *hw = &pf->hw
On 21.08.2024 08:22, Maciej Fijalkowski wrote:
On Tue, Aug 20, 2024 at 06:15:24PM +0200, Dawid Osuchowski wrote:
@@ -7591,6 +7594,7 @@ static void ice_rebuild(struct ice_pf *pf, enum
ice_reset_req reset_type)
{
struct device *dev = ice_pf_to_dev(pf);
struct ice_hw *hw = &pf->h
61 matches
Mail list logo
