In idpf_add_del_mac_filters(), filters are chunked up into multiple
messages to avoid sending a control queue message buffer that is too large.
Each chunk has up to IDPF_NUM_FILTERS_PER_MSG entries. So except for the
last iteration which can be smaller, space for exactly
IDPF_NUM_FILTERS_PER_MSG e
Don't populate the read-only arrays tx_itr and rx_itr on the stack at
run time, instead make them static const.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/idp
>From: Jiri Pirko
>Sent: Thursday, August 22, 2024 12:29 PM
>
>Wed, Aug 21, 2024 at 11:32:18PM CEST, arkadiusz.kubalew...@intel.com wrote:
>>Allow the user to get and set configuration of Embedded SYNC feature
>>on the ice driver dpll pins.
>>
>>Reviewed-by: Aleksandr Loktionov
>>Signed-off-by: A
>From: Jiri Pirko
>Sent: Thursday, August 22, 2024 12:22 PM
>
>Wed, Aug 21, 2024 at 11:32:17PM CEST, arkadiusz.kubalew...@intel.com wrote:
>>Implement and document new pin attributes for providing Embedded SYNC
>>capabilities to the DPLL subsystem users through a netlink pin-get
>>do/dump messages
Allow the user to get and set configuration of Embedded SYNC feature
on the ice driver dpll pins.
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Arkadiusz Kubalewski
---
v3:
- remove redundant extack error
- rename esync_freq -> freq
drivers/net/ethernet/intel/ice/ice_dpll.c | 223 +++
Implement and document new pin attributes for providing Embedded SYNC
capabilities to the DPLL subsystem users through a netlink pin-get
do/dump messages. Allow the user to set Embedded SYNC frequency with
pin-set do netlink message.
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Arkadiusz Kubal
Introduce and allow DPLL subsystem users to get/set capabilities of
Embedded SYNC on a dpll's pin.
Signed-off-by: Arkadiusz Kubalewski
Arkadiusz Kubalewski (2):
dpll: add Embedded SYNC feature for a pin
ice: add callbacks for Embedded SYNC enablement on dpll pins
Documentation/driver-api/d
On Thu, Aug 22, 2024 at 04:42:44PM +0200, Maciej Fijalkowski wrote:
> On Thu, Aug 22, 2024 at 02:56:50PM +0200, Larysa Zaremba wrote:
> > On Thu, Aug 22, 2024 at 01:34:33PM +0200, Maciej Fijalkowski wrote:
> > > On Mon, Aug 19, 2024 at 12:05:41PM +0200, Larysa Zaremba wrote:
> > > > Consider the fo
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:39 +0200
> From: Jacob Keller
>
> Add support for receive timestamps to the Rx hotpath. This support only
> works when using the flexible descriptor format, so make sure that we
> request this format by default if we have receive timestamp supp
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:38 +0200
> From: Jacob Keller
>
> Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which
> allow userspace to request timestamp enablement for the device. This
> support allows standard Linux applications to request the timestam
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:37 +0200
> From: Mateusz Polchlopek
>
> Rx timestamping introduced in PF driver caused the need of refactoring
> the VF driver mechanism to check packet fields.
[...]
> +static bool iavf_is_descriptor_done(struct iavf_ring *rx_ring,
const
>
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:36 +0200
> From: Jacob Keller
>
> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
> negotiating to enable the advanced flexible descriptor layout. Add the
> flexible NIC layout (RXDID=2) as a member of the Rx descriptor union
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:35 +0200
> From: Mateusz Polchlopek
>
> The union iavf_32byte_rx_desc consists of two unnamed structs defined
> inside. One of them represents legacy 32 byte descriptor and second the
> 16 byte descriptor (extended to 32 byte). Each of them con
On Thu, Aug 22, 2024 at 02:56:50PM +0200, Larysa Zaremba wrote:
> On Thu, Aug 22, 2024 at 01:34:33PM +0200, Maciej Fijalkowski wrote:
> > On Mon, Aug 19, 2024 at 12:05:41PM +0200, Larysa Zaremba wrote:
> > > Consider the following scenario:
> > >
> > > .ndo_bpf()| ice_prepare_for_r
On 7/13/2024 10:02 PM, Sasha Neftin wrote:
According to the IEEE standard report the EEE ability (registers 7.60 and
7.62) and the EEE Link Partner ability (registers 7.61 and 7.63). Use the
kernel's 'ethtool_keee' structure and report EEE link modes.
Example:
ethtool --show-eee
Before:
Advert
On Thu, Aug 22, 2024 at 01:43:50PM +0200, Maciej Fijalkowski wrote:
> On Mon, Aug 19, 2024 at 12:05:42PM +0200, Larysa Zaremba wrote:
> > Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing,
> > because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF
> > state, no
On Thu, Aug 22, 2024 at 01:39:15PM +0200, Maciej Fijalkowski wrote:
> On Mon, Aug 19, 2024 at 12:05:39PM +0200, Larysa Zaremba wrote:
> > The main threat to data consistency in ice_xdp() is a possible asynchronous
> > PF reset. It can be triggered by a user or by TX timeout handler.
> >
> > XDP se
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Daiwei Li
> Sent: Wednesday, August 14, 2024 10:26 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: Daiwei Li ; Neftin, Sasha ;
> Gomes, Vinicius ; net...@vger.kernel.org;
> richardcoch...@gmail.com; k...@linutronix.de; linux-ke
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Aleksandr Loktionov
> Sent: Monday, August 19, 2024 2:58 PM
> To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L
> ; Loktionov, Aleksandr
>
> Cc: net...@vger.kernel.org; Kubalewski, Arkadiusz
>
> Subject: [Intel-wired-l
On Thu, Aug 22, 2024 at 01:34:33PM +0200, Maciej Fijalkowski wrote:
> On Mon, Aug 19, 2024 at 12:05:41PM +0200, Larysa Zaremba wrote:
> > Consider the following scenario:
> >
> > .ndo_bpf() | ice_prepare_for_reset() |
> > |
*tx_ring = igb_xdp_tx_queue_mapping(adapter);
>
> + nq = txring_txq(tx_ring);
> + __netif_tx_lock(nq, cpu);
> igb_xdp_ring_update_tail(tx_ring);
> + __netif_tx_unlock(nq);
> }
>
> u64_stats_update_begin(&rx_ring->rx_syncp);
>
> ---
> base-commit: a0b4a80ed6ce2cf8140fe926303ba609884b5d9b
> change-id: 20240822-igb_xdp_tx_lock-b6846fddc758
>
> Best regards,
> --
> Kurt Kanzenbach
>
On Mon, Aug 19, 2024 at 12:05:42PM +0200, Larysa Zaremba wrote:
> Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing,
> because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF
> state, not VSI one. Therefore it does not protect the queue pair from
> e.g. reset.
>
On Mon, Aug 19, 2024 at 12:05:39PM +0200, Larysa Zaremba wrote:
> The main threat to data consistency in ice_xdp() is a possible asynchronous
> PF reset. It can be triggered by a user or by TX timeout handler.
>
> XDP setup and PF reset code access the same resources in the following
> sections:
>
On Mon, Aug 19, 2024 at 12:05:40PM +0200, Larysa Zaremba wrote:
> If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on
> VSI without applying new ring configuration. When unconfiguring the VSI, we
> can encounter the state in which there is an XDP program but no XDP rings
> to
On Mon, Aug 19, 2024 at 12:05:43PM +0200, Larysa Zaremba wrote:
> After XDP configuration is completed, we bring the interface up
> unconditionally, regardless of its state before the call to .ndo_bpf().
>
> Preserve the information whether the interface had to be brought down and
> later bring it
On Mon, Aug 19, 2024 at 12:05:41PM +0200, Larysa Zaremba wrote:
> Consider the following scenario:
>
> .ndo_bpf()| ice_prepare_for_reset() |
> |___|
> rtnl_lock() |
Dear Vitaly,
Thank you very much for the improved version with the updated commit
message.
Am 22.08.24 um 12:33 schrieb Vitaly Lifshits:
Sporadic issues have been observed on I219 (19) devices.
It’d be great if you could be specific and describe them, despite they
are fixed with the patch
On Wed, Aug 21, 2024 at 03:37:11PM +0200, Przemek Kitszel wrote:
> From: Mateusz Polchlopek
>
> Add devlink_fmsg_dump_skb() function that adds some diagnostic
> information about skb (like length, pkt type, MAC, etc) to devlink
> fmsg mechanism using bunch of devlink_fmsg_put() function calls.
>
Sporadic issues have been observed on I219 (19) devices. It was found
that these devices have hardware more closely related to ADP than MTP
and the issues were caused by taking MTP-specific flows.
Change the MAC and board types of these devices from MTP to ADP to
correctly reflect the LAN hardware
Wed, Aug 21, 2024 at 11:32:18PM CEST, arkadiusz.kubalew...@intel.com wrote:
>Allow the user to get and set configuration of Embedded SYNC feature
>on the ice driver dpll pins.
>
>Reviewed-by: Aleksandr Loktionov
>Signed-off-by: Arkadiusz Kubalewski
>---
>v2:
>- align to v2 changes of "dpll: add E
Dne 22. 08. 24 v 11:18 Vitaly Lifshits napsal(a):
On 8/22/2024 11:33 AM, Petr Valenta wrote:
Dne 22. 08. 24 v 9:44 Petr Valenta napsal(a):
Dne 21. 08. 24 v 17:17 Vitaly Lifshits napsal(a):
On 8/21/2024 5:59 PM, Bjorn Helgaas wrote:
[+to Dima, Vitaly, Hui; beginning of thread at
https
Wed, Aug 21, 2024 at 11:32:17PM CEST, arkadiusz.kubalew...@intel.com wrote:
>Implement and document new pin attributes for providing Embedded SYNC
>capabilities to the DPLL subsystem users through a netlink pin-get
>do/dump messages. Allow the user to set Embedded SYNC frequency with
>pin-set do ne
On 8/22/2024 11:33 AM, Petr Valenta wrote:
Dne 22. 08. 24 v 9:44 Petr Valenta napsal(a):
Dne 21. 08. 24 v 17:17 Vitaly Lifshits napsal(a):
On 8/21/2024 5:59 PM, Bjorn Helgaas wrote:
[+to Dima, Vitaly, Hui; beginning of thread at
https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741
Dne 22. 08. 24 v 9:44 Petr Valenta napsal(a):
Dne 21. 08. 24 v 17:17 Vitaly Lifshits napsal(a):
On 8/21/2024 5:59 PM, Bjorn Helgaas wrote:
[+to Dima, Vitaly, Hui; beginning of thread at
https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741c...@kernel.org]
On Wed, Aug 21, 2024 at 01:
Dne 21. 08. 24 v 17:17 Vitaly Lifshits napsal(a):
On 8/21/2024 5:59 PM, Bjorn Helgaas wrote:
[+to Dima, Vitaly, Hui; beginning of thread at
https://lore.kernel.org/r/60ac8988-ace4-4cf0-8c44-028ca741c...@kernel.org]
On Wed, Aug 21, 2024 at 01:39:11PM +0200, Petr Valenta wrote:
Dne 20. 08. 2
igb_xdp_ring_update_tail(tx_ring);
+ __netif_tx_unlock(nq);
}
u64_stats_update_begin(&rx_ring->rx_syncp);
---
base-commit: a0b4a80ed6ce2cf8140fe926303ba609884b5d9b
change-id: 20240822-igb_xdp_tx_lock-b6846fddc758
Best regards,
--
Kurt Kanzenbach
36 matches
Mail list logo
