From: Joe Damato
Date: Fri, 4 Oct 2024 10:54:07 +
> The sizeof(struct napi_struct) can change. Don't hardcode the size to
> 400 bytes and instead use "sizeof(struct napi_struct)".
>
> Suggested-by: Alexander Lobakin
> Signed-off-by: Joe Damato
Acked-by:
From: Jakub Kicinski
Date: Wed, 2 Oct 2024 10:17:27 -0700
> On Tue, 1 Oct 2024 07:44:36 -0700 Joe Damato wrote:
>>> But if you change any core API, let's say rename a field used in several
>>> drivers, you anyway need to adjust the affected drivers.
>>
>> Sorry, but that's a totally different a
From: Joe Damato
Date: Mon, 30 Sep 2024 15:17:46 -0700
> On Mon, Sep 30, 2024 at 03:10:41PM +0200, Przemek Kitszel wrote:
>> On 9/30/24 14:38, Alexander Lobakin wrote:
>>> From: Alexander Lobakin
>>> Date: Mon, 30 Sep 2024 14:33:45 +0200
>>>
>>>>
From: Mateusz Polchlopek
Date: Tue, 1 Oct 2024 09:20:14 +0200
>
>
> On 8/21/2024 4:31 PM, Alexander Lobakin wrote:
>> From: Wojciech Drewek
>> Date: Wed, 21 Aug 2024 14:15:32 +0200
>>
>>> From: Jacob Keller
>>>
>>> Impleme
From: Alexander Lobakin
Date: Mon, 30 Sep 2024 14:33:45 +0200
> From: Joe Damato
> Date: Wed, 25 Sep 2024 18:00:17 +
>
>> The sizeof(struct napi_struct) can change. Don't hardcode the size to
>> 400 bytes and instead use "sizeof(struct napi_struct)".
From: Joe Damato
Date: Wed, 25 Sep 2024 18:00:17 +
> The sizeof(struct napi_struct) can change. Don't hardcode the size to
> 400 bytes and instead use "sizeof(struct napi_struct)".
Just change this hardcode here when you submit your series.
I use sizeof() here only for structures which size
start to the end of the packet, and inserts the result in
> the packet at skb->csum_offset.
>
> Co-developed-by: Alice Michael
> Signed-off-by: Alice Michael
> Co-developed-by: Eric Joyner
> Signed-off-by: Eric Joyner
> Signed-off-by: Paul Greenwalt
Re
From: Lorenzo Bianconi
Date: Sat, 21 Sep 2024 18:52:56 +0200
> This series introduces the xdp_rx_meta struct in the xdp_buff/xdp_frame
&xdp_buff is on the stack.
&xdp_frame consumes headroom.
IOW they're size-sensitive and putting metadata directly there might
play bad; if not now, then later.
igned-off-by: Joshua Hay
Co-developed-by: Michal Kubiak
Signed-off-by: Michal Kubiak
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 27 ++-
drivers/net/ethernet/intel/idpf/idpf_dev.c| 2 ++
...
"idpf: add singleq start_xmit and napi poll")
Cc: sta...@vger.kernel.org # 6.7+
Signed-off-by: Michal Kubiak
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 9 -
.../ethernet/intel/idpf/idpf_singleq_txrx.c |
descriptor ring wrap calculation to u16 and the normal ring size check.
Signed-off-by: Joshua Hay
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 6 +-
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 24 +--
drivers/net/ethe
copy-paste around the Tx code.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 50 +
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 82 +++
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 205 +++---
3 f
Add a shorthand similar to other net*_subqueue() helpers for resetting
the queue by its index w/o obtaining &netdev_tx_queue beforehand
manually.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/linux/netdevice.h | 13 -
1 file changed, 12 insertions(+
old
tale at least within the Intel code. Drivers are free to use 'priv'
member at the end of the structure.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/net/libeth/types.h | 25 +++
include/net/libeth/tx.h| 129
. WB_ON_ITR is needed since XDPSQs don't
want to work without it at all. Tx queue timeouts fixes are needed
since without them, it's way easier to catch a Tx timeout event when
WB_ON_ITR is enabled.
Alexander Lobakin (3):
libeth: add Tx buffer completion helpers
idpf: convert to libeth
From: Ma Ke
Date: Fri, 30 Aug 2024 21:33:24 +0800
> When auxiliary_device_add() returns error and then calls
> auxiliary_device_uninit(), callback function adev_release
> calls kfree(iadev). We shouldn't call kfree(iadev) again
> in the error handling path. Set 'iadev' to NULL.
>
> Cc: sta...@vg
From: Paul Greenwalt
Date: Mon, 26 Aug 2024 13:39:16 -0400
> E830 supports generic receive and HW_CSUM transmit checksumming.
>
> Generic receive checksum support is provided by hardware calculating the
> checksum over the whole packet and providing it to the driver in the Rx
> flex descriptor.
From: Wojciech Drewek
Date: Wed, 28 Aug 2024 13:15:09 +0200
>
>
> On 21.08.2024 16:31, Alexander Lobakin wrote:
>> From: Wojciech Drewek
>> Date: Wed, 21 Aug 2024 14:15:32 +0200
>>
>>> From: Jacob Keller
>>>
>>> Impleme
From: Przemek Kitszel
Date: Tue, 27 Aug 2024 08:58:33 +0200
> On 8/26/24 19:14, Christophe JAILLET wrote:
>> Le 26/08/2024 à 11:15, Przemek Kitszel a écrit :
>>> On 8/23/24 11:10, Dan Carpenter wrote:
On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote:
>
It would be eve
From: Colin Ian King
Date: Thu, 22 Aug 2024 22:34:10 +0100
> Don't populate the read-only arrays tx_itr and rx_itr on the stack at
> run time, instead make them static const.
>
> Signed-off-by: Colin Ian King
> ---
> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 4 ++--
> 1 file changed, 2
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:39 +0200
> From: Jacob Keller
>
> Add support for receive timestamps to the Rx hotpath. This support only
> works when using the flexible descriptor format, so make sure that we
> request this format by default if we have receive timestamp supp
ieved by
> calling .ndo_hwtstamp_get
>
> The Tx timestamps are not implemented yet so calling set ops for
> Tx path will end with EOPNOTSUPP error code.
>
> Signed-off-by: Jacob Keller
> Reviewed-by: Wojciech Drewek
> Reviewed-by: Rahul Rameshbabu
> Reviewed-by: Simon Horma
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:37 +0200
> From: Mateusz Polchlopek
>
> Rx timestamping introduced in PF driver caused the need of refactoring
> the VF driver mechanism to check packet fields.
[...]
> +static bool iavf_is_descriptor_done(struct iavf_ring *rx_ring,
const
>
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:36 +0200
> From: Jacob Keller
>
> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
> negotiating to enable the advanced flexible descriptor layout. Add the
> flexible NIC layout (RXDID=2) as a member of the Rx descriptor union
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:35 +0200
> From: Mateusz Polchlopek
>
> The union iavf_32byte_rx_desc consists of two unnamed structs defined
> inside. One of them represents legacy 32 byte descriptor and second the
> 16 byte descriptor (extended to 32 byte). Each of them con
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:34 +0200
> From: Mateusz Polchlopek
>
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. This commit changes the prefix from
Imperative. Like "change the prefix and move mentioned structs to...
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:33 +0200
> From: Jacob Keller
>
> The Rx timestamps reported by hardware may only have 32 bits of storage
> for nanosecond time. These timestamps cannot be directly reported to the
> Linux stack, as it expects 64bits of time.
>
> To handle thi
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:32 +0200
> From: Jacob Keller
>
> Implement support for reading the PHC time indirectly via the
> VIRTCHNL_OP_1588_PTP_GET_TIME operation.
[...]
> +/**
> + * iavf_queue_ptp_cmd - Queue PTP command for sending over virtchnl
> + * @adapter: pri
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:31 +0200
> From: Jacob Keller
>
> Add the iavf_ptp.c file and fill it in with a skeleton framework to
> allow registering the PTP clock device.
> Add implementation of helper functions to check if a PTP capability
> is supported and handle chan
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:30 +0200
> From: Jacob Keller
>
> Add a new extended capabilities negotiation to exchange information from
> the PF about what PTP capabilities are supported by this VF. This
> requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiti
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:29 +0200
> From: Jacob Keller
>
> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
> driver the ability to determine what Rx descriptor formats are
> available. This requires sending an additional message during
> initializ
l_ptp_caps structure is
> specifically set aside for this.
> Additionally, each structure has some space reserved for future
> extensions to allow some flexibility.
>
> Signed-off-by: Jacob Keller
> Reviewed-by: Wojciech Drewek
> Reviewed-by: Rahul Rameshbabu
> Reviewed-by: Si
>
> Signed-off-by: Jacob Keller
> Reviewed-by: Wojciech Drewek
> Reviewed-by: Rahul Rameshbabu
> Reviewed-by: Simon Horman
Reviewed-by: Alexander Lobakin
> Signed-off-by: Mateusz Polchlopek
> Signed-off-by: Wojciech Drewek
Thanks,
Olek
From: Wojciech Drewek
Date: Wed, 21 Aug 2024 14:15:27 +0200
> From: Simei Su
>
> To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
> the VF to request PTP capability and responded by the PF what capability
> is enabled for that VF.
>
> Hardware captures timestamps which con
gister.
>
> Signed-off-by: Paul Greenwalt
Reviewed-by: Alexander Lobakin
Thanks,
Olek
0f5 ("ice: add parser execution main loop")
> Signed-off-by: Dan Carpenter
Reviewed-by: Alexander Lobakin
> ---
> drivers/net/ethernet/intel/ice/ice_parser_rt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/in
ff-by: Michal Kubiak
Reviewed-by: Pavan Kumar Linga
Signed-off-by: Alexander Lobakin
Reviewed-by: Simon Horman
Tested-by: Krishneil Singh
Signed-off-by: Tony Nguyen
Link:
https://patch.msgid.link/20240806220923.3359860-3-anthony.l.ngu...@intel.com
Signed-off-by: Jakub Kicinski
---
drivers/net
From: Mateusz Polchlopek
Date: Mon, 12 Aug 2024 12:01:34 +0200
>
>
> On 8/8/2024 2:24 PM, Alexander Lobakin wrote:
>> From: Mateusz Polchlopek
>> Date: Thu, 8 Aug 2024 13:04:29 +0200
>>
>>>
>>>
>>> On 7/30/2024 3:40 PM, Alexander Lobaki
From: Paul Greenwalt
Date: Wed, 31 Jul 2024 21:58:29 -0400
> E830 adds hardware support to prevent the VF from overflowing the PF
> mailbox with VIRTCHNL messages. E830 will use the hardware feature
> (ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf().
>
> To prevent a VF f
From: Kolacinski, Karol
Date: Wed, 7 Aug 2024 16:26:29 +0200
> From: Aleksander Lobakin
> Date: Wed, 07 Aug 2024 15:54 +0200
> +static void ice_ptp_set_funcs_e830(struct ice_pf *pf)
> +{
> +#ifdef CONFIG_ICE_HWTS
> + if (pcie_ptm_enabled(pf->pdev) &&
> + boot_cpu_
From: Mateusz Polchlopek
Date: Thu, 8 Aug 2024 13:04:29 +0200
>
>
> On 7/30/2024 3:40 PM, Alexander Lobakin wrote:
>> From: Mateusz Polchlopek
>> Date: Tue, 30 Jul 2024 05:15:01 -0400
[...]
>>> +bool iavf_ptp_cap_supported(struct iavf_adapter *adapte
From: Mateusz Polchlopek
Date: Thu, 8 Aug 2024 13:04:14 +0200
>
>
> On 7/30/2024 2:54 PM, Alexander Lobakin wrote:
>> From: Mateusz Polchlopek
>> Date: Tue, 30 Jul 2024 05:14:57 -0400
[...]
>>> @@ -3788,6 +3799,65 @@ static int
>>> ice_vc_dis_vlan
ements to IDPF in general. Will follow with with [PATCH v3]
Maybe you'd prepare a full series then right away?
I hope it won't conflict much with my tree (but you always can
double-check[0]) (Chapter II is already posted here on IWL and netdev@)
>
> Thanks,
> Manoj
>
> O
From: Kolacinski, Karol
Date: Mon, 5 Aug 2024 18:21:39 +0200
> From: Aleksander Lobakin
> Date: Fri, 26 Jul 2024 15:37 +0200
>>> +/**
>>> + * ice_ptp_set_funcs_e830 - Set specialized functions for E830 support
>>> + * @pf: Board private structure
>>> + *
>>> + * Assign functions to the PTP capab
From: Manoj Vishwanathan
Date: Mon, 5 Aug 2024 18:21:59 +
> The transaction salt was being accessed before acquiring the
> idpf_vc_xn_lock when idpf has to forward the virtchnl reply.
You need to explain in details here what issue you have faced due to
that, how to reproduce it and how this
iners instead of direct accesses to queue->stats.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf.h| 21 +-
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 54 +-
drivers/net/ethernet/intel/idpf/virtchnl2.h | 33 +-
.../ne
igned-off-by: Joshua Hay
Co-developed-by: Michal Kubiak
Signed-off-by: Michal Kubiak
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 27 ++-
drivers/net/ethernet/intel/idpf/idpf_dev.c| 2 ++
...
"idpf: add singleq start_xmit and napi poll")
Cc: sta...@vger.kernel.org # 6.7+
Signed-off-by: Michal Kubiak
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 9 -
.../ethernet/intel/idpf/idpf_singleq_txrx.c |
descriptor ring wrap calculation to u16 and the normal ring size check.
Signed-off-by: Joshua Hay
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 6 +-
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 24 +--
drivers/net/ethe
copy-paste around the Tx code.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 50 +
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 82 +++-
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 195 ++
3 f
stats and calling
stack -> live update functions; base stats are internal to libeth.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/libeth/Makefile | 4 +-
include/net/libeth/types.h | 247 ++
drivers/net/ethernet/in
Add a shorthand similar to other net*_subqueue() helpers for resetting
the queue by its index w/o obtaining &netdev_tx_queue beforehand
manually.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/linux/netdevice.h | 13 -
1 file changed, 12 insertions(+
old
tale at least within the Intel code. Drivers are free to use 'priv'
member at the end of the structure.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/net/libeth/tx.h | 127
1 file changed, 127 insertions(+)
c
y: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/linux/unroll.h | 50 ++
1 file changed, 50 insertions(+)
create mode 100644 include/linux/unroll.h
diff --git a/include/linux/unroll.h b/include/linux/unroll.h
new file mode 100644
index
lines than adds.
The perf difference is not visible by eye in common scenarios, but
the stats are now more complete and reliable, and also survive
ifups-ifdowns.
Alexander Lobakin (6):
unroll: add generic loop unroll helpers
libeth: add common queue stats
libie: add Tx buffer completion helpers
From: Paul Greenwalt
Date: Wed, 31 Jul 2024 21:58:29 -0400
> E830 adds hardware support to prevent the VF from overflowing the PF
> mailbox with VIRTCHNL messages. E830 will use the hardware feature
> (ICE_F_MBX_LIMIT) instead of the software solution ice_is_malicious_vf().
>
> To prevent a VF f
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:09 -0400
> From: Jacob Keller
>
> Add support for receive timestamps to the Rx hotpath. This support only
> works when using the flexible descriptor format, so make sure that we
> request this format by default if we have receive timestamp s
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:08 -0400
> From: Jacob Keller
>
> Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which allow
> userspace to request timestamp enablement for the device. This support allows
> standard Linux applications to request the times
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:06 -0400
> From: Jacob Keller
>
> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
> negotiating to enable the advanced flexible descriptor layout. Add the
> flexible NIC layout (RXDID=2) as a member of the Rx descriptor un
upcoming commits.
>
> Suggested-by: Alexander Lobakin
> Signed-off-by: Mateusz Polchlopek
OMG great job!
[...]
> @@ -1163,7 +1164,7 @@ static int iavf_clean_rx_irq(struct iavf_ring *rx_ring,
> int budget)
>* which is always zero because packet split isn'
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:04 -0400
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. This commit changes the prefix from
> idpf_* to libeth_* and moves mentioned structs to libeth's rx.h header
> file.
[...]
> diff -
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:03 -0400
> From: Jacob Keller
>
> The Rx timestamps reported by hardware may only have 32 bits of storage
> for nanosecond time. These timestamps cannot be directly reported to the
> Linux stack, as it expects 64bits of time.
[...]
> +stat
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:02 -0400
> From: Jacob Keller
>
> Implement support for reading the PHC time indirectly via the
> VIRTCHNL_OP_1588_PTP_GET_TIME operation.
[...]
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ptp.c
> b/drivers/net/ethernet/intel/iavf
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:01 -0400
> From: Jacob Keller
>
> Add the iavf_ptp.c file and fill it in with a skeleton framework to
> allow registering the PTP clock device.
> Add implementation of helper functions to check if a PTP capability
> is supported and handle c
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:15:00 -0400
> From: Jacob Keller
>
> Add a new extended capabilities negotiation to exchange information from
> the PF about what PTP capabilities are supported by this VF. This
> requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and wa
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:59 -0400
> From: Jacob Keller
>
> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
> driver the ability to determine what Rx descriptor formats are
> available. This requires sending an additional message during
> initia
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:58 -0400
> From: Jacob Keller
>
> Support for allowing VF to negotiate the descriptor format requires that
> the VF specify which descriptor format to use when requesting Rx queues.
> The VF is supposed to request the set of supported format
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:57 -0400
> From: Simei Su
>
> To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
> the VF to request PTP capability and responded by the PF what capability
> is enabled for that VF.
[...]
> diff --git a/drivers/net/ether
From: Mateusz Polchlopek
Date: Tue, 30 Jul 2024 05:14:55 -0400
> [PATCH iwl-next v8 00/14] Add support for Rx timestamping for both ice
> and iavf drivers.
Oops, please remove that period at the end of the sentence when sending
next version.
> Initially, during VF creation it registers the PTP
From: Simon Horman
Date: Fri, 26 Jul 2024 17:09:54 +0100
> On Wed, Jul 24, 2024 at 03:40:22PM +0200, Alexander Lobakin wrote:
>> The second tagged commit introduced a UAF, as it removed restoring
>> q_vector->vport pointers after reinitializating the structures.
>> This
From: Karol Kolacinski
Date: Thu, 25 Jul 2024 11:34:51 +0200
> From: Jacob Keller
>
> The E830 and E82x devices use essentially the same logic for performing
> a crosstimestamp. The only difference is that E830 hardware has
> different offsets. Instead of having two implementations, combine the
From: Karol Kolacinski
Date: Thu, 25 Jul 2024 11:34:50 +0200
> E830 PHY supports timestamp ready bitmap.
> Enable the bitmap by refactoring tx init function.
>
> Reviewed-by: Przemek Kitszel
> Signed-off-by: Karol Kolacinski
[...]
> @@ -987,24 +965,25 @@ ice_ptp_init_tx_e82x(struct ice_pf *p
From: Karol Kolacinski
Date: Thu, 25 Jul 2024 11:34:49 +0200
> Simplify TSYN IRQ processing by moving it to a separate function and
> having appropriate behavior per PHY model, instead of multiple
> conditions not related to HW, but to specific timestamping modes.
>
> Reviewed-by: Przemek Kitsze
From: Karol Kolacinski
Date: Thu, 25 Jul 2024 11:34:48 +0200
> From: Michal Michalik
>
> Add specific functions and definitions for E830 devices to enable
> PTP support.
> Introduce new PHY model ICE_PHY_E830.
> E830 devices support direct write to GLTSYN_ registers without shadow
> registers a
the queues (+ both are freed within one function,
so it's not clear why nullify the pointers at all).
Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues")
Fixes: 90912f9f4f2d ("idpf: convert header split mode to libeth +
napi_build_skb()")
Reported-by: Mich
base name separately, considering that the
function 2) is never called out of idpf_vport_intr_init() context.
Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Cc: sta...@vger.kernel.org # 6.7
Signed-off-by: Michal Kubiak
Reviewed-by: Pavan Kumar Linga
Signed-off-b
e number and reopen the
interface on rollback - that solves limbo states when the device is left
disabled and/or without HW queues enabled.
Fixes: 02cbfba1add5 ("idpf: add ethtool callbacks")
Fixes: e4891e4687c8 ("idpf: split &idpf_queue into 4 strictly-typed queue
str
after the conversion is applied
anyway.
Alexander Lobakin (2):
idpf: fix memory leaks and crashes while performing a soft reset
idpf: fix UAFs when destroying the queues
Michal Kubiak (1):
idpf: fix memleak in vport interrupt configuration
drivers/net/ethernet/intel/idpf/idpf_lib.c | 48
From: Przemek Kitszel
Date: Thu, 20 Jun 2024 17:15:53 +0200
> On 6/20/24 15:53, Alexander Lobakin wrote:
>> __cacheline_group_begin(), unfortunately, doesn't align the group
>> anyhow. If it is wanted, then you need to do something like
>>
>> __cacheline_
From: Alexander Lobakin
Date: Wed, 12 Jun 2024 14:33:17 +0200
> From: Jacob Keller
> Date: Tue, 11 Jun 2024 13:52:57 -0700
>
>>
>>
>> On 6/11/2024 4:47 AM, Alexander Lobakin wrote:
>>> From: Mateusz Polchlopek
>>> Date: Tue, 4 Jun 20
From: Yan Zhai
Date: Thu, 20 Jun 2024 15:19:22 -0700
> Add a common point to transfer offloading info from XDP context to skb.
>
> Signed-off-by: Yan Zhai
> Signed-off-by: Jesper Dangaard Brouer
> ---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 2 ++
> drivers/net/ethernet/intel/ice/ice_xsk
ame as Rx). This HT
is used only for OOO completions, which aren't really hotpath anyway.
Note that this change must be done atomically, otherwise it's really
easy to get lost and miss something.
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf.h| 3 +-
nly after 4 HW writes rather than two.
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/Kconfig | 1 -
drivers/net/ethernet/intel/idpf/idpf.h| 2 -
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 86 +--
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 27 +-
more from the data buffer later. This W/A will hopefully
be removed one day.
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 52 ++--
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 1 +
drivers/net/ethernet/intel/idpf/idpf_txrx.c | 253 -
accordingly. All the HW-related details like buffer alignment are still
accounted. For the header buffers, pick 256 bytes as in most places in
the kernel (have you ever seen frames with bigger headers?).
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
include/net/libeth/rx.h
TATS unconditionally,
while the latter is often turned off for better performance.
Remove all the references to PP stats from the Ethtool code. The stats
are still available in their full via the generic Netlink interface.
Reviewed-by: Przemek Kitszel
Reviewed-by: Jacob Keller
Signed-off-by: Alexander Lob
in
&idpf_rx_queue.
Reviewed-by: Przemek Kitszel
Reviewed-by: Jacob Keller
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/Kconfig | 1 +
drivers/net/ethernet/intel/idpf/idpf.h| 2 +-
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 88 +---
y: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/Kconfig| 13 +
drivers/net/ethernet/intel/idpf/Kconfig | 27 +++
drivers/net/ethernet/intel/idpf/Makefile | 3 ++-
drivers/net/ethernet/intel/idpf/idpf.h| 3 ++-
d
ng is the
same, just call either idpf_tx_splitq_frame() or idpf_tx_singleq_frame()
depending on the active model to actually map and send the skb.
Reviewed-by: Przemek Kitszel
Reviewed-by: Jacob Keller
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 9 ++
this gives up to 2% of perf bump on Rx.
Reviewed-by: Przemek Kitszel
Reviewed-by: Jacob Keller
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 185 +---
1 file changed, 118 insertions(+), 67 deletions(-)
diff --git a/drivers/net/ethernet/intel
masks and put &idpf_q_vector on a good diet.
Also remove redundant pointer to the interrupt name from the structure.
request_irq() saves it and free_irq() returns it on deinit, so that you
can free the memory.
Reviewed-by: Przemek Kitszel
Signed-off-by: Alexander Lobakin
---
drivers/net
Signed-off-by: Alexander Lobakin
---
drivers/net/ethernet/intel/idpf/idpf.h| 1 -
.../net/ethernet/intel/idpf/idpf_lan_txrx.h | 2 +
drivers/net/ethernet/intel/idpf/idpf_txrx.h | 47 ++-
.../ethernet/intel/idpf/idpf_singleq_txrx.c | 20
drivers/net/ethernet
possible, as the size can then be easily predicted.
For the rest, make sure they don't cross the specified bound.
Signed-off-by: Alexander Lobakin
---
include/net/libeth/cache.h | 66 ++
1 file changed, 66 insertions(+)
create mode 100644 include/net/libeth/ca
Instead of doing __cacheline_group_begin() __aligned(), use the new
__cacheline_group_{begin,end}_aligned(), so that it will take care
of the group alignment itself.
Also replace open-coded `4 * sizeof(long)` in two places with
a definition.
Signed-off-by: Alexander Lobakin
---
include/net
E_BYTES`` instead of ``L1_CACHE_BYTES`` as the former
also accounts L2, needed in some cases.
Signed-off-by: Alexander Lobakin
---
include/linux/cache.h | 59 +++
1 file changed, 59 insertions(+)
diff --git a/include/linux/cache.h b/include/linux/cache.
nt DMA uses on hotpath, uses
napi_build_skb() instead of in-place short skb allocation.
Most idpf patches, except for the queue split, removes more lines
than adds.
Expect far better memory utilization and +5-8% on Rx depending on
the case (+17% on skb XDP_DROP :>).
Alexander Lobakin (
From: Willem De Bruijn
Date: Mon, 17 Jun 2024 14:13:07 -0400
> Alexander Lobakin wrote:
>> From: Willem De Bruijn
>> Date: Thu, 30 May 2024 09:46:46 -0400
>>
>>> Alexander Lobakin wrote:
>>>> Currently, idpf uses the following model for the header buff
From: Marcin Szycik
Date: Tue, 18 Jun 2024 16:11:54 +0200
> From: Michal Swiatkowski
>
> Remove unnecessary size checks when copying bitmaps in ice_add_sw_recipe()
> and replace them with compile time assert. Check if the bitmaps are equal
> size, as they are copied both ways.
>
> Signed-off-b
d internal temperature sensor")
>> Signed-off-by: Petr Oros
>> Acked-by: Ivan Vecera
To be added to v2:
Reviewed-by: Alexander Lobakin
Thanks,
Olek
From: Willem De Bruijn
Date: Thu, 30 May 2024 09:46:46 -0400
> Alexander Lobakin wrote:
>> Currently, idpf uses the following model for the header buffers:
>>
>> * buffers are allocated via dma_alloc_coherent();
>> * when receiving, napi_alloc_skb() is called and the
1 - 100 of 398 matches
Mail list logo
