Re: [Intel-wired-lan] [PATCH v2 net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-27 Thread Jiri Pirko
upport for SRIOV on >bonded interface") >Signed-off-by: Thomas Bogendoerfer Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 12:17:10PM CEST, tbogendoer...@suse.de wrote: >On Mon, 26 Aug 2024 11:41:19 +0200 >Jiri Pirko wrote: > >> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >> >For PFs, which don't support SRIOV_LAG, there is no pf->lag

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct >allocated. So before accessing pf->lag a NULL pointer check is needed. > >Signed-off-by: Thomas Bogendoerfer You need to add a "fixes" tag blaming the commit tha

Re: [Intel-wired-lan] [PATCH net-next v3 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-23 Thread Jiri Pirko
Fri, Aug 23, 2024 at 12:25:13AM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v3 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-23 Thread Jiri Pirko
t;pin-set do netlink message. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH net-next v2 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-22 Thread Jiri Pirko
Wed, Aug 21, 2024 at 11:32:18PM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski >--- >v2: >- align to v2 changes of "dpll: add E

Re: [Intel-wired-lan] [PATCH net-next v2 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-22 Thread Jiri Pirko
Wed, Aug 21, 2024 at 11:32:17PM CEST, arkadiusz.kubalew...@intel.com wrote: >Implement and document new pin attributes for providing Embedded SYNC >capabilities to the DPLL subsystem users through a netlink pin-get >do/dump messages. Allow the user to set Embedded SYNC frequency with >pin-set do ne

Re: [Intel-wired-lan] [iwl-next v1] ice: use internal pf id instead of function number

2024-08-14 Thread Jiri Pirko
is a bugfix of something not recent, you should target -net. Also, please provide "Fixes" tag blaming the commit(s) that introduced the issue. > >Reviewed-by: Wojciech Drewek >Suggested-by: Jiri Pirko >Signed-off-by: Michal Swiatkowski >--- > drivers/net/ethernet/int

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:39:42PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 01:29:29PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Fri, Aug 09, 2024 at 12:51:58PM

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 01:05:00PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Aug 09, 2024 at 12:51:58PM +0200, Jiri Pirko wrote: >> Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Aug 08, 2024 at 05:34:35PM

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:18:38AM CEST, pmen...@molgen.mpg.de wrote: >Dear Michal, > > >Thank you for your patch. > >Am 09.08.24 um 07:13 schrieb Michal Swiatkowski: >> On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> > Thu, Aug 08, 2024 at

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-09 Thread Jiri Pirko
Fri, Aug 09, 2024 at 07:13:34AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Aug 08, 2024 at 05:34:35PM +0200, Jiri Pirko wrote: >> Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Use generic devlink PF MSI-X parameter to

Re: [Intel-wired-lan] [iwl-next v3 1/8] ice: devlink PF MSI-X max and min parameter

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 09:20:09AM CEST, michal.swiatkow...@linux.intel.com wrote: >Use generic devlink PF MSI-X parameter to allow user to change MSI-X >range. > >Reviewed-by: Wojciech Drewek >Signed-off-by: Michal Swiatkowski >--- > .../net/ethernet/intel/ice/devlink/devlink.c | 56 ++

Re: [Intel-wired-lan] [PATCH net-next v1 2/2] ice: add callbacks for Embedded SYNC enablement on dpll pins

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 01:20:13PM CEST, arkadiusz.kubalew...@intel.com wrote: >Allow the user to get and set configuration of Embedded SYNC feature >on the ice driver dpll pins. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Arkadiusz Kubalewski >--- > drivers/net/ethernet/intel/ice/ice_dpll.c

Re: [Intel-wired-lan] [PATCH net-next v1 1/2] dpll: add Embedded SYNC feature for a pin

2024-08-08 Thread Jiri Pirko
Thu, Aug 08, 2024 at 01:20:12PM CEST, arkadiusz.kubalew...@intel.com wrote: >Implement and document new pin attributes for providing Embedded SYNC >capabilities to the DPLL subsystem users through a netlink pin-get >do/dump messages. Allow the user to set Embedded SYNC frequency with >pin-set do ne

Re: [Intel-wired-lan] [PATCH iwl-next] i40e: Add support for fw health report

2024-07-16 Thread Jiri Pirko
Mon, Jul 15, 2024 at 09:11:48PM CEST, kh...@redhat.com wrote: >Add support for reporting fw status via the devlink health report. > >Example: > # devlink health show pci/:02:00.0 reporter fw > pci/:02:00.0: > reporter fw > state healthy error 0 recover 0 > # devlink health diagnose pc

Re: [Intel-wired-lan] [PATCH net v3] ice: use proper macro for testing bit

2024-06-18 Thread Jiri Pirko
sensor") >Acked-by: Ivan Vecera >Reviewed-by: Alexander Lobakin >Signed-off-by: Petr Oros Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: Add support for devlink local_forwarding param.

2024-06-03 Thread Jiri Pirko
Mon, Jun 03, 2024 at 02:31:46PM CEST, wojciech.dre...@intel.com wrote: >From: Pawel Kaminski > >Add support for driver-specific devlink local_forwarding param. >Supported values are "enabled", "disabled" and "prioritized". >Default configuration is set to "enabled". > >Add documentation in network

Re: [Intel-wired-lan] [iwl-next v4 05/15] ice: allocate devlink for subfunction

2024-06-03 Thread Jiri Pirko
Mon, Jun 03, 2024 at 11:50:15AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Make devlink allocation function generic to use it for PF and for SF. > >Add function for SF devlink port creation. It will be used in next >patch. > >Create header file for subfunction device

Re: [Intel-wired-lan] [iwl-next v2 03/15] ice: add basic devlink subfunctions support

2024-05-14 Thread Jiri Pirko
Mon, May 13, 2024 at 01:44:14PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Mon, May 13, 2024 at 01:04:23PM +0200, Jiri Pirko wrote: >> Mon, May 13, 2024 at 10:37:23AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >> [...] >> >> >>

Re: [Intel-wired-lan] [iwl-next v2 03/15] ice: add basic devlink subfunctions support

2024-05-13 Thread Jiri Pirko
Mon, May 13, 2024 at 10:37:23AM CEST, michal.swiatkow...@linux.intel.com wrote: [...] >+int ice_devlink_create_sf_port(struct ice_dynamic_port *dyn_port) >+{ >+ struct devlink_port_attrs attrs = {}; >+ struct devlink_port *devlink_port; >+ struct devlink *devlink; >+ struct

Re: [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:24:48AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:18:29PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Hi, >> > >> >Current

Re: [Intel-wired-lan] [iwl-next v1 14/14] ice: allow to activate and deactivate subfunction

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:33:54AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:36:13PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >

Re: [Intel-wired-lan] [iwl-next v1 08/14] ice: create port representor for SF

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:31:15AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:16:05PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >Store subfunction and VF pointer in port

Re: [Intel-wired-lan] [iwl-next v1 06/14] ice: base subfunction aux driver

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:20:51AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:13:55PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:07PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >

Re: [Intel-wired-lan] [iwl-next v1 03/14] ice: add basic devlink subfunctions support

2024-05-10 Thread Jiri Pirko
Fri, May 10, 2024 at 09:13:51AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, May 09, 2024 at 01:06:52PM +0200, Jiri Pirko wrote: >> Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > &g

Re: [Intel-wired-lan] [iwl-next v1 14/14] ice: allow to activate and deactivate subfunction

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:15PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Use previously implemented SF aux driver. It is probe during SF >activation and remove after deactivation. > >Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski >--- > .../eth

Re: [Intel-wired-lan] [iwl-next v1 00/14] ice: support devlink subfunction

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:01PM CEST, michal.swiatkow...@linux.intel.com wrote: >Hi, > >Currently ice driver does not allow creating more than one networking >device per physical function. The only way to have more hardware backed >netdev is to use SR-IOV. > >Following patchset adds support for dev

Re: [Intel-wired-lan] [iwl-next v1 11/14] ice: netdevice ops for SF representor

2024-05-09 Thread Jiri Pirko
Subject does not have verb. Please add it. Otherwise, the patch looks ok. Reviewed-by: Jiri Pirko Tue, May 07, 2024 at 01:45:12PM CEST, michal.swiatkow...@linux.intel.com wrote: >Subfunction port representor needs the basic netdevice ops to work >correctly. Create them. > >

Re: [Intel-wired-lan] [iwl-next v1 08/14] ice: create port representor for SF

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:09PM CEST, michal.swiatkow...@linux.intel.com wrote: >Store subfunction and VF pointer in port representor structure as an >union. Add port representor type to distinguish between each of them. > >Keep the same flow of port representor creation, but instead of general >at

Re: [Intel-wired-lan] [iwl-next v1 06/14] ice: base subfunction aux driver

2024-05-09 Thread Jiri Pirko
dcast filter is added to allow traffic to pass. > >Store subfunction pointer in VSI struct. The same is done for VF >pointer. Make union of subfunction and VF pointer as only one of them >can be set with one VSI. > >Reviewed-by: Jiri Pirko >Signed-off-by: Piotr Raczynski >S

Re: [Intel-wired-lan] [iwl-next v1 03/14] ice: add basic devlink subfunctions support

2024-05-09 Thread Jiri Pirko
Tue, May 07, 2024 at 01:45:04PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Config

Re: [Intel-wired-lan] [iwl-next v2 0/4] ice: prepare representor for SF support

2024-05-06 Thread Jiri Pirko
ate function is called. > >The code for this patchset was split from (too big) patchset [1]. > >v1 --> v2 [2]: > * add returns for kdoc in ice_eswitch_cfg_vsi Looks ok. set- Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-29 Thread Jiri Pirko
Sat, Apr 27, 2024 at 12:25:44AM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/26/2024 6:43 AM, Jiri Pirko wrote: >> Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >>> On 4/26/24 13:19, Jiri Pirko wrote: >>>> Wed, Apr 24,

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote: >On 4/26/24 13:19, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: >> > >> > >> > On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> > > W

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-26 Thread Jiri Pirko
Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/24/2024 8:07 AM, Jiri Pirko wrote: >> Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: >>> >>> >>> On 4/23/2024 6:14 AM, Jiri Pirko wrote: >>>>

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-24 Thread Jiri Pirko
Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote: > > >On 4/23/2024 6:14 AM, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote: >>> >>> >>>> -----Original Message- >>>> Fro

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-24 Thread Jiri Pirko
Wed, Apr 24, 2024 at 03:49:09PM CEST, piotr.kwapulin...@intel.com wrote: >>>-Original Message- >>>From: Jiri Pirko >>>Sent: Monday, April 22, 2024 4:26 PM >>>To: Kwapulinski, Piotr >>>Cc: intel-wired-...@lists.osuosl.org; net...@vger.kerne

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 03:54:05PM CEST, vinsc...@redhat.com wrote: >Hi Jiri, > >On Apr 23 13:26, Jiri Pirko wrote: >> Tue, Apr 23, 2024 at 12:24:46PM CEST, vinsc...@redhat.com wrote: >> >From: Paolo Abeni >> > >> >Sabrina reports that the igb driver does

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote: > > >> -Original Message----- >> From: Jiri Pirko >> Sent: Tuesday, April 23, 2024 1:36 PM >> To: Temerkhanov, Sergey >> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Extend auxbus device naming

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 11:14:59AM CEST, sergey.temerkha...@intel.com wrote: >Include segment/domain number in the device name to distinguish >between PCI devices located on different root complexes in >multi-segment configurations. Naming is changed from >ptp___clk to ptpclk I don't understand

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Tue, Apr 23, 2024 at 12:24:46PM CEST, vinsc...@redhat.com wrote: >From: Paolo Abeni > >Sabrina reports that the igb driver does not cope well with large >MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload >corruption on TX. > >The root cause of the issue is that the driver does not tak

Re: [Intel-wired-lan] [PATCH] igb: cope with large MAX_SKB_FRAGS.

2024-04-23 Thread Jiri Pirko
Dubroca >Tested-by: Sabrina Dubroca >Tested-by: Corinna Vinschen >Signed-off-by: Paolo Abeni Reviewed-by: Jiri Pirko Next time, please indicate target tree (net) in [patch] brackets. >--- > drivers/net/ethernet/intel/igb/igb_main.c | 1 + > 1 file changed, 1 insertion(+) > &g

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/5] ixgbe: Enable link management in E610 device

2024-04-22 Thread Jiri Pirko
Mon, Apr 22, 2024 at 03:06:11PM CEST, piotr.kwapulin...@intel.com wrote: [...] >diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >b/drivers/net/ethernet/intel/ixgbe/ixgbe.h >index 559b443..ea6df1e 100644 >--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h >+++ b/drivers/net/ethernet/intel/ixgb

Re: [Intel-wired-lan] [iwl-next v1 0/4] ice: prepare representor for SF support

2024-04-22 Thread Jiri Pirko
Fri, Apr 19, 2024 at 07:13:32PM CEST, michal.swiatkow...@linux.intel.com wrote: >Hi, > >This is a series to prepare port representor for supporting also >subfunctions. We need correct devlink locking and the possibility to >update parent VSI after port representor is created. > >Refactor how devlin

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 06:11:38PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 05:43:25PM +0200, Jiri Pirko wrote: >> Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Apr 18, 2024 at 03:02:49PM

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 03:02:49PM +0200, Jiri Pirko wrote: >> Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >On Thu, Apr 18, 2024 at 02:04:21PM

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com wrote: >On Thu, Apr 18, 2024 at 02:04:21PM +0200, Jiri Pirko wrote: >> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> &

Re: [Intel-wired-lan] [iwl-next v4 6/8] ice: base subfunction aux driver

2024-04-18 Thread Jiri Pirko
Wed, Apr 17, 2024 at 04:20:26PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski [...] >+static int ice_sf_dev_probe(struct auxiliary_device *adev, >+ const struct auxiliary_device_id *id) >+{ >+ struct ice_sf_dev *sf_dev = ice_adev_to_sf_dev(

Re: [Intel-wired-lan] [iwl-next v4 5/8] ice: allocate devlink for subfunction

2024-04-18 Thread Jiri Pirko
Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski [...] >+/** >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer >+ * @dev: the device to allocate for >+ * >+ * Allocate a devlink instance for SF. >+ * >+ * Return: void po

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-16 Thread Jiri Pirko
Tue, Apr 16, 2024 at 08:16:17AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Tue, Apr 16, 2024 at 07:14:43AM +0200, Michal Swiatkowski wrote: >> On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote: >> > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow.

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-15 Thread Jiri Pirko
Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com wrote: >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote: >> Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski

Re: [Intel-wired-lan] [iwl-next v1] ice: Remove ndo_get_phys_port_name

2024-04-12 Thread Jiri Pirko
Fri, Mar 08, 2024 at 11:58:42AM CET, dariusz.aftan...@linux.intel.com wrote: >ndo_get_phys_port_name is never actually used, as in switchdev >devklink is always being created. > >Reviewed-by: Michal Swiatkowski >Signed-off-by: Dariusz Aftanski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 4/7] ice: allocate devlink for subfunction

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:50AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Make devlink allocation function generic to use it for PF and for SF. > >Add function for SF devlink port creation. It will be used in next >patch. > >Create header file for subfunction device

Re: [Intel-wired-lan] [iwl-next v3 6/7] ice: implement netdev for subfunction

2024-04-12 Thread Jiri Pirko
>Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 5/7] ice: base subfunction aux driver

2024-04-12 Thread Jiri Pirko
dcast filter is added to allow traffic to pass. > >Signed-off-by: Piotr Raczynski >Signed-off-by: Michal Swiatkowski Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v3 3/7] ice: add basic devlink subfunctions support

2024-04-12 Thread Jiri Pirko
Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Config

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 03:57:35PM CEST, ksund...@redhat.com wrote: >On Tue, Apr 2, 2024 at 4:51 PM Jiri Pirko wrote: >> >> Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >> >Changing the MAC address of the VFs is currently unsupported via devlink. >>

Re: [Intel-wired-lan] [PATCH v7] ice: Add get/set hw address for VFs using devlink commands

2024-04-02 Thread Jiri Pirko
Tue, Apr 02, 2024 at 11:22:54AM CEST, ksund...@redhat.com wrote: >Changing the MAC address of the VFs is currently unsupported via devlink. >Add the function handlers to set and get the HW address for the VFs. > >Signed-off-by: Karthik Sundaravel >--- > drivers/net/ethernet/intel/ice/ice_devlink.c

Re: [Intel-wired-lan] [PATCH v2 net] ice: Fix freeing uninitialized pointers

2024-03-21 Thread Jiri Pirko
ecessary devm_ usage") >Signed-off-by: Dan Carpenter Reviewed-by: Jiri Pirko >--- >v2: I missed a couple pointers in v1. > >The change to ice_update_link_info() isn't required because it's >assigned on the very next line... But I did that because it's ha

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-18 Thread Jiri Pirko
Sat, Mar 16, 2024 at 10:44:40AM CET, dan.carpen...@linaro.org wrote: >Automatically cleaned up pointers need to be initialized before exiting >their scope. In this case, they need to be initialized to NULL before >any return statement. > >Fixes: 90f821d72e11 ("ice: avoid unnecessary devm_ usage")

Re: [Intel-wired-lan] [PATCH iwl-next v6 5/6] ice: Add tx_scheduling_layers devlink param

2024-03-11 Thread Jiri Pirko
Mon, Mar 11, 2024 at 01:49:37PM CET, mateusz.polchlo...@intel.com wrote: > > >On 3/11/2024 9:17 AM, Jiri Pirko wrote: >> Fri, Mar 08, 2024 at 11:16:25AM CET, mateusz.polchlo...@intel.com wrote: >> > >> > >> > On 3/6/2024 9:41 AM, Jiri Pirko wrote:

Re: [Intel-wired-lan] [PATCH iwl-next v6 5/6] ice: Add tx_scheduling_layers devlink param

2024-03-11 Thread Jiri Pirko
Fri, Mar 08, 2024 at 11:16:25AM CET, mateusz.polchlo...@intel.com wrote: > > >On 3/6/2024 9:41 AM, Jiri Pirko wrote: >> Tue, Mar 05, 2024 at 03:39:41PM CET, mateusz.polchlo...@intel.com wrote: >> > From: Lukasz Czapnik >> > >> > It was observed that

Re: [Intel-wired-lan] [PATCH net-next v2 1/3] ice: add ice_adapter for shared data across PFs on the same NIC

2024-03-07 Thread Jiri Pirko
Wed, Mar 06, 2024 at 08:20:33PM CET, mschm...@redhat.com wrote: >On Wed, Mar 6, 2024 at 6:00 PM Jiri Pirko wrote: >> Wed, Mar 06, 2024 at 05:29:05PM CET, mschm...@redhat.com wrote: >> >There is a need for synchronization between ice PFs on the same physical >> >adap

Re: [Intel-wired-lan] [PATCH net-next v2 1/3] ice: add ice_adapter for shared data across PFs on the same NIC

2024-03-06 Thread Jiri Pirko
Wed, Mar 06, 2024 at 05:29:05PM CET, mschm...@redhat.com wrote: >There is a need for synchronization between ice PFs on the same physical >adapter. > >Add a "struct ice_adapter" for holding data shared between PFs of the >same multifunction PCI device. The struct is refcounted - each ice_pf >holds

Re: [Intel-wired-lan] [PATCH iwl-next v6 6/6] ice: Document tx_scheduling_layers parameter

2024-03-06 Thread Jiri Pirko
akub Kicinski >Co-developed-by: Mateusz Polchlopek >Signed-off-by: Mateusz Polchlopek Reviewed-by: Jiri Pirko

Re: [Intel-wired-lan] [PATCH iwl-next v6 5/6] ice: Add tx_scheduling_layers devlink param

2024-03-06 Thread Jiri Pirko
Tue, Mar 05, 2024 at 03:39:41PM CET, mateusz.polchlo...@intel.com wrote: >From: Lukasz Czapnik > >It was observed that Tx performance was inconsistent across all queues >and/or VSIs and that it was directly connected to existing 9-layer >topology of the Tx scheduler. > >Introduce new private devli

Re: [Intel-wired-lan] [PATCH iwl-next v6 1/6] devlink: extend devlink_param *set pointer

2024-03-06 Thread Jiri Pirko
k_set_parent, > }; > >-static int >-ice_devlink_enable_roce_get(struct devlink *devlink, u32 id, >- struct devlink_param_gset_ctx *ctx) >+static int ice_devlink_enable_roce_get(struct devlink *devlink, u32 id, >+ stru

Re: [Intel-wired-lan] [PATCH iwl-next v5 4/5] ice: Add tx_scheduling_layers devlink param

2024-03-01 Thread Jiri Pirko
Fri, Mar 01, 2024 at 02:41:56PM CET, mateusz.polchlo...@intel.com wrote: > > >On 2/28/2024 4:57 PM, Jiri Pirko wrote: >> Wed, Feb 28, 2024 at 03:20:53PM CET, mateusz.polchlo...@intel.com wrote: >> > From: Lukasz Czapnik >> > >> > It was observed that

Re: [Intel-wired-lan] [PATCH iwl-net 0/5] ice: LLDP support for VFs

2024-02-29 Thread Jiri Pirko
Wed, Feb 28, 2024 at 05:47:45PM CET, k...@kernel.org wrote: >On Wed, 28 Feb 2024 16:59:44 +0100 Larysa Zaremba wrote: >> Allow to: >> * receive LLDP packets on a VF >> * transmit LLDP from a VF >> >> Only a single VF per port can transmit LLDP packets, >> all trusted VFs can transmit LLDP packets.

Re: [Intel-wired-lan] [PATCH iwl-net 4/5] ice: Implement VF LLDP RX support on VF

2024-02-29 Thread Jiri Pirko
Wed, Feb 28, 2024 at 04:59:48PM CET, larysa.zare...@intel.com wrote: [...] >diff --git a/drivers/net/ethernet/intel/ice/ice_main.c >b/drivers/net/ethernet/intel/ice/ice_main.c >index 9c2c8637b4a7..af3611055e60 100644 >--- a/drivers/net/ethernet/intel/ice/ice_main.c >+++ b/drivers/net/ethernet/i

Re: [Intel-wired-lan] [PATCH iwl-next v5 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-28 Thread Jiri Pirko
Wed, Feb 28, 2024 at 03:20:53PM CET, mateusz.polchlo...@intel.com wrote: >From: Lukasz Czapnik > >It was observed that Tx performance was inconsistent across all queues >and/or VSIs and that it was directly connected to existing 9-layer >topology of the Tx scheduler. > >Introduce new private devli

Re: [Intel-wired-lan] [PATCH] i40e: Prevent setting MTU if greater than MFS

2024-02-28 Thread Jiri Pirko
rent MFS. >It will avoid being in the position of having an MTU set to 9000 on the >netdev with a firmware refusing packets larger than 1536. > >A typical trace looks like the following : >[ 377.548696] i40e :5d:00.0 eno5: Error changing mtu to 9000 which is >greater than th

Re: [Intel-wired-lan] [PATCH v4] ice: Add get/set hw address for VFs using devlink commands

2024-02-27 Thread Jiri Pirko
Sat, Feb 24, 2024 at 01:44:06PM CET, ksund...@redhat.com wrote: >Changing the MAC address of the VFs are not available >via devlink. Add the function handlers to set and get >the HW address for the VFs. > >Signed-off-by: Karthik Sundaravel >--- > drivers/net/ethernet/intel/ice/ice_devlink.c | 88 +

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-27 Thread Jiri Pirko
Tue, Feb 27, 2024 at 04:41:52PM CET, and...@lunn.ch wrote: >> What if it would not be unique, should they then proceed to add generic >> (other word would be "common") param, and make the other driver/s use >> it? Without deprecating the old method ofc. > >If it is useful, somebody else will copy i

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-27 Thread Jiri Pirko
Tue, Feb 27, 2024 at 02:05:45PM CET, przemyslaw.kits...@intel.com wrote: >On 2/27/24 13:17, Jiri Pirko wrote: >> Tue, Feb 27, 2024 at 03:37:00AM CET, k...@kernel.org wrote: >> > On Sun, 25 Feb 2024 08:18:00 +0100 Jiri Pirko wrote: >> > > > Do you recall any spec

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-27 Thread Jiri Pirko
Tue, Feb 27, 2024 at 03:37:00AM CET, k...@kernel.org wrote: >On Sun, 25 Feb 2024 08:18:00 +0100 Jiri Pirko wrote: >> >Do you recall any specific param that got rejected from mlx5? >> >Y'all were allowed to add the eq sizing params, which I think >> >is not going

Re: [Intel-wired-lan] [PATCH net-next 1/3] ice: add ice_adapter for shared data across PFs on the same NIC

2024-02-26 Thread Jiri Pirko
Mon, Feb 26, 2024 at 04:11:23PM CET, mschm...@redhat.com wrote: >There is a need for synchronization between ice PFs on the same physical >adapter. > >Add a "struct ice_adapter" for holding data shared between PFs of the >same multifunction PCI device. The struct is refcounted - each ice_pf >holds

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Add support for devlink loopback param.

2024-02-26 Thread Jiri Pirko
Fri, Dec 08, 2023 at 01:42:27AM CET, pawel.kamin...@intel.com wrote: >Add support for driver-specific devlink loopback param. Supported values >are "enabled", "disabled" and "prioritized". Default configuration is >set to "enabled". > >Add documentation in networking/devlink/ice.rst. > >In previous

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-24 Thread Jiri Pirko
Fri, Feb 23, 2024 at 03:27:57PM CET, k...@kernel.org wrote: >On Fri, 23 Feb 2024 10:45:01 +0100 Jiri Pirko wrote: >>> Jiri, I'm not aware of any other devices with this sort of trade off. >>> We shouldn't add the param if either: >>> - this can be chang

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-23 Thread Jiri Pirko
Fri, Feb 23, 2024 at 12:07:17AM CET, k...@kernel.org wrote: >On Thu, 22 Feb 2024 14:25:21 +0100 Mateusz Polchlopek wrote: >> >> This is kind of proprietary param similar to number of which were shot >> >> down for mlx5 in past. Jakub? >> > >> > I remain somewhat confused about what this does. >>

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-19 Thread Jiri Pirko
Mon, Feb 19, 2024 at 02:33:54PM CET, przemyslaw.kits...@intel.com wrote: >On 2/19/24 13:37, Jiri Pirko wrote: >> Mon, Feb 19, 2024 at 11:05:57AM CET, mateusz.polchlo...@intel.com wrote: >> > From: Lukasz Czapnik >> > >> > It was observed that Tx performanc

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/5] ice: Add tx_scheduling_layers devlink param

2024-02-19 Thread Jiri Pirko
s is kind of proprietary param similar to number of which were shot down for mlx5 in past. Jakub? Also, given this is apparently nvconfig configuration, there could be probably more suitable to use some provisioning tool. This is related to the mlx5 misc driver. Until be figure out the plan, this has my nack: NAcked-by: Jiri Pirko

Re: [Intel-wired-lan] [iwl-next v1 07/15] ice: add auxiliary device sfnum attribute

2024-02-14 Thread Jiri Pirko
Tue, Feb 13, 2024 at 11:04:00PM CET, jacob.e.kel...@intel.com wrote: > > >On 2/13/2024 3:55 AM, Michal Swiatkowski wrote: >> On Tue, Feb 13, 2024 at 12:29:40PM +0100, Jiri Pirko wrote: >>> Tue, Feb 13, 2024 at 10:53:50AM CET, michal.swiatkow...@linux.intel.com >>>

Re: [Intel-wired-lan] [iwl-next v1 04/15] ice: add basic devlink subfunctions support

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 01:02:43PM CET, michal.swiatkow...@linux.intel.com wrote: >On Tue, Feb 13, 2024 at 12:27:20PM +0100, Jiri Pirko wrote: >> Tue, Feb 13, 2024 at 10:39:47AM CET, michal.swiatkow...@linux.intel.com >> wrote: >> >On Tue, Feb 13, 2024 at 09:55:20AM

Re: [Intel-wired-lan] [iwl-next v1 6/7] ice: enable_rdma devlink param

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 11:19:49AM CET, wojciech.dre...@intel.com wrote: > > >On 13.02.2024 10:58, Michal Swiatkowski wrote: >> On Tue, Feb 13, 2024 at 10:07:17AM +0100, Jiri Pirko wrote: >>> Tue, Feb 13, 2024 at 08:35:08AM CET, michal.swiatkow...@linux.intel.com &

Re: [Intel-wired-lan] [iwl-next v1 1/7] ice: devlink PF MSI-X max and min parameter

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 11:01:08AM CET, michal.swiatkow...@linux.intel.com wrote: >On Tue, Feb 13, 2024 at 10:03:05AM +0100, Jiri Pirko wrote: >> Tue, Feb 13, 2024 at 08:35:03AM CET, michal.swiatkow...@linux.intel.com >> wrote: >> >Use generic devlink PF MSI-X parameter to al

Re: [Intel-wired-lan] [iwl-next v1 07/15] ice: add auxiliary device sfnum attribute

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 10:53:50AM CET, michal.swiatkow...@linux.intel.com wrote: >On Tue, Feb 13, 2024 at 09:59:14AM +0100, Jiri Pirko wrote: >> Tue, Feb 13, 2024 at 08:27:16AM CET, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >

Re: [Intel-wired-lan] [iwl-next v1 06/15] ice: add subfunction aux driver support

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 10:43:00AM CET, michal.swiatkow...@linux.intel.com wrote: >On Tue, Feb 13, 2024 at 09:57:12AM +0100, Jiri Pirko wrote: >> Tue, Feb 13, 2024 at 08:27:15AM CET, michal.swiatkow...@linux.intel.com >> wrote: >> >From: Piotr Raczynski >> > >&g

Re: [Intel-wired-lan] [iwl-next v1 04/15] ice: add basic devlink subfunctions support

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 10:39:47AM CET, michal.swiatkow...@linux.intel.com wrote: >On Tue, Feb 13, 2024 at 09:55:20AM +0100, Jiri Pirko wrote: >> Tue, Feb 13, 2024 at 08:27:13AM CET, michal.swiatkow...@linux.intel.com >> wrote: >> &

Re: [Intel-wired-lan] [iwl-next v1 6/7] ice: enable_rdma devlink param

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:35:08AM CET, michal.swiatkow...@linux.intel.com wrote: >Implement enable_rdma devlink parameter to allow user to turn RDMA >feature on and off. > >It is useful when there is no enough interrupts and user doesn't need >RDMA feature. > >Reviewed-by: Jan Sokolowski >Reviewed-b

Re: [Intel-wired-lan] [iwl-next v1 1/7] ice: devlink PF MSI-X max and min parameter

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:35:03AM CET, michal.swiatkow...@linux.intel.com wrote: >Use generic devlink PF MSI-X parameter to allow user to change MSI-X >range. > >Reviewed-by: Wojciech Drewek >Signed-off-by: Michal Swiatkowski >--- > drivers/net/ethernet/intel/ice/ice.h | 8 ++ > drivers/net

Re: [Intel-wired-lan] [iwl-next v1 10/15] ice: create port representor for SF

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:27:19AM CET, michal.swiatkow...@linux.intel.com wrote: >Store subfunction and VF pointer in port representor structure as an >union. Add port representor type to distinguish between each of them. > >Keep the same flow of port representor creation, but instead of general >att

Re: [Intel-wired-lan] [iwl-next v1 07/15] ice: add auxiliary device sfnum attribute

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:27:16AM CET, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Add read only sysfs attribute for each auxiliary subfunction >device. This attribute is needed for orchestration layer >to distinguish SF devices from each other since there is no >native devli

Re: [Intel-wired-lan] [iwl-next v1 06/15] ice: add subfunction aux driver support

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:27:15AM CET, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Instead of only registering devlink port by the ice driver itself, >let PF driver only register port representor for a given subfunction. >Then, aux driver is supposed to register its own devli

Re: [Intel-wired-lan] [iwl-next v1 04/15] ice: add basic devlink subfunctions support

2024-02-13 Thread Jiri Pirko
Tue, Feb 13, 2024 at 08:27:13AM CET, michal.swiatkow...@linux.intel.com wrote: >From: Piotr Raczynski > >Implement devlink port handlers responsible for ethernet type devlink >subfunctions. Create subfunction devlink port and setup all resources >needed for a subfunction netdev to operate. Configu

Re: [Intel-wired-lan] [PATCH v2] ice: Add get/set hw address for VFs using devlink commands

2024-02-08 Thread Jiri Pirko
Thu, Feb 08, 2024 at 09:24:55AM CET, ksund...@redhat.com wrote: >Changing the MAC address of the VF ports are not available >via devlink. Add the function handlers to set and get >the HW address for the VF ports. "VFs". Avoid the word "port" here, as it may falsely indicate you are talking about t

Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe

2024-02-02 Thread Jiri Pirko
Fri, Feb 02, 2024 at 01:40:18PM CET, aleksander.loba...@intel.com wrote: >From: Alexander Lobakin >Date: Fri, 2 Feb 2024 13:39:28 +0100 > >> From: Michal Schmidt >> Date: Thu, 1 Feb 2024 19:40:17 +0100 >> >>> On 1/31/24 17:59, Alexander Lobakin wrote: >&

Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 05:15:46PM CET, pmen...@molgen.mpg.de wrote: >Dear karthiksundaravel, > > >Thank you for your patch. > > >Am 31.01.24 um 09:08 schrieb karthiksundaravel: >> Changing the mac address of the VF representor ports are not > >Do you mean “is not possible”? > >> available via devlink

Re: [Intel-wired-lan] [PATCH net] ice: fix unaligned access in ice_create_lag_recipe

2024-01-31 Thread Jiri Pirko
Wed, Jan 31, 2024 at 12:58:23PM CET, mschm...@redhat.com wrote: >new_rcp->recipe_bitmap was written to as if it were an aligned bitmap. >It is an 8-byte array, but aligned only to 4. >Use put_unaligned to set its value. > >Additionally, values in ice commands are typically in little-endian. >I assu

  1   2   >