Re: [Intel-wired-lan] e1000e preventing sleep and causing repeated desktop hangs

2024-10-06 Thread Lifshits, Vitaly
On 10/4/2024 1:31 PM, Yonatan Avhar wrote: [1.] One line summary of the problem: When suspending my Lenovo ThinkPad P14s Gen 5 (Intel) with the latest Fedora 40 kernel, the system fails to suspend, then begins to hang/stutter every few seconds. [2.] Full description of the problem/report:

Re: [Intel-wired-lan] [PATCH v2 net-next] e1000e: makes e1000_watchdog_task use queue_delayed_work

2024-10-05 Thread Lifshits, Vitaly
On 10/2/2024 7:59 PM, Dmitrii Ermakov wrote: Replaces watchdog timer with delayed_work as advised in the driver's TODO comment. Signed-off-by: Dmitrii Ermakov --- V1 -> V2: Removed redundant line wraps, renamed e1000_watchdog to e1000_watchdog_work drivers/net/ethernet/intel/e1000e/e1000

Re: [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs

2024-10-01 Thread Lifshits, Vitaly
On 10/1/2024 1:50 PM, Simon Horman wrote: On Mon, Sep 30, 2024 at 05:12:31PM +, Joe Damato wrote: Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue information. After this patch is applied, note the IRQs assigned to my NIC: $ cat /proc/interrupts | grep ens | cut

Re: [Intel-wired-lan] igc: Network failure, reboot required: igc: Failed to read reg 0xc030!

2024-09-15 Thread Lifshits, Vitaly
On 9/14/2024 12:52 AM, Jesper Juhl wrote: On Fri, 13 Sept 2024 at 09:02, Lifshits, Vitaly wrote: On 9/12/2024 10:45 PM, Jesper Juhl wrote: Would you be able to decode the stack trace? It may be helpful to figure out which line of code this is: igc_update_stats+0x8a/0x6d0 [igc

Re: [Intel-wired-lan] igc: Network failure, reboot required: igc: Failed to read reg 0xc030!

2024-09-13 Thread Lifshits, Vitaly
On 9/12/2024 10:45 PM, Jesper Juhl wrote: Would you be able to decode the stack trace? It may be helpful to figure out which line of code this is: igc_update_stats+0x8a/0x6d0 [igc 22e0a697bfd5a86bd5c20d279bfffd 131de6bb32] Of course. Just tell me what to do. - Jesper On Thu, 12 Sept 202

Re: [Intel-wired-lan] [PATCH v1 net-next] e1000e: Remove duplicated writel() in e1000_configure_tx/rx()

2024-09-05 Thread Lifshits, Vitaly
On 9/4/2024 3:36 PM, Vitaly Lifshits wrote: On 9/4/2024 3:13 PM, Andrew Lunn wrote: On Wed, Sep 04, 2024 at 02:56:46PM +0900, Takamitsu Iwai wrote: So you have confirmed with the datsheet that the write is not needed? As i said, this is a hardware register, not memory. Writes are not always

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: change I219 (19) devices to ADP

2024-08-18 Thread Lifshits, Vitaly
Dear Paul, On 8/15/2024 5:16 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. Am 15.08.24 um 15:11 schrieb Vitaly Lifshits: Change the MAC and board types of I219 (19) devices from MTP to ADP. These devices have hardware more closely related to ADP than MTP. According to what

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-23 Thread Lifshits, Vitaly
of your device is 80 and not 0 as usual, do you use virtualization features? If so, can you please disable them and retest? -Original Message- From: Lifshits, Vitaly Sent: Wednesday, June 19, 2024 11:37 PM To: intel-wired-lan@osuosl.org Cc: hui.w...@canonical.com; Lifshits, Vitaly ; Bra

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/1] e1000e: fix force smbus during suspend flow

2024-06-20 Thread Lifshits, Vitaly
On 6/20/2024 9:47 AM, Paul Menzel wrote: Dear Vitaly, Thank you for your patch. For the summary, it’d be great if you could be more specific by saying it’s about limiting the scope. Am 20.06.24 um 08:36 schrieb Vitaly Lifshits: Commit 861e8086029e ("e1000e: move force SMBUS from enable u

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: fix force smbus during suspend flow

2024-06-19 Thread Lifshits, Vitaly
Hi Hui, On 6/14/2024 4:53 AM, Hui Wang wrote: Hi Vitaly I tested the patch on a laptop with the ethernet card [8086:550A], the system suspend and resume worked well with the cable plugged or unplugged. But I still think that reverting 2 regression commits is a better solution. Reverting th

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Fix S0ix residency on Meteor Lake corporate systems

2024-05-29 Thread Lifshits, Vitaly
On 5/28/2024 1:43 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. Am 28.05.24 um 12:33 schrieb Vitaly Lifshits: From: Dima Ruinskiy On vPro systems,the  configuration of the I219-LM to achieve power s/,the  /, the / Thank you for noticing it. I will fix it in a v2. gat

Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-17 Thread Lifshits, Vitaly
On 4/13/2024 12:27 PM, Hui Wang wrote: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the ethernet works well after suspend and resume, but after applyin

Re: [Intel-wired-lan] [PATCH] e1000e: move force SMBUS near the end of enable_ulp function

2024-04-15 Thread Lifshits, Vitaly
On 4/13/2024 12:27 PM, Hui Wang wrote: The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue") introduces a regression on CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without this commit, the ethernet works well after suspend and resume, but after applyin

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

2024-02-29 Thread Lifshits, Vitaly
On 2/29/2024 4:31 PM, Paul Menzel wrote: Dear Vitaly, Thank you for your reply. Am 29.02.24 um 11:34 schrieb Lifshits, Vitaly: On 2/12/2024 11:00 AM, Paul Menzel wrote: Am 11.02.24 um 16:12 schrieb Vitaly Lifshits: Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: move force SMBUS from enable ulp function to avoid PHY loss issue

2024-02-29 Thread Lifshits, Vitaly
On 2/12/2024 11:00 AM, Paul Menzel wrote: Dear Vitaly, Thank you for your patch. Am 11.02.24 um 16:12 schrieb Vitaly Lifshits: Forcing SMBUS inside the ULP enabling flow leads to sporadic PHY loss on some systems. Please list the systems you know of. On some Meteor-lake systems, we also

Re: [Intel-wired-lan] [PATH iwl-next v1 1/1] e1000e: Minor flow correction in e1000_shutdown function

2024-01-04 Thread Lifshits, Vitaly
Dear Paul, Thank you for your comments. On 1/3/2024 5:27 PM, Paul Menzel wrote: Dear Vitaly, Thank you for the patch. In the commit message summary, it’d be great if you used a statement by adding a verb in imperative mood. Maybe: Correct flow in e1000_shutdown() Am 03.01.24 um 09:50 sch