[Intel-wired-lan] [PATCH iwl-net] ice: Fix VSI list rule with ICE_SW_LKUP_LAST type

2024-06-05 Thread Marcin Szycik
flower skip_sw \ dst_mac ff:ff:ff:ff:ff:ff action mirred egress redirect dev $VF2_PR Fixes: 0f94570d0cae ("ice: allow adding advanced rules") Suggested-by: Michal Swiatkowski Reviewed-by: Michal Swiatkowski Reviewed-by: Przemek Kitszel Signed-off-by: Marcin Szycik --- drivers/ne

[Intel-wired-lan] [PATCH iwl-next] ice: remove correct filters during eswitch release

2024-04-23 Thread Marcin Szycik
: 50d62022f455 ("ice: default Tx rule instead of to queue") Reviewed-by: Wojciech Drewek Signed-off-by: Michal Swiatkowski Signed-off-by: Marcin Szycik --- It is targetting iwl-next with fix, because the broken patch isn't yet in net repo. --- drivers/net/ethernet/intel/ice/ice_esw

Re: [Intel-wired-lan] [PATCH 0/5] Ensure the copied buf is NULL terminated

2024-04-23 Thread Marcin Szycik
On 22.04.2024 18:41, Bui Quang Minh wrote: > Hi everyone, > > I found that some drivers contains an out-of-bound read pattern like this > > kern_buf = memdup_user(user_buf, count); > ... > sscanf(kern_buf, ...); > > The sscanf can be replaced by some other string-related

[Intel-wired-lan] [PATCH iwl-next] ice: Deduplicate tc action setup

2024-04-15 Thread Marcin Szycik
ice_tc_setup_redirect_action() and ice_tc_setup_mirror_action() are almost identical, except for setting filter action. Reduce them to one function with an extra param, which handles both cases. Reviewed-by: Mateusz Polchlopek Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice

[Intel-wired-lan] [PATCH iwl-net] ice: Fix checking for unsupported keys on non-tunnel device

2024-04-09 Thread Marcin Szycik
sys/class/net/$PF1/device/sriov_numvfs tc qdisc add dev $VF1_PR ingress ethtool -K $PF1 hw-tc-offload on tc filter add dev $VF1_PR ingress flower enc_ttl 12 skip_sw action drop Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support") Reviewed-by: Michal Swiatkowski Signed-off-by:

[Intel-wired-lan] [PATCH iwl-next v5] ice: Add automatic VF reset on Tx MDD events

2024-04-04 Thread Marcin Szycik
-by: Liang-Min Wang Signed-off-by: Marcin Szycik --- v5: Reword title and commit message to be more explicit and informative v4 [4]: Only perform auto-reset once per VF v3 [3]: Only auto reset VF if the mdd-auto-reset-vf flag is set v2 [2]: Revert an unneeded formatting change, fix commit message, fix

Re: [Intel-wired-lan] [PATCH iwl-next v4] ice: Reset VF on Tx MDD event

2024-04-03 Thread Marcin Szycik
On 03.04.2024 08:37, Loktionov, Aleksandr wrote: > > >> -Original Message- >> From: Intel-wired-lan On >> Behalf Of Marcin Szycik >> Sent: Tuesday, April 2, 2024 6:52 PM >> To: intel-wired-...@lists.osuosl.org >> Cc: Drewek, Wojciech ; W

[Intel-wired-lan] [PATCH iwl-next v4] ice: Reset VF on Tx MDD event

2024-04-02 Thread Marcin Szycik
-by: Przemek Kitszel Co-developed-by: Liang-Min Wang Signed-off-by: Liang-Min Wang Signed-off-by: Marcin Szycik --- v4: Only perform auto-reset once per VF v3 [1]: Only auto reset VF if the mdd-auto-reset-vf flag is set v2 [2]: Revert an unneeded formatting change, fix commit message, fix a log

Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: Reset VF on Tx MDD event

2024-03-29 Thread Marcin Szycik
On 29.03.2024 12:31, Marcin Szycik wrote: > > > On 28.03.2024 18:34, Simon Horman wrote: >> On Tue, Mar 26, 2024 at 05:44:55PM +0100, Marcin Szycik wrote: >>> In cases when VF sends malformed packets that are classified as malicious, >>> sometimes it cause

Re: [Intel-wired-lan] [PATCH iwl-next v3] ice: Reset VF on Tx MDD event

2024-03-29 Thread Marcin Szycik
On 28.03.2024 18:34, Simon Horman wrote: > On Tue, Mar 26, 2024 at 05:44:55PM +0100, Marcin Szycik wrote: >> In cases when VF sends malformed packets that are classified as malicious, >> sometimes it causes Tx queue to freeze. This frozen queue can be stuck >> for several m

[Intel-wired-lan] [PATCH iwl-next v3] ice: Reset VF on Tx MDD event

2024-03-26 Thread Marcin Szycik
-Min Wang Signed-off-by: Liang-Min Wang Signed-off-by: Marcin Szycik --- v3: Only auto reset VF if the mdd-auto-reset-vf flag is set v2 [1]: Revert an unneeded formatting change, fix commit message, fix a log message with a correct event name [1] https://lore.kernel.org/netdev

Re: [Intel-wired-lan] [PATCH net-next v3 1/3] ice: add ice_adapter for shared data across PFs on the same NIC

2024-03-08 Thread Marcin Szycik
On 07.03.2024 23:25, Michal Schmidt wrote: > There is a need for synchronization between ice PFs on the same physical > adapter. > > Add a "struct ice_adapter" for holding data shared between PFs of the > same multifunction PCI device. The struct is refcounted - each ice_pf > holds a reference

Re: [Intel-wired-lan] [PATCH net-next v7 2/2] ice: Implement RSS settings for GTP using ethtool

2024-02-01 Thread Marcin Szycik
4 > and IPv6, utilizing the newly defined hash options. > > The implementation covers the handling of gtpu(4|6), gtpc(4|6), gtpc(4|6)t, > gtpu(4|6)e, gtpu(4|6)u, and gtpu(4|6)d traffic, providing enhanced load > distribution for GTP traffic across multiple processing units.

Re: [Intel-wired-lan] [PATCH net-next v7 1/2] ethtool: Add GTP RSS hash options to ethtool.h

2024-02-01 Thread Marcin Szycik
if there's a bias > in the terminals connected to a particular base station.This case can be > solved by using this patch. Reviewed-by: Marcin Szycik > Signed-off-by: Takeru Hayasaka > --- > v2->v3: Based on Harald-san's review, I added documentation and comments to

Re: [Intel-wired-lan] [PATCH net-next v5] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-31 Thread Marcin Szycik
if there's a bias > in the terminals connected to a particular base station.This case can be > solved by using this patch. LGTM Reviewed-by: Marcin Szycik > Signed-off-by: Takeru Hayasaka > --- > v2->v3: Based on Harald-san's review, I added documentation and comments to

Re: [Intel-wired-lan] [PATCH net-next v4] ethtool: ice: Support for RSS settings to GTP

2024-01-30 Thread Marcin Szycik
On 30.01.2024 10:53, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using ethtool. > > A user can include her TEID and make RSS work for GTP-U over IPv4 by doing the Remove "her" (sorry for missing it last time). > following:`ethtool -N ens3

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-30 Thread Marcin Szycik
On 30.01.2024 07:39, takeru hayasaka wrote: > Hi Marcin-san > Thanks for your review! > >> Do I understand correctly that all gtpu* include TEID? Maybe write it here. > Yes, that's correct. > >> It would be nice to see a link to the patch that added GTP and 'e' flag >> support > to ethtool

Re: [Intel-wired-lan] [PATCH net-next RESENT v3] ethtool: ice: Support for RSS settings to GTP from ethtool

2024-01-29 Thread Marcin Szycik
On 27.01.2024 15:07, Takeru Hayasaka wrote: > This is a patch that enables RSS functionality for GTP packets using ethtool. > > A user can include her TEID and make RSS work for GTP-U over IPv4 by doing > the following: > `ethtool -N ens3 rx-flow-hash gtpu4 sde` > > In addition to gtpu(4|6),

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Add check for lport extraction to LAG init

2024-01-22 Thread Marcin Szycik
> Add a check into the initialization flow that will bypass the new paths > if any of the support pieces are missing. > > Reviewed-by: Przemek Kitszel Reviewed-by: Marcin Szycik > Fixes: df006dd4b1dc ("ice: Add initial support framework for LAG") > Signed-off-by: Dave Ertm

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Marcin Szycik
On 15.12.2023 17:49, Jakub Kicinski wrote: > On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: >> Ping? :s >> Or should we resubmit? > > Can you wait for next merge window instead? > We're getting flooded with patches as everyone seemingly tries to get > their own (i.e. the most

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-12 Thread Marcin Szycik
On 11.12.2023 22:23, Tony Nguyen wrote: > > > On 12/11/2023 4:38 AM, Alexander Lobakin wrote: >> From: Tony Nguyen >> Date: Fri, 8 Dec 2023 13:34:10 -0800 >> >>> >>> >>> On 12/7/2023 8:49 AM, Marcin Szycik wrote: >>>> Add su

[Intel-wired-lan] [PATCH iwl-next v4 2/7] ip_tunnel: convert __be16 tunnel flags to bitmaps

2023-12-07 Thread Marcin Szycik
eof(long) > sizeof(__be16), as %__IP_TUNNEL_FLAG_NUM is less than %BITS_PER_LONG and the compilers are able to expand the majority of bitmap_*() calls here into direct operations on scalars. Reviewed-by: Simon Horman Signed-off-by: Alexander Lobakin Signed-off-by: Marcin Szycik ---

[Intel-wired-lan] [PATCH iwl-next v4 7/7] ice: Add support for PFCP hardware offload in switchdev

2023-12-07 Thread Marcin Szycik
-marcin.szy...@linux.intel.com [1] Reviewed-by: Simon Horman Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_ddp.c | 9 ++ .../net/ethernet/intel/ice/ice_flex_type.h| 4 +- .../ethernet/intel/ice/ice_protocol_type.h| 12 +++ drivers/net/ethernet/intel/ice

[Intel-wired-lan] [PATCH iwl-next v4 5/7] pfcp: always set pfcp metadata

2023-12-07 Thread Marcin Szycik
From: Michal Swiatkowski In PFCP receive path set metadata needed by flower code to do correct classification based on this metadata. Signed-off-by: Michal Swiatkowski Reviewed-by: Simon Horman Signed-off-by: Marcin Szycik --- drivers/net/pfcp.c | 81

[Intel-wired-lan] [PATCH iwl-next v4 6/7] ice: refactor ICE_TC_FLWR_FIELD_ENC_OPTS

2023-12-07 Thread Marcin Szycik
FLOW_DISSECTOR_KEY_ENC_OPTS - instead of checking tunnel type in ice_tc_count_lkups() and ice_tc_fill_tunnel_outer(), it needs to be checked only once, in ice_parse_tunnel_attr(). Reviewed-by: Simon Horman Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 10 +- drivers/net/ethernet

[Intel-wired-lan] [PATCH iwl-next v4 4/7] pfcp: add PFCP module

2023-12-07 Thread Marcin Szycik
. Only IPv4 is supported at this time. [1] https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=3111 Signed-off-by: Wojciech Drewek Reviewed-by: Simon Horman Signed-off-by: Marcin Szycik --- drivers/net/Kconfig | 13 +++ drivers/net/Makefile | 1

[Intel-wired-lan] [PATCH iwl-next v4 3/7] lib/bitmap: add tests for IP tunnel flags conversion helpers

2023-12-07 Thread Marcin Szycik
. When BIT(17) is finally here, it will be adjusted accordingly. Signed-off-by: Alexander Lobakin Signed-off-by: Marcin Szycik --- lib/test_bitmap.c | 105 ++ 1 file changed, 105 insertions(+) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index

[Intel-wired-lan] [PATCH iwl-next v4 1/7] ip_tunnel: use a separate struct to store tunnel params in the kernel

2023-12-07 Thread Marcin Szycik
easily modified later on and the users wouldn't have to care about this. Reviewed-by: Simon Horman Signed-off-by: Alexander Lobakin Signed-off-by: Marcin Szycik --- .../ethernet/mellanox/mlxsw/spectrum_ipip.c | 30 + .../ethernet/mellanox/mlxsw/spectrum_ipip.h | 2 +- .../et

[Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-07 Thread Marcin Szycik
add tests for IP tunnel flags conversion helpers Marcin Szycik (2): ice: refactor ICE_TC_FLWR_FIELD_ENC_OPTS ice: Add support for PFCP hardware offload in switchdev Michal Swiatkowski (1): pfcp: always set pfcp metadata Wojciech Drewek (1): pfcp: add PFCP module drivers/n

[Intel-wired-lan] [PATCH iwl-net] ice: Restore fix disabling RX VLAN filtering

2023-11-07 Thread Marcin Szycik
fix along with the original comment from that change. Also delete duplicate lines in ice_port_vlan_on(). Fixes: 2946204b3fa8 ("ice: implement bridge port vlan") Reviewed-by: Wojciech Drewek Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_vf_vsi_vlan_ops.c | 11

[Intel-wired-lan] [PATCH iwl-net] ice: Fix VF-VF direction matching in drop rule in switchdev

2023-10-25 Thread Marcin Szycik
is a port representor, otherwise set it to ingress. Fixes: 0960a27bd479 ("ice: Add direction metadata") Reviewed-by: Michal Swiatkowski Signed-off-by: Marcin Szycik --- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 24 - 1 file changed, 23 insertions(+), 1 deletio